public inbox for regressions@lists.linux.dev
 help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Askar Safin <safinaskar@gmail.com>
Cc: Dell.Client.Kernel@dell.com, bartosz.golaszewski@linaro.org,
	benjamin.tissoires@redhat.com, dmitry.torokhov@gmail.com,
	linux-acpi@vger.kernel.org, linux-gpio@vger.kernel.org,
	linux-i2c@vger.kernel.org, regressions@lists.linux.dev,
	rrangel@chromium.org, superm1@kernel.org,
	wse@tuxedocomputers.com
Subject: Re: [REGRESSION][BISECTED] Dell Precision 7780 wakes up on its own from suspend
Date: Sun, 7 Dec 2025 12:18:18 +0200	[thread overview]
Message-ID: <aTVUakljrd-sysxP@smile.fi.intel.com> (raw)
In-Reply-To: <20251207040459.3581966-1-safinaskar@gmail.com>

On Sun, Dec 07, 2025 at 07:04:59AM +0300, Askar Safin wrote:
> Andy, Mario and others.
> 
> During these months I found zillions of suspend and hibernation related bugs.
> 
> It seems hibernation is not well supported.
> 
> For example, it seems hibernation is not supported on Chromebooks [1].
> 
> And Fedora intentionally disables it by default. [2]
> 
> Other operating systems do similar thing. Hibernation is hard-to-enable
> in Windows [3]. macOS on Apple Silicon hibernate in very limited scenarios [4].
> 
> But I still use hibernation.
> 
> So, I have an idea. Maybe we should remove as many as possible hibernation-related
> code from kernel to make sure that remaining code is easy to support?

Maybe not.

> I. e. maybe we should remove some even-more-obscure-than-hibernation features,
> such as hybrid sleep mode, to make normal hibernation easier to maintain?

Hibernation is not only for workstations. And I believe it works in Linux to
some extent. You need to discuss this in Linux PM mailing list.

> If you like this idea, then I will happily write patches for removing
> some hibernation-related features, such as hybrid sleep mode.
> 
> Other ideas:
> - Remove uswsusp (i. e. kernel/power/user.c ) in favor of normal hibernation
> (or vice versa, i. e. remove normal hibernation and keep uswsusp only)
> - Remove hibernation to swap partition and keep hibernation to swapfile only
> (or vice versa)
> - Decouple hibernation from swap completely (i. e. hibernate not to swap
> partition, but to special designated partition or file)
> 
> In short, just tell me what should be removed, and I will happily remove it.

I think nothing. It's better to try to actually fix the non-working scenarios
rather than remove the feature completely.

> [1] https://www.reddit.com/r/chromeos/comments/y5pol9/anyone_know_what_the_status_of_hiberman_hibernate/
> [2] https://pagure.io/fedora-workstation/blob/master/f/notes/hibernationstatus.md
> [3] https://www.groovypost.com/howto/enable-hibernate-mode-windows-10/
> [4] https://www.reddit.com/r/chromeos/comments/y5pol9/comment/ism352k/

P.S.
I'm sorry, but why are you so eager to remove something? While in many cases
removal of (potentially dead or unused) code is considered a good thing, it's
not always the case.

-- 
With Best Regards,
Andy Shevchenko



  reply	other threads:[~2025-12-07 10:18 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-26 23:32 [REGRESSION][BISECTED] Dell Precision 7780 wakes up on its own from suspend Askar Safin
2025-06-27  0:35 ` Mario Limonciello
2025-06-27  3:51   ` Askar Safin
2025-06-27  3:58     ` Mario Limonciello
2025-06-30  7:14       ` Askar Safin
2025-06-30 18:40         ` Mario Limonciello
2025-07-17 23:29           ` Askar Safin
2025-07-18 15:13             ` Werner Sembach
2025-07-18 15:20               ` Mario Limonciello
2025-08-25 15:34           ` Andy Shevchenko
2025-08-25 15:36             ` Andy Shevchenko
2025-09-18 18:33               ` Askar Safin
2025-11-09 19:05                 ` Andy Shevchenko
2025-11-09 19:08                   ` Andy Shevchenko
2025-12-05  2:16                     ` Askar Safin
2025-12-05  2:52                       ` Mario Limonciello (AMD) (kernel.org)
2025-12-05  4:01                         ` Askar Safin
2025-12-05  5:21                           ` Mario Limonciello (AMD) (kernel.org)
2025-12-05 13:52                             ` Andy Shevchenko
2025-12-07  4:04                               ` Askar Safin
2025-12-07 10:18                                 ` Andy Shevchenko [this message]
2025-12-07 16:45                                   ` Askar Safin
2025-12-07 22:35                                     ` Andy Shevchenko
2025-12-05 13:55                       ` Andy Shevchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aTVUakljrd-sysxP@smile.fi.intel.com \
    --to=andriy.shevchenko@linux.intel.com \
    --cc=Dell.Client.Kernel@dell.com \
    --cc=bartosz.golaszewski@linaro.org \
    --cc=benjamin.tissoires@redhat.com \
    --cc=dmitry.torokhov@gmail.com \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-i2c@vger.kernel.org \
    --cc=regressions@lists.linux.dev \
    --cc=rrangel@chromium.org \
    --cc=safinaskar@gmail.com \
    --cc=superm1@kernel.org \
    --cc=wse@tuxedocomputers.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox