reiserfs-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: <doiggl@velocitynet.com.au>
To: reiserfs-devel@vger.kernel.org
Subject: Re: Formal Reiser4 inclusion and todo list?
Date: Wed, 28 Jul 2010 15:21:37 +0000	[thread overview]
Message-ID: <0d42c3ebde41a3d0bcc01f9fccc07f1c@mail.velocitynet.com.au> (raw)
In-Reply-To: <49F393A1.4030004@gmail.com>


> The following items are still unaddressed:
> 
> 1. running igrab() in the writepage() path is really going to hammer
>    inode_lock.  Something else will need to be done here.
> 
> 2. Running iput() in entd() is a bit surprising.  iirc there are various

> ways
>    in which this can recur into the filesystem, perform I/O, etc.  I 
> guess it
>    works..
>    But again, it will hammer inode_lock.
> 
> 3. the writeout logic in entd_flush() is interesting (as in "holy cow").
>    It's very central and really needs some good comments describing
what's
>    going on in there - what problems are being solved, which decisions
were
>    taken and why, etc.
> 
> 4. reiser4_wait_page_writeback() needs commenting.
> 
> 5. reading the comment in txnmgr.c regarding MAP_SHARED pages: a number
of
>    things have changed since then.  We have page-becoming-writeable
>    notifications and probably soon we'll always take a pagefault when a
>    MAP_SHARED page transitions from pte-clean to pte-dirty (although I 
> wouldn't
>    recommend that a filesystem rely upon the latter for a while yet).
> 
> Feel free to address them.
> 
> Thanks,
> Edward.

Has the number of items reduced at all ?
just curious
Cheers Glenn 


  reply	other threads:[~2010-07-28 15:21 UTC|newest]

Thread overview: 51+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-18 20:14 reiser4 inclusion? Christian Kujau
2009-04-19 10:23 ` Christian Stroetmann OntoLab
2009-04-19 12:51   ` Edward Shishkin
2009-04-19 11:14     ` Bron Gondwana
2009-04-19 11:31       ` Alexander Lyamin
2009-04-19 11:43         ` Mat
2009-04-19 11:47         ` Bron Gondwana
2009-04-19 12:09           ` Dushan Tcholich
2009-04-19 12:32             ` Bron Gondwana
2009-04-19 12:45               ` Alexander Lyamin
2009-04-19 13:00                 ` Bron Gondwana
2009-04-19 13:32                   ` Alexander Lyamin
2009-04-19 14:00                     ` Bron Gondwana
2009-04-19 13:08               ` Dushan Tcholich
2009-04-19 13:24                 ` Bron Gondwana
2009-04-24 23:35     ` Jason Todd Slack-Moehrle
2009-04-24 23:53       ` Volker Armin Hemmann
2009-04-25  0:01         ` Jason Todd Slack-Moehrle
2009-04-25  0:15           ` Christian Stroetmann OntoLab
2009-04-25  0:28             ` Volker Armin Hemmann
2009-04-25  0:42               ` Christian Stroetmann OntoLab
     [not found]           ` <49F2CF9A.1060202@inn.nl>
2009-04-25  9:13             ` Christian Stroetmann OntoLab
2009-04-25 11:16               ` Alli Quaknaa
2009-04-25 16:26                 ` Christian Stroetmann OntoLab
     [not found]                   ` <8c113a260904251204u41f90028n975006634ed99e59@mail.gmail.com>
2009-04-25 20:15                     ` Christian Stroetmann OntoLab
2009-04-25 21:04                       ` Alli Quaknaa
2009-04-25 23:18                         ` Christian Stroetmann OntoLab
2009-04-25 23:52                           ` Mat
2009-04-26  8:50                             ` reiser4 inclusion and beyond Christian Stroetmann OntoLab
2009-04-26 10:18                               ` Marcel Hilzinger
2009-04-26 11:27                                 ` Alli Quaknaa
2009-04-26  8:53                             ` reiser4 inclusion? Christian Stroetmann OntoLab
2009-04-25 20:27                   ` Formal Reiser4 inclusion and todo list? William Fisher
2009-04-25 22:50                     ` Edward Shishkin
2010-07-28 15:21                       ` doiggl [this message]
2010-07-28 19:58                         ` Christian Stroetmann
2010-08-01 13:43                           ` Christian Stroetmann
2010-08-01 13:58                             ` Volker Armin Hemmann
2010-08-01 14:14                               ` Christian Stroetmann
2010-08-01 14:23                                 ` Volker Armin Hemmann
2010-08-01 14:36                                   ` Christian Stroetmann
2010-08-02  7:25                             ` Nick Piggin
2010-08-02 13:13                               ` Edward Shishkin
2010-08-02 14:30                             ` Ralph Ulrich
2010-08-02 17:37                               ` Christian Stroetmann
2009-04-25  0:03         ` reiser4 inclusion? Christian Stroetmann OntoLab
     [not found]           ` <200904250235.52257.volkerarmin@googlemail.com>
2009-04-25  0:49             ` Christian Stroetmann OntoLab
2009-04-24 23:58       ` Christian Stroetmann OntoLab
2009-04-25  0:25         ` Volker Armin Hemmann
2009-04-25  0:33           ` Christian Stroetmann OntoLab
2009-04-26 11:03         ` Alexander Lyamin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0d42c3ebde41a3d0bcc01f9fccc07f1c@mail.velocitynet.com.au \
    --to=doiggl@velocitynet.com.au \
    --cc=reiserfs-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).