From: Mimi Zohar <zohar@linux.vnet.ibm.com>
To: reiserfs-devel@vger.kernel.org
Cc: linux-security-module <linux-security-module@vger.kernel.org>
Subject: Re: [Ocfs2-devel] freeing memory allocated in security_inode_init_security()
Date: Wed, 04 May 2011 16:57:29 -0400 [thread overview]
Message-ID: <1304542649.3227.78.camel@localhost.localdomain> (raw)
In-Reply-To: <1304536698.3227.36.camel@localhost.localdomain>
On Wed, 2011-05-04 at 15:18 -0400, Mimi Zohar wrote:
> Hi,
>
> Although it isn't documented in security.c, the LSM
> security_inode_init_security() hook allocates memory for xattr name and
> value, expecting the caller to release the memory afterwards.
>
> I'm making my way through the different filesystems adding a subsequent
> call to evm_inode_post_init_security(). I see the call to
> ocfs2_init_security_and_acl() calls ocfs2_init_security_get(), which in
> turn calls security_inode_init_security(), but am having a hard time
> finding where the name and value are subsequently freed. Would
> appreciate if someone could point it out.
>
> thanks,
>
> Mimi
Although the reiserfs_security_init() comment explicitly states that the
caller must call reiserfs_security_free(), I don't see it being done.
Mimi
parent reply other threads:[~2011-05-04 20:57 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <1304536698.3227.36.camel@localhost.localdomain>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1304542649.3227.78.camel@localhost.localdomain \
--to=zohar@linux.vnet.ibm.com \
--cc=linux-security-module@vger.kernel.org \
--cc=reiserfs-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).