From: Artem Bityutskiy <dedekind1@gmail.com>
To: Al Viro <viro@ZenIV.linux.org.uk>
Cc: Linux FS Maling List <linux-fsdevel@vger.kernel.org>,
Linux Kernel Maling List <linux-kernel@vger.kernel.org>,
reiserfs-devel@vger.kernel.org
Subject: [PATCH 3/5] reiserfs: remove useless superblock dirtying
Date: Fri, 1 Jun 2012 17:18:06 +0300 [thread overview]
Message-ID: <1338560288-10727-4-git-send-email-dedekind1@gmail.com> (raw)
In-Reply-To: <1338560288-10727-1-git-send-email-dedekind1@gmail.com>
From: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
The 'reiserfs_resize()' function marks the superblock as dirty by assigning 1
to 's_dirt' and then calls 'journal_mark_dirty()' which does the same. Thus,
we can remove the assignment from 'reiserfs_resize()'.
Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
---
fs/reiserfs/resize.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/fs/reiserfs/resize.c b/fs/reiserfs/resize.c
index 9a17f63..3ce02cf 100644
--- a/fs/reiserfs/resize.c
+++ b/fs/reiserfs/resize.c
@@ -200,7 +200,6 @@ int reiserfs_resize(struct super_block *s, unsigned long block_count_new)
(bmap_nr_new - bmap_nr)));
PUT_SB_BLOCK_COUNT(s, block_count_new);
PUT_SB_BMAP_NR(s, bmap_would_wrap(bmap_nr_new) ? : bmap_nr_new);
- s->s_dirt = 1;
journal_mark_dirty(&th, s, SB_BUFFER_WITH_SB(s));
--
1.7.7.6
next prev parent reply other threads:[~2012-06-01 14:18 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-01 14:18 [PATCH 0/5] reiserfs: stop using write_supers and s_dirt Artem Bityutskiy
2012-06-01 14:18 ` [PATCH 1/5] reiserfs: cleanup reiserfs_fill_super a bit Artem Bityutskiy
2012-06-01 14:18 ` [PATCH 2/5] reiserfs: clean-up function return type Artem Bityutskiy
2012-06-01 14:18 ` Artem Bityutskiy [this message]
2012-06-01 14:18 ` [PATCH 4/5] reiserfs: mark the superblock as dirty a bit later Artem Bityutskiy
2012-06-01 14:18 ` [PATCH 5/5] reiserfs: get rid of resierfs_sync_super Artem Bityutskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1338560288-10727-4-git-send-email-dedekind1@gmail.com \
--to=dedekind1@gmail.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=reiserfs-devel@vger.kernel.org \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).