From: Ivan Shapovalov <intelfx100@gmail.com>
To: reiserfs-devel@vger.kernel.org
Cc: edward.shishkin@gmail.com, Ivan Shapovalov <intelfx100@gmail.com>
Subject: [RFC] [PATCHv3 9/9] reiser4: batch discard support: honor minimal extent length passed from the userspace.
Date: Mon, 18 Aug 2014 01:52:59 +0400 [thread overview]
Message-ID: <1408312379-1990-10-git-send-email-intelfx100@gmail.com> (raw)
In-Reply-To: <1408312379-1990-1-git-send-email-intelfx100@gmail.com>
---
fs/reiser4/super_ops.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/fs/reiser4/super_ops.c b/fs/reiser4/super_ops.c
index d232f30..f4cf0ff 100644
--- a/fs/reiser4/super_ops.c
+++ b/fs/reiser4/super_ops.c
@@ -481,7 +481,7 @@ static int reiser4_show_options(struct seq_file *m, struct dentry *dentry)
int reiser4_trim_fs(struct super_block *super, struct fstrim_range* range)
{
reiser4_blocknr_hint hint;
- reiser4_block_nr start, end, len, minlen, discarded_count = 0;
+ reiser4_block_nr start, end, len, discarded_count = 0;
reiser4_context *ctx;
txn_atom *atom;
int ret, finished = 0;
@@ -495,11 +495,11 @@ int reiser4_trim_fs(struct super_block *super, struct fstrim_range* range)
*/
hint.blk = range->start >> super->s_blocksize_bits;
hint.max_dist = range->len >> super->s_blocksize_bits;
+ hint.min_len = range->minlen >> super->s_blocksize_bits;
hint.block_stage = BLOCK_GRABBED;
hint.forward = 1;
end = hint.blk + hint.max_dist;
- minlen = range->minlen >> super->s_blocksize_bits;
/*
* We will perform the process in iterations in order not to starve
@@ -532,7 +532,6 @@ int reiser4_trim_fs(struct super_block *super, struct fstrim_range* range)
while (ctx->grabbed_blocks != 0) {
/*
* Allocate no more than is grabbed.
- * FIXME: use minlen.
*/
len = ctx->grabbed_blocks;
ret = reiser4_alloc_blocks(&hint, &start, &len, 0 /* flags */);
--
2.0.4
next prev parent reply other threads:[~2014-08-17 21:52 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-17 21:52 [RFC] [PATCHv3 0/9] reiser4: batch discard support (FITRIM ioctl): initial implementation Ivan Shapovalov
2014-08-17 21:52 ` [RFC] [PATCHv3 1/9] reiser4: block_alloc: add BA_SOME_SPACE flag for grabbing a fixed amount of space Ivan Shapovalov
2014-10-19 22:04 ` Edward Shishkin
2014-10-20 10:36 ` Ivan Shapovalov
2014-10-21 10:32 ` Edward Shishkin
2014-10-21 16:17 ` Ivan Shapovalov
2014-08-17 21:52 ` [RFC] [PATCHv3 2/9] reiser4: block_alloc: add a "forward" parameter to reiser4_blocknr_hint to allocate blocks only in forward direction Ivan Shapovalov
2014-10-21 15:50 ` Edward Shishkin
2014-10-23 7:24 ` Ivan Shapovalov
2014-10-23 14:37 ` Edward Shishkin
2014-10-23 20:58 ` Ivan Shapovalov
2014-10-26 16:45 ` Edward Shishkin
2014-10-26 23:21 ` Ivan Shapovalov
2014-08-17 21:52 ` [RFC] [PATCHv3 3/9] reiser4: txnmgr: free allocated but unneeded atom in atom_begin_and_assign_to_txnh() Ivan Shapovalov
2014-08-17 21:52 ` [RFC] [PATCHv3 4/9] reiser4: txnmgr: add reiser4_create_atom() which creates an empty atom without capturing any nodes Ivan Shapovalov
2014-08-17 21:52 ` [RFC] [PATCHv3 5/9] reiser4: txnmgr: call reiser4_post_write_back_hook() also for empty atoms Ivan Shapovalov
2014-08-17 21:52 ` [RFC] [PATCHv3 6/9] reiser4: batch discard support: add a dummy FITRIM ioctl handler for directories Ivan Shapovalov
2014-08-17 21:52 ` [RFC] [PATCHv3 7/9] reiser4: batch discard support: actually implement the FITRIM ioctl handler Ivan Shapovalov
2014-10-20 10:54 ` Edward Shishkin
2014-10-20 22:39 ` Ivan Shapovalov
2014-10-21 10:14 ` Edward Shishkin
2014-10-21 16:18 ` Ivan Shapovalov
2014-10-21 16:21 ` Edward Shishkin
2014-10-21 16:23 ` Ivan Shapovalov
2014-10-21 16:33 ` Edward Shishkin
2014-10-21 16:42 ` Ivan Shapovalov
2014-10-21 18:01 ` Edward Shishkin
2014-10-21 18:11 ` Ivan Shapovalov
2014-10-21 18:48 ` Edward Shishkin
2014-10-21 19:00 ` Ivan Shapovalov
2014-10-21 19:13 ` Edward Shishkin
2014-08-17 21:52 ` [RFC] [PATCHv3 8/9] reiser4: block_alloc: add a "min_len" parameter to reiser4_blocknr_hint to limit allocated extent length from below Ivan Shapovalov
2014-08-17 21:52 ` Ivan Shapovalov [this message]
2014-08-17 21:56 ` [RFC] [PATCHv3 0/9] reiser4: batch discard support (FITRIM ioctl): initial implementation Ivan Shapovalov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1408312379-1990-10-git-send-email-intelfx100@gmail.com \
--to=intelfx100@gmail.com \
--cc=edward.shishkin@gmail.com \
--cc=reiserfs-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).