From: Ivan Shapovalov <intelfx100@gmail.com>
To: reiserfs-devel@vger.kernel.org
Cc: edward.shishkin@gmail.com, Ivan Shapovalov <intelfx100@gmail.com>
Subject: [RFC] [PATCHv2 1/3] reiser4: deferred (BA_DEFER) deallocations do not make use of target stage.
Date: Mon, 8 Sep 2014 22:43:49 +0400 [thread overview]
Message-ID: <1410201831-11722-2-git-send-email-intelfx100@gmail.com> (raw)
In-Reply-To: <1410201831-11722-1-git-send-email-intelfx100@gmail.com>
...so remove it (set to 0) in all cases to avoid confusion.
Signed-off-by: Ivan Shapovalov <intelfx100@gmail.com>
---
fs/reiser4/block_alloc.c | 6 ++++++
fs/reiser4/plugin/txmod.c | 15 +++++----------
2 files changed, 11 insertions(+), 10 deletions(-)
diff --git a/fs/reiser4/block_alloc.c b/fs/reiser4/block_alloc.c
index 324b11c..6e7030a 100644
--- a/fs/reiser4/block_alloc.c
+++ b/fs/reiser4/block_alloc.c
@@ -1010,6 +1010,12 @@ reiser4_dealloc_blocks(const reiser4_block_nr * start,
if ((flags & BA_DEFER) ||
reiser4_is_set(reiser4_get_current_sb(), REISER4_DISCARD)) {
+ /*
+ * These blocks will be later deallocated by apply_dset().
+ * It is equivalent to a non-deferred deallocation with target
+ * stage BLOCK_NOT_COUNTED.
+ */
+
/* store deleted block numbers in the atom's deferred delete set
for further actual deletion */
do {
diff --git a/fs/reiser4/plugin/txmod.c b/fs/reiser4/plugin/txmod.c
index 63d461f..5982b4c 100644
--- a/fs/reiser4/plugin/txmod.c
+++ b/fs/reiser4/plugin/txmod.c
@@ -287,8 +287,7 @@ static int forward_relocate_unformatted(flush_pos_t *flush_pos,
* on relocating - free nodes which are going to be
* relocated
*/
- reiser4_dealloc_blocks(&start, &allocated,
- BLOCK_ALLOCATED, BA_DEFER);
+ reiser4_dealloc_blocks(&start, &allocated, 0, BA_DEFER);
/* assign new block numbers to protected nodes */
assign_real_blocknrs(flush_pos, oid, index, allocated, first_allocated);
@@ -386,16 +385,13 @@ static squeeze_result squeeze_relocate_unformatted(znode *left,
result = put_unit_to_end(left, key, ©_extent);
if (result == -E_NODE_FULL) {
- int target_block_stage;
/*
* free blocks which were just allocated
*/
- target_block_stage =
- (state ==
- ALLOCATED_EXTENT) ? BLOCK_FLUSH_RESERVED :
- BLOCK_UNALLOCATED;
reiser4_dealloc_blocks(&first_allocated, &allocated,
- target_block_stage,
+ (state == ALLOCATED_EXTENT)
+ ? BLOCK_FLUSH_RESERVED
+ : BLOCK_UNALLOCATED,
BA_PERMANENT);
/*
* rewind the preceder
@@ -408,8 +404,7 @@ static squeeze_result squeeze_relocate_unformatted(znode *left,
/*
* free nodes which were relocated
*/
- reiser4_dealloc_blocks(&start, &allocated,
- BLOCK_ALLOCATED, BA_DEFER);
+ reiser4_dealloc_blocks(&start, &allocated, 0, BA_DEFER);
}
/*
* assign new block numbers to protected nodes
--
2.1.0
next prev parent reply other threads:[~2014-09-08 18:43 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-08 18:43 [RFC] [PATCHv2 0/3] reiser4: block deallocation fixes Ivan Shapovalov
2014-09-08 18:43 ` Ivan Shapovalov [this message]
2014-09-08 18:43 ` [RFC] [PATCHv2 2/3] reiser4: mark final deallocations in wandering log code as deferred Ivan Shapovalov
2014-09-08 18:43 ` [RFC] [PATCHv2 3/3] reiser4: block_alloc: get rid of discard-related hack in reiser4_dealloc_blocks() Ivan Shapovalov
2014-09-08 19:03 ` [RFC] [PATCHv2 0/3] reiser4: block deallocation fixes Edward Shishkin
2014-09-08 19:52 ` Ivan Shapovalov
2014-09-08 20:19 ` Edward Shishkin
2014-09-08 21:13 ` Ivan Shapovalov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1410201831-11722-2-git-send-email-intelfx100@gmail.com \
--to=intelfx100@gmail.com \
--cc=edward.shishkin@gmail.com \
--cc=reiserfs-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).