From: Ivan Shapovalov <intelfx100@gmail.com>
To: reiserfs-devel@vger.kernel.org
Cc: Ivan Shapovalov <intelfx100@gmail.com>
Subject: [PATCH 0/3] reiser4: precise discard: fixes on top of everything
Date: Fri, 13 Feb 2015 08:02:55 +0300 [thread overview]
Message-ID: <1423803778-19698-1-git-send-email-intelfx100@gmail.com> (raw)
Here we fix two bugs in the precise discard implementation.
The first one is handling of "nearby" tail and head paddings which are parts
of the same disk block. Our block checking function is not idempotent, and
repeatedly calling it on the same block results in a false-negative. The fix is
to remember the last checked range (the tail padding) of an extent, and then
use this information during checking the head padding of the next extent.
Information about preceding blocks is never needed.
The second one is handling of discard extents at the end of the partition: we
must avoid checking blocks outside of the partition. The similar check already
exists for the first erase unit in the partition.
Ivan Shapovalov (3):
reiser4: discard: signify non-idempotence of check_free_blocks() by changing its name.
reiser4: discard: avoid checking same blocks multiple times.
reiser4: discard: handle incomplete erase units at the end of a partition.
fs/reiser4/discard.c | 194 +++++++++++++++++++++++++++++++++++++++++++--------
1 file changed, 165 insertions(+), 29 deletions(-)
--
2.3.0
next reply other threads:[~2015-02-13 5:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-13 5:02 Ivan Shapovalov [this message]
2015-02-13 5:02 ` [PATCH 1/3] reiser4: discard: signify non-idempotence of check_free_blocks() by changing its name Ivan Shapovalov
2015-02-13 5:02 ` [PATCH 2/3] reiser4: discard: avoid checking same blocks multiple times Ivan Shapovalov
2015-02-13 9:04 ` Edward Shishkin
2015-02-13 5:02 ` [PATCH 3/3] reiser4: discard: handle incomplete erase units at the end of a partition Ivan Shapovalov
2015-02-13 9:05 ` Edward Shishkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1423803778-19698-1-git-send-email-intelfx100@gmail.com \
--to=intelfx100@gmail.com \
--cc=reiserfs-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).