From: Ivan Shapovalov <intelfx100@gmail.com>
To: reiserfs-devel@vger.kernel.org
Cc: Edward Shishkin <edward.shishkin@gmail.com>,
Ivan Shapovalov <intelfx100@gmail.com>
Subject: [PATCH 3/3] reiser4: report an error on checksum engine load failure.
Date: Mon, 14 Sep 2015 02:08:40 +0300 [thread overview]
Message-ID: <1442185720-25185-3-git-send-email-intelfx100@gmail.com> (raw)
In-Reply-To: <1442185720-25185-1-git-send-email-intelfx100@gmail.com>
It is apparently not possible to specify explicit module dependencies.
For well-formed setups this is not a problem because
crypto_alloc_shash() uses request_module() internally, but if one needs
reiser4, say, in initramfs, then the checksum module must be added
manually.
Signed-off-by: Ivan Shapovalov <intelfx100@gmail.com>
---
fs/reiser4/checksum.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/fs/reiser4/checksum.c b/fs/reiser4/checksum.c
index 73d40f0..2a35f42 100644
--- a/fs/reiser4/checksum.c
+++ b/fs/reiser4/checksum.c
@@ -7,8 +7,10 @@ int reiser4_init_csum_tfm(struct crypto_shash **tfm)
struct crypto_shash *new_tfm;
new_tfm = crypto_alloc_shash("crc32c", 0, 0);
- if (IS_ERR(new_tfm))
+ if (IS_ERR(new_tfm)) {
+ warning("intelfx-81", "Could not load crc32c driver");
return PTR_ERR(new_tfm);
+ }
*tfm = new_tfm;
return 0;
--
2.5.1
next prev parent reply other threads:[~2015-09-13 23:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-13 23:08 [PATCH 1/3] reiser4: fix filesystem init error path Ivan Shapovalov
2015-09-13 23:08 ` [PATCH 2/3] reiser4: fix reiser4_init_csum_tfm() error path; return real (negative) error code Ivan Shapovalov
2015-09-14 7:52 ` Edward Shishkin
2015-09-13 23:08 ` Ivan Shapovalov [this message]
2015-09-14 7:53 ` [PATCH 3/3] reiser4: report an error on checksum engine load failure Edward Shishkin
2015-09-14 7:51 ` [PATCH 1/3] reiser4: fix filesystem init error path Edward Shishkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1442185720-25185-3-git-send-email-intelfx100@gmail.com \
--to=intelfx100@gmail.com \
--cc=edward.shishkin@gmail.com \
--cc=reiserfs-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).