reiserfs-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ivan Shapovalov <intelfx100@gmail.com>
To: reiserfs-devel@vger.kernel.org
Cc: Edward Shishkin <edward.shishkin@gmail.com>,
	Ivan Shapovalov <intelfx100@gmail.com>
Subject: [PATCH] reiser4: fix supported flags check in reiser4_rename2_common().
Date: Mon, 14 Sep 2015 05:21:20 +0300	[thread overview]
Message-ID: <1442197280-31580-1-git-send-email-intelfx100@gmail.com> (raw)

---

This was left behind some time ago. I've just spotted a relevant warning.

 fs/reiser4/plugin/inode_ops_rename.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/reiser4/plugin/inode_ops_rename.c b/fs/reiser4/plugin/inode_ops_rename.c
index 6744e14..ddb7bf5 100644
--- a/fs/reiser4/plugin/inode_ops_rename.c
+++ b/fs/reiser4/plugin/inode_ops_rename.c
@@ -435,7 +435,7 @@ int reiser4_rename2_common(struct inode *old_dir /* directory where @old
 	 * We support:
 	 * - RENAME_NOREPLACE (no-op)
 	 */
-	if (flags & supported_flags != flags)
+	if ((flags & supported_flags) != flags)
 		return RETERR(-EINVAL);
 
 	old_entry = kzalloc(3 * sizeof(*old_entry) + 2 * sizeof(*new_lh) +
-- 
2.5.1


             reply	other threads:[~2015-09-14  2:21 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-14  2:21 Ivan Shapovalov [this message]
2015-09-14  7:55 ` [PATCH] reiser4: fix supported flags check in reiser4_rename2_common() Edward Shishkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1442197280-31580-1-git-send-email-intelfx100@gmail.com \
    --to=intelfx100@gmail.com \
    --cc=edward.shishkin@gmail.com \
    --cc=reiserfs-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).