From: Ivan Shapovalov <intelfx100@gmail.com>
To: reiserfs-devel@vger.kernel.org
Cc: edward.shishkin@gmail.com, Ivan Shapovalov <intelfx100@gmail.com>,
Oleg Drokin <green@linuxhacker.ru>
Subject: [PATCH 3/3] reiser4: in our own sync writes, mark pages dirty before marking them writeback.
Date: Fri, 9 Oct 2015 14:16:57 +0300 [thread overview]
Message-ID: <1444389417-14929-4-git-send-email-intelfx100@gmail.com> (raw)
In-Reply-To: <1444389417-14929-1-git-send-email-intelfx100@gmail.com>
Ref.: https://www.mail-archive.com/linux-f2fs-devel%40lists.sourceforge.net/msg02745.html
Signed-off-by: Ivan Shapovalov <intelfx100@gmail.com>
---
Lustre seemed to encounter the same oops and fixed it in a different way, removing
set_page_writeback() altogether:
https://lkml.org/lkml/2015/7/30/806
We cannot just remove the call to set_page_writeback() at least because later
we wait on PG_Writeback flag of that page (in jwait_io())... What is meant by
"synchronous write" in that Lustre patch? Is our write "synchronous" in the
same sense? I don't know VFS well. Cc'ing Oleg.
fs/reiser4/wander.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/fs/reiser4/wander.c b/fs/reiser4/wander.c
index ce20d50..0e2c105 100644
--- a/fs/reiser4/wander.c
+++ b/fs/reiser4/wander.c
@@ -782,7 +782,9 @@ static int write_jnodes_to_disk_extent(
node_plugin_by_node(JZNODE(cur))->csum(JZNODE(cur), 0);
zrelse(JZNODE(cur));
}
+
ClearPageError(pg);
+ set_page_dirty_notag(pg);
set_page_writeback(pg);
if (get_current_context()->entd) {
--
2.6.0
next prev parent reply other threads:[~2015-10-09 11:16 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-09 11:16 [PATCH 0/3] reiser4: another batch of fixes for 4.2 Ivan Shapovalov
2015-10-09 11:16 ` [PATCH 1/3] reiser4: remove last traces of JNODE_NEW in the debugging code Ivan Shapovalov
2015-10-09 11:16 ` [PATCH 2/3] reiser4: call account_page_redirty() on re-dirtying pages before giving them to entd Ivan Shapovalov
2015-10-09 11:16 ` Ivan Shapovalov [this message]
2015-10-09 13:27 ` [PATCH 3/3] reiser4: in our own sync writes, mark pages dirty before marking them writeback Edward Shishkin
2015-10-09 13:50 ` Ivan Shapovalov
2015-10-09 14:55 ` Edward Shishkin
2015-10-09 16:13 ` Ivan Shapovalov
2015-10-09 16:27 ` Oleg Drokin
2015-10-09 16:29 ` Ivan Shapovalov
2015-10-09 17:14 ` Ivan Shapovalov
2015-10-09 20:23 ` Edward Shishkin
2015-10-10 7:19 ` Dušan Čolić
2015-10-10 10:44 ` Ivan Shapovalov
2015-10-10 15:03 ` Edward Shishkin
2015-10-10 16:51 ` Oleg Drokin
2015-10-12 9:10 ` Edward Shishkin
2015-10-12 9:07 ` Edward Shishkin
2015-10-14 10:05 ` Ivan Shapovalov
2015-10-14 10:55 ` Ivan Shapovalov
2015-10-14 19:06 ` Ivan Shapovalov
2015-10-15 17:20 ` Edward Shishkin
2015-10-24 7:17 ` Ivan Shapovalov
2015-11-04 18:09 ` Ivan Shapovalov
2015-11-09 11:40 ` Edward Shishkin
2015-10-09 15:29 ` Oleg Drokin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1444389417-14929-4-git-send-email-intelfx100@gmail.com \
--to=intelfx100@gmail.com \
--cc=edward.shishkin@gmail.com \
--cc=green@linuxhacker.ru \
--cc=reiserfs-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).