From: Jens Axboe <jens.axboe@oracle.com>
To: Laurent Riffard <laurent.riffard@free.fr>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Neil Brown <neilb@suse.de>, Edward Shishkin <edward@namesys.com>,
linux-kernel@vger.kernel.org, reiserfs-devel@vger.kernel.org
Subject: Re: [PATCH] Reiser4: Drop 'size' argument from bio_endio and bi_end_io
Date: Sat, 13 Oct 2007 12:10:25 +0200 [thread overview]
Message-ID: <20071013101025.GE969@kernel.dk> (raw)
In-Reply-To: <47109016.8000403@free.fr>
On Sat, Oct 13 2007, Laurent Riffard wrote:
> Reiser4: Drop 'size' argument from bio_endio and bi_end_io
>
> This patch pushes into Reiser4 the changes introduced by
> commit 6712ecf8f648118c3363c142196418f89a510b90:
>
> As bi_end_io is only called once when the request is complete,
> the 'size' argument is now redundant. Remove it.
>
> Now there is no need for bio_endio to subtract the size completed
> from bi_size. So don't do that either.
>
> While we are at it, change bi_end_io to return void.
Looks correct to me.
Acked-by: Jens Axboe <jens.axboe@oracle.com>
--
Jens Axboe
next prev parent reply other threads:[~2007-10-13 10:10 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20071011213126.cf92efb7.akpm@linux-foundation.org>
2007-10-12 20:38 ` 2.6.23-mm1 Laurent Riffard
2007-10-12 21:00 ` 2.6.23-mm1 Andrew Morton
2007-10-13 9:29 ` [PATCH] Reiser4: Drop 'size' argument from bio_endio and bi_end_io Laurent Riffard
2007-10-13 10:10 ` Jens Axboe [this message]
2007-10-14 13:09 ` Edward Shishkin
2007-10-15 16:13 ` 2.6.23-mm1 Zan Lynx
2007-10-14 22:34 ` 2.6.23-mm1: BUG in reiserfs_delete_xattrs Laurent Riffard
2007-10-15 8:40 ` Christoph Hellwig
2007-10-15 18:31 ` Jeff Mahoney
2007-10-15 19:51 ` Laurent Riffard
[not found] ` <4713B1E7.2010504@suse.com>
2007-10-15 20:06 ` Laurent Riffard
2007-10-15 20:23 ` Jeff Mahoney
2007-10-17 8:59 ` Christoph Hellwig
2007-10-17 8:58 ` Christoph Hellwig
2007-10-17 14:55 ` Jeff Mahoney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071013101025.GE969@kernel.dk \
--to=jens.axboe@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=edward@namesys.com \
--cc=laurent.riffard@free.fr \
--cc=linux-kernel@vger.kernel.org \
--cc=neilb@suse.de \
--cc=reiserfs-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).