From: Jan Kara <jack@suse.cz>
To: Christoph Hellwig <hch@infradead.org>
Cc: Jan Kara <jack@suse.cz>,
Andrew Morton <akpm@linux-foundation.org>,
reiserfs-devel@vger.kernel.org, jeffm@suse.com,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] reiserfs: Truncate blocks not used by a write
Date: Tue, 1 Sep 2009 20:10:27 +0200 [thread overview]
Message-ID: <20090901181027.GF8242@duck.novell.com> (raw)
In-Reply-To: <20090901174255.GA9051@infradead.org>
On Tue 01-09-09 13:42:56, Christoph Hellwig wrote:
> On Tue, Sep 01, 2009 at 05:55:54PM +0200, Jan Kara wrote:
> > It can happen that write does not use all the blocks allocated in write_begin
> > either because of some filesystem error (like ENOSPC) or because page with
> > data to write has been removed from memory. We truncate these blocks so that
> > we don't have dangling blocks beyond i_size.
>
> vmtruncate is in the process of going away for 2.6.32. Please use a
> filesystems-specific routine to just trim the blocks, similar to what
> the vmtruncate call in the generic write_begin helper is beeing replaced
> with in Nick's truncate patch series.
Reiserfs does not have such helper (yet), that's why I've used
vmtruncate. But OK, I'll try to convert reiserfs to the new truncate
sequence and then make this fix use it...
Honza
--
Jan Kara <jack@suse.cz>
SUSE Labs, CR
prev parent reply other threads:[~2009-09-01 18:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-01 15:55 [PATCH] reiserfs: Truncate blocks not used by a write Jan Kara
2009-09-01 17:42 ` Christoph Hellwig
2009-09-01 18:10 ` Jan Kara [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090901181027.GF8242@duck.novell.com \
--to=jack@suse.cz \
--cc=akpm@linux-foundation.org \
--cc=hch@infradead.org \
--cc=jeffm@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=reiserfs-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).