From: Andrew Morton <akpm@linux-foundation.org>
To: Al Viro <viro@ZenIV.linux.org.uk>
Cc: Artem Bityutskiy <dedekind1@gmail.com>,
LKML <linux-kernel@vger.kernel.org>,
Jens Axboe <jens.axboe@oracle.com>,
linux-fsdevel@vger.kernel.org,
Roman Zippel <zippel@linux-m68k.org>,
"Tigran A. Aivazian" <tigran@aivazian.fsnet.co.uk>,
Chris Mason <chris.mason@oracle.com>,
Boaz Harrosh <bharrosh@panasas.com>,
linux-ext4@vger.kernel.org, Theodore Ts'o <tytso@mit.edu>,
OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>,
David Woodhouse <dwmw2@infradead.org>,
reiserfs-devel@vger.kernel.org, Jan Kara <jack@suse.cz>,
Evgeniy Dushistov <dushistov@mail.ru>
Subject: Re: [PATCHv4 01/17] VFS: introduce helpers for the s_dirty flag
Date: Fri, 28 May 2010 14:17:55 -0700 [thread overview]
Message-ID: <20100528141755.42958d81.akpm@linux-foundation.org> (raw)
In-Reply-To: <20100528211432.GM31073@ZenIV.linux.org.uk>
On Fri, 28 May 2010 22:14:32 +0100
Al Viro <viro@ZenIV.linux.org.uk> wrote:
> On Fri, May 28, 2010 at 01:23:18PM -0700, Andrew Morton wrote:
>
> > A more conventional and superior naming scheme is
> > subsystemid_specific_function_identifier(). eg, bio_add_page() instead
> > of add_page_to_bio().
> >
> > So these want to be sb_mark_dirty(), etc.
> >
> > Being very old code written by very yound people, the VFS kinda ignores
> > that convention, but it doesn't hurt to use it for new code.
> >
> > Feel free to ignore me if that's too much of a PITA ;)
>
> The real issue is that it's almost certainly an overdesign. Let's
> get rid of the bogus uses first and figure out what's happening in
> what remains, OK?
That would be good.
> I have no problems with doing such wrappers, but if we touch every
> place using ->s_dirt anyway, let's at least take a good look at them.
When adding wrappers we should also rename ->s_dirt (say, to __s_dirt)
to catch out any unconverted code.
next prev parent reply other threads:[~2010-05-28 21:17 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1274795352-3551-1-git-send-email-dedekind1@gmail.com>
2010-05-25 13:48 ` [PATCHv4 01/17] VFS: introduce helpers for the s_dirty flag Artem Bityutskiy
2010-05-28 20:23 ` Andrew Morton
2010-05-28 21:14 ` Al Viro
2010-05-28 21:17 ` Andrew Morton [this message]
2010-05-29 8:11 ` Artem Bityutskiy
2010-06-09 15:44 ` tytso
2010-06-09 15:49 ` Artem Bityutskiy
2010-06-09 16:31 ` Andrew Morton
2010-06-09 22:33 ` Al Viro
2010-05-29 7:59 ` Artem Bityutskiy
2010-05-25 13:49 ` [PATCHv4 12/17] reiserfs: do not manipulate s_dirt directly Artem Bityutskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100528141755.42958d81.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=bharrosh@panasas.com \
--cc=chris.mason@oracle.com \
--cc=dedekind1@gmail.com \
--cc=dushistov@mail.ru \
--cc=dwmw2@infradead.org \
--cc=hirofumi@mail.parknet.co.jp \
--cc=jack@suse.cz \
--cc=jens.axboe@oracle.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=reiserfs-devel@vger.kernel.org \
--cc=tigran@aivazian.fsnet.co.uk \
--cc=tytso@mit.edu \
--cc=viro@ZenIV.linux.org.uk \
--cc=zippel@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).