From mboxrd@z Thu Jan  1 00:00:00 1970
From: Frederic Weisbecker <fweisbec@gmail.com>
Subject: Re: reiserfs locking (v2)
Date: Sat, 10 Jul 2010 15:57:39 +0200
Message-ID: <20100710135735.GC5306@nowhere>
References: <20100702093451.GA3973@swordfish.minsk.epam.com> <20100702131248.GA5324@nowhere> <20100703092441.GM31073@ZenIV.linux.org.uk> <20100703094323.GN31073@ZenIV.linux.org.uk> <20100704091523.GP31073@ZenIV.linux.org.uk> <20100709031622.GL6405@nowhere> <20100709104047.GA3965@swordfish.minsk.epam.com>
Mime-Version: 1.0
Return-path: <reiserfs-devel-owner@vger.kernel.org>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=gamma;
        h=domainkey-signature:received:received:received:date:from:to:cc
         :subject:message-id:references:mime-version:content-type
         :content-disposition:in-reply-to:user-agent;
        bh=baqb0DWUqO37fcbOXgtwi9Trw8i6n+a83+onEePYKic=;
        b=KZGVS1ahkhCyu4XQtAybB5dytksBf4S4g5y8EMqImIIS7YH5oVa1DLh8oB3tLCtxkb
         O1lXIlpEk4R6MpiXeL9IvEru/5hfCgcfyT8XxQ6T0jIEs+JxhHAdAr0JMx3saZyS6LYR
         6UfWkoaqICpKy7vuFToyw844JYIqS0ELRk6jg=
Content-Disposition: inline
In-Reply-To: <20100709104047.GA3965@swordfish.minsk.epam.com>
Sender: reiserfs-devel-owner@vger.kernel.org
List-ID: <reiserfs-devel.vger.kernel.org>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
Cc: Al Viro <viro@ZenIV.linux.org.uk>, Jan Kara <jack@suse.cz>, Christoph Hellwig <hch@lst.de>, Andrew Morton <akpm@linux-foundation.org>, reiserfs-devel@vger.kernel.org, linux-kernel@vger.kernel.org, Chris Mason <chris.mason@oracle.com>, Jeff Mahoney <jeffm@jeffreymahoney.com>

On Fri, Jul 09, 2010 at 01:42:06PM +0300, Sergey Senozhatsky wrote:
> On (07/09/10 05:16), Frederic Weisbecker wrote:
> > On Sun, Jul 04, 2010 at 10:15:23AM +0100, Al Viro wrote:
> > > On Sat, Jul 03, 2010 at 10:43:23AM +0100, Al Viro wrote:
> > > > On Sat, Jul 03, 2010 at 10:24:42AM +0100, Al Viro wrote:
> > > > 
> > > > > Gyah...  For the 1001st time: readdir() is far from being the only thing that
> > > > > nests mmap_sem inside i_mutex.  In particular, write() does the same thing.
> > > > > 
> > > > > So yes, it *is* a real deadlock, TYVM, with no directories involved.  Open the
> > > > > same file twice, mmap one fd, close it, then have munmap() hitting i_mutex
> > > > > in reiserfs_file_release() race with write() through another fd.
> > > > > 
> > > > > Incidentally, reiserfs_file_release() checks in the fastpath look completely
> > > > > bogus.  Checking i_count?  What the hell is that one about?  And no, these
> > > > > checks won't stop open() coming between them and grabbing i_mutex, so they
> > > > > couldn't prevent the deadlock in question anyway.
> > > > 
> > > > ... and unfortunately it's been that way since the the initial merge in 2.4.early.
> > > > FWIW, it seems that i_count check was a misguided attempt to check that no other
> > > > opened struct file are there, but it's
> > > > 	a) wrong, since way, _way_ back - open() affects d_count, not i_count
> > > > 	b) wrong even with such modification (consider hardlinks)
> > > > 	c) wrong for even more reasons since forever - i_count and d_count could
> > > > be bumped by many things at any time
> > > > 	d) hopelessly racy anyway, since another open() could very well have
> > > > happened just as we'd finished these checks.
> > > 
> > > OK...  See 22093b8f3d387f77 in vfs-2.6.git for-next (should propagate to
> > > git.kernel.org shortly).  That ought to deal with this crap, assuming I hadn't
> > > fucked up somewhere...
> > 
> > 
> > Looks good. Thanks for fixing this!
> > 
> 
> Seems to work fine with my test app.
> 
> Reported-by/Tested-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>


Great!