From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jarek Poplawski Subject: Re: [Bug] possible circular locking in reiserfs_unpack Date: Thu, 9 Sep 2010 06:07:26 +0000 Message-ID: <20100909060726.GA6171@ff.dom.local> References: <20100905113121.GA1876@del.dom.local> <20100908153730.5ad13f71.akpm@linux-foundation.org> <20100909015346.GA5999@nowhere> Mime-Version: 1.0 Return-path: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:date:from:to:cc:subject :message-id:references:mime-version:content-type:content-disposition :in-reply-to:user-agent; bh=7VftwXKK7L74AcOckPWQT6cTvV1BBGc0p9NN0z5x66Q=; b=RbnYqooWWXdRN4DuHtURixI27FL3OpnN0dudKQMW5LnD4RY1CVEZVaGgZS47Ba0W7N o2YxNe7Ewc2gGqw++b2bLcJ/3O2HPMGmxvZtm+mg2Rl8RgCYp/lvCK38immuG+log0lp rRiepTCZ+dF5fk9w9Jv8V6lRjgm+dIN5+f0sA= Content-Disposition: inline In-Reply-To: <20100909015346.GA5999@nowhere> Sender: reiserfs-devel-owner@vger.kernel.org List-ID: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Frederic Weisbecker Cc: Andrew Morton , linux-kernel@vger.kernel.org, reiserfs-devel@vger.kernel.org, Christoph Hellwig , Al Viro On Thu, Sep 09, 2010 at 03:53:52AM +0200, Frederic Weisbecker wrote: > On Wed, Sep 08, 2010 at 03:37:30PM -0700, Andrew Morton wrote: > > On Sun, 5 Sep 2010 13:31:21 +0200 > > Jarek Poplawski wrote: > > > > > Hi, > > > I get this warning on every lilo write with 2.6.35.4 and a bit/git > > > later too. > > > > > > > Can you tell us the latest kernel version which did *not* have this > > bug? That way we can narrow the problem down a bit. I'll try if Frederic's patch doesn't help. But, generally, it seems with this kind of (not too long) lockdep info it should be much faster to have a look of somebody with a basic reiserfs locking knowledge.;-) > > > > Thanks. > > > > Ah, when you see &REISERFS_SB(s)->lock in a bug report, don't hesitate to blame me :-) > > This is a problem resulting from the bkl conversion to a mutex that introduced > a lot of new locking dependencies. Most of them have been fixed, but for less > tested paths like ioctl, we hear about it later. > > Does the following patch fixes the issue? > If so, I'll make a proper changelog and put the appropriate 2.6.33-35 stable > tags for the backport. I should be able to test it when back home (within 9 hours). Thanks, Jarek P. > > Thnaks! > > > diff --git a/fs/reiserfs/ioctl.c b/fs/reiserfs/ioctl.c > index f53505d..679d502 100644 > --- a/fs/reiserfs/ioctl.c > +++ b/fs/reiserfs/ioctl.c > @@ -188,7 +188,7 @@ int reiserfs_unpack(struct inode *inode, struct file *filp) > /* we need to make sure nobody is changing the file size beneath > ** us > */ > - mutex_lock(&inode->i_mutex); > + reiserfs_mutex_lock_safe(&inode->i_mutex, inode->i_sb); > reiserfs_write_lock(inode->i_sb); > > write_from = inode->i_size & (blocksize - 1); >