From: Jan Kara <jack@suse.cz>
To: Sachin Kamat <sachin.kamat@linaro.org>
Cc: reiserfs-devel@vger.kernel.org, jack@suse.cz,
viro@zeniv.linux.org.uk, patches@linaro.org
Subject: Re: [PATCH] fs: reiserfs/xattr.c: Make reiserfs_xattr_handlers static
Date: Thu, 23 Aug 2012 17:24:06 +0200 [thread overview]
Message-ID: <20120823152406.GA24985@quack.suse.cz> (raw)
In-Reply-To: <CAK9yfHxctU7NqrW9HZh55=1ehxiWHDC243XrG0kT_UX05AdS9w@mail.gmail.com>
On Thu 23-08-12 20:08:55, Sachin Kamat wrote:
> Hi Jan,
>
> Please pick this patch if it looks ok.
The patch looks OK. I see that Al didn't pick it up in his tree yet so
I'll take the patch to my tree and push it in the next merge window.
Honza
>
> On 2 August 2012 15:39, Sachin Kamat <sachin.kamat@linaro.org> wrote:
> > Silences the following sparse warning:
> > fs/reiserfs/xattr.c:899:28: warning:
> > symbol 'reiserfs_xattr_handlers' was not declared. Should it be static?
> >
> > Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> > ---
> > fs/reiserfs/xattr.c | 2 +-
> > 1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/fs/reiserfs/xattr.c b/fs/reiserfs/xattr.c
> > index d319963..c196369 100644
> > --- a/fs/reiserfs/xattr.c
> > +++ b/fs/reiserfs/xattr.c
> > @@ -896,7 +896,7 @@ static int create_privroot(struct dentry *dentry) { return 0; }
> > #endif
> >
> > /* Actual operations that are exported to VFS-land */
> > -const struct xattr_handler *reiserfs_xattr_handlers[] = {
> > +static const struct xattr_handler *reiserfs_xattr_handlers[] = {
> > #ifdef CONFIG_REISERFS_FS_XATTR
> > &reiserfs_xattr_user_handler,
> > &reiserfs_xattr_trusted_handler,
> > --
> > 1.7.4.1
> >
>
>
>
> --
> With warm regards,
> Sachin
prev parent reply other threads:[~2012-08-23 15:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-02 10:09 [PATCH] fs: reiserfs/xattr.c: Make reiserfs_xattr_handlers static Sachin Kamat
2012-08-13 16:16 ` Sachin Kamat
2012-08-23 14:38 ` Sachin Kamat
2012-08-23 15:24 ` Jan Kara [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120823152406.GA24985@quack.suse.cz \
--to=jack@suse.cz \
--cc=patches@linaro.org \
--cc=reiserfs-devel@vger.kernel.org \
--cc=sachin.kamat@linaro.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).