* [PATCH] fs: reiserfs/xattr.c: Make reiserfs_xattr_handlers static
@ 2012-08-02 10:09 Sachin Kamat
2012-08-13 16:16 ` Sachin Kamat
2012-08-23 14:38 ` Sachin Kamat
0 siblings, 2 replies; 4+ messages in thread
From: Sachin Kamat @ 2012-08-02 10:09 UTC (permalink / raw)
To: reiserfs-devel; +Cc: viro, sachin.kamat, patches
Silences the following sparse warning:
fs/reiserfs/xattr.c:899:28: warning:
symbol 'reiserfs_xattr_handlers' was not declared. Should it be static?
Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
---
fs/reiserfs/xattr.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/fs/reiserfs/xattr.c b/fs/reiserfs/xattr.c
index d319963..c196369 100644
--- a/fs/reiserfs/xattr.c
+++ b/fs/reiserfs/xattr.c
@@ -896,7 +896,7 @@ static int create_privroot(struct dentry *dentry) { return 0; }
#endif
/* Actual operations that are exported to VFS-land */
-const struct xattr_handler *reiserfs_xattr_handlers[] = {
+static const struct xattr_handler *reiserfs_xattr_handlers[] = {
#ifdef CONFIG_REISERFS_FS_XATTR
&reiserfs_xattr_user_handler,
&reiserfs_xattr_trusted_handler,
--
1.7.4.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] fs: reiserfs/xattr.c: Make reiserfs_xattr_handlers static
2012-08-02 10:09 [PATCH] fs: reiserfs/xattr.c: Make reiserfs_xattr_handlers static Sachin Kamat
@ 2012-08-13 16:16 ` Sachin Kamat
2012-08-23 14:38 ` Sachin Kamat
1 sibling, 0 replies; 4+ messages in thread
From: Sachin Kamat @ 2012-08-13 16:16 UTC (permalink / raw)
To: reiserfs-devel; +Cc: viro, sachin.kamat, patches
ping...
On 2 August 2012 15:39, Sachin Kamat <sachin.kamat@linaro.org> wrote:
> Silences the following sparse warning:
> fs/reiserfs/xattr.c:899:28: warning:
> symbol 'reiserfs_xattr_handlers' was not declared. Should it be static?
>
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> ---
> fs/reiserfs/xattr.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/fs/reiserfs/xattr.c b/fs/reiserfs/xattr.c
> index d319963..c196369 100644
> --- a/fs/reiserfs/xattr.c
> +++ b/fs/reiserfs/xattr.c
> @@ -896,7 +896,7 @@ static int create_privroot(struct dentry *dentry) { return 0; }
> #endif
>
> /* Actual operations that are exported to VFS-land */
> -const struct xattr_handler *reiserfs_xattr_handlers[] = {
> +static const struct xattr_handler *reiserfs_xattr_handlers[] = {
> #ifdef CONFIG_REISERFS_FS_XATTR
> &reiserfs_xattr_user_handler,
> &reiserfs_xattr_trusted_handler,
> --
> 1.7.4.1
>
--
With warm regards,
Sachin
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] fs: reiserfs/xattr.c: Make reiserfs_xattr_handlers static
2012-08-02 10:09 [PATCH] fs: reiserfs/xattr.c: Make reiserfs_xattr_handlers static Sachin Kamat
2012-08-13 16:16 ` Sachin Kamat
@ 2012-08-23 14:38 ` Sachin Kamat
2012-08-23 15:24 ` Jan Kara
1 sibling, 1 reply; 4+ messages in thread
From: Sachin Kamat @ 2012-08-23 14:38 UTC (permalink / raw)
To: reiserfs-devel, jack; +Cc: viro, sachin.kamat, patches
Hi Jan,
Please pick this patch if it looks ok.
On 2 August 2012 15:39, Sachin Kamat <sachin.kamat@linaro.org> wrote:
> Silences the following sparse warning:
> fs/reiserfs/xattr.c:899:28: warning:
> symbol 'reiserfs_xattr_handlers' was not declared. Should it be static?
>
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> ---
> fs/reiserfs/xattr.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/fs/reiserfs/xattr.c b/fs/reiserfs/xattr.c
> index d319963..c196369 100644
> --- a/fs/reiserfs/xattr.c
> +++ b/fs/reiserfs/xattr.c
> @@ -896,7 +896,7 @@ static int create_privroot(struct dentry *dentry) { return 0; }
> #endif
>
> /* Actual operations that are exported to VFS-land */
> -const struct xattr_handler *reiserfs_xattr_handlers[] = {
> +static const struct xattr_handler *reiserfs_xattr_handlers[] = {
> #ifdef CONFIG_REISERFS_FS_XATTR
> &reiserfs_xattr_user_handler,
> &reiserfs_xattr_trusted_handler,
> --
> 1.7.4.1
>
--
With warm regards,
Sachin
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] fs: reiserfs/xattr.c: Make reiserfs_xattr_handlers static
2012-08-23 14:38 ` Sachin Kamat
@ 2012-08-23 15:24 ` Jan Kara
0 siblings, 0 replies; 4+ messages in thread
From: Jan Kara @ 2012-08-23 15:24 UTC (permalink / raw)
To: Sachin Kamat; +Cc: reiserfs-devel, jack, viro, patches
On Thu 23-08-12 20:08:55, Sachin Kamat wrote:
> Hi Jan,
>
> Please pick this patch if it looks ok.
The patch looks OK. I see that Al didn't pick it up in his tree yet so
I'll take the patch to my tree and push it in the next merge window.
Honza
>
> On 2 August 2012 15:39, Sachin Kamat <sachin.kamat@linaro.org> wrote:
> > Silences the following sparse warning:
> > fs/reiserfs/xattr.c:899:28: warning:
> > symbol 'reiserfs_xattr_handlers' was not declared. Should it be static?
> >
> > Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> > ---
> > fs/reiserfs/xattr.c | 2 +-
> > 1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/fs/reiserfs/xattr.c b/fs/reiserfs/xattr.c
> > index d319963..c196369 100644
> > --- a/fs/reiserfs/xattr.c
> > +++ b/fs/reiserfs/xattr.c
> > @@ -896,7 +896,7 @@ static int create_privroot(struct dentry *dentry) { return 0; }
> > #endif
> >
> > /* Actual operations that are exported to VFS-land */
> > -const struct xattr_handler *reiserfs_xattr_handlers[] = {
> > +static const struct xattr_handler *reiserfs_xattr_handlers[] = {
> > #ifdef CONFIG_REISERFS_FS_XATTR
> > &reiserfs_xattr_user_handler,
> > &reiserfs_xattr_trusted_handler,
> > --
> > 1.7.4.1
> >
>
>
>
> --
> With warm regards,
> Sachin
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2012-08-23 15:24 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-08-02 10:09 [PATCH] fs: reiserfs/xattr.c: Make reiserfs_xattr_handlers static Sachin Kamat
2012-08-13 16:16 ` Sachin Kamat
2012-08-23 14:38 ` Sachin Kamat
2012-08-23 15:24 ` Jan Kara
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).