From: Chris Mason <clmason@fusionio.com>
To: Jeff Mahoney <jeffm@suse.com>,
reiserfs-devel <reiserfs-devel@vger.kernel.org>
Subject: Re: [BULK] [PATCH] reiserfs: fix journal list handling
Date: Mon, 6 May 2013 14:57:48 -0400 [thread overview]
Message-ID: <20130506185748.5844.59533@localhost.localdomain> (raw)
In-Reply-To: <5187FB79.4000206@suse.com>
Quoting Jeff Mahoney (2013-05-06 14:50:33)
> reiserfs has open coded linked lists to handle its cnode infrastructure.
>
> While converting them to list_heads, I found that while the patch looked
> perfectly straightforward based on what the code should have been doing,
> it caused crashes nearly immediately. The issue can be reproduced
> without the conversion by clearing the hprev/hnext pointers in
> remove_journal_hash() when the cnode is removed from the hash list.
>
> It turns out that the code has been working by happy accident for over
> a decade
Chris from 1999 is really sorry about that one. The new code looks much
less error prone.
-chris
next prev parent reply other threads:[~2013-05-06 18:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-06 18:50 [PATCH] reiserfs: fix journal list handling Jeff Mahoney
2013-05-06 18:57 ` Chris Mason [this message]
2013-05-14 13:37 ` Jeff Mahoney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130506185748.5844.59533@localhost.localdomain \
--to=clmason@fusionio.com \
--cc=jeffm@suse.com \
--cc=reiserfs-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).