From: Jan Kara <jack@suse.cz>
To: Jeff Mahoney <jeffm@suse.com>
Cc: reiserfs-devel@vger.kernel.org, jack@suse.cz
Subject: Re: [patch v4 0/3] reiserfs locking patchset v4
Date: Fri, 9 Aug 2013 23:31:27 +0200 [thread overview]
Message-ID: <20130809213127.GA4100@quack.suse.cz> (raw)
In-Reply-To: <20130808213606.396768830@suse.com>
On Thu 08-08-13 17:36:06, Jeff Mahoney wrote:
> This patchset untangles some of the locking in reiserfs. It has seen more
> testing as part of the maintenance cycle in SLE 11 SP2.
>
> - We push the write lock out of the xattr code. It doesn't need it and
> we can simplify locking by releasing and reacquiring the locks around
> the xattr calls.
>
> - Handle nested locks properly. There's confusion on when a lock is nested,
> when it's not, and how to drop it across schedules like the BKL it is
> modeled after. We make the distinction between taking/releasing the lock
> and when to drop it for schedules and simplify the logic. This fixes
> a number of deadlocks that happen because the intention was to drop
> the write lock but it really only decremented the use count.
>
> - Fix the deadlocks with the quota code. This involves dropping the write
> lock before quota calls and reacquring it afterwards. Without this patch
> reiserfs quotas are essentially unusable.
>
> Previous postings of this patchset were mismerged.
>
> This revision integrates Jan's advice about search_by_key_reada returning
> the depth instead of a bool.
>
> Jan - This series is in the for-3.12 branch of
> git.kernel.org:/pub/scm/linux/kernel/git/jeffm/linux-reiserfs.git
Thanks! I've pulled this series to my tree.
Honza
--
Jan Kara <jack@suse.cz>
SUSE Labs, CR
prev parent reply other threads:[~2013-08-09 21:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-08 21:36 [patch v4 0/3] reiserfs locking patchset v4 Jeff Mahoney
2013-08-08 21:36 ` [patch v4 1/3] reiserfs: locking, push write lock out of xattr code Jeff Mahoney
2013-08-08 21:36 ` [patch v4 2/3] reiserfs: locking, handle nested locks properly Jeff Mahoney
2013-08-08 21:36 ` [patch v4 3/3] reiserfs: locking, release lock around quota operations Jeff Mahoney
2013-08-09 21:31 ` Jan Kara [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130809213127.GA4100@quack.suse.cz \
--to=jack@suse.cz \
--cc=jeffm@suse.com \
--cc=reiserfs-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).