From: Josh Triplett <josh@joshtriplett.org>
To: Sanidhya Kashyap <sanidhya.gatech@gmail.com>
Cc: reiserfs-devel@vger.kernel.org, linux-kernel@vger.kernel.org,
"Kashyap, Sanidhya" <sanidhya@gatech.edu>
Subject: Re: [PATCH] reiserfs: kstrdup() memory handling
Date: Sun, 22 Mar 2015 19:55:43 -0700 [thread overview]
Message-ID: <20150323025543.GA2120@thin> (raw)
In-Reply-To: <CADa969h6MLbM3vporSjkctBxQwsqphghbXQxAhtyBUeUuqrWQA@mail.gmail.com>
On Sun, Mar 22, 2015 at 08:12:46PM -0400, Sanidhya Kashyap wrote:
> On Sat, Mar 21, 2015 at 1:15 PM, Josh Triplett <josh@joshtriplett.org> wrote:
> > On Sat, Mar 21, 2015 at 01:00:13PM -0400, Sanidhya Kashyap wrote:
> >> Checking for ENOMEM even for new_opts in reiserfs_remount function as
> >> there is a possibility of nothing being allocated.
> >
> > You don't need to add a new label; kfree(NULL) is a no-op.
> >
>
> Shall I resubmit the patch?
I would suggest doing so, yes, after you see if anyone else has feedback
on it.
- Josh Triplett
prev parent reply other threads:[~2015-03-23 2:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-21 17:00 [PATCH] reiserfs: kstrdup() memory handling Sanidhya Kashyap
2015-03-21 17:15 ` Josh Triplett
2015-03-23 0:12 ` Sanidhya Kashyap
2015-03-23 2:55 ` Josh Triplett [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150323025543.GA2120@thin \
--to=josh@joshtriplett.org \
--cc=linux-kernel@vger.kernel.org \
--cc=reiserfs-devel@vger.kernel.org \
--cc=sanidhya.gatech@gmail.com \
--cc=sanidhya@gatech.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).