From: Jan Kara <jack@suse.cz>
To: Jeff Layton <jlayton@kernel.org>
Cc: reiserfs-devel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] reiserfs: remove unneeded i_version bump
Date: Wed, 15 Nov 2017 14:25:27 +0100 [thread overview]
Message-ID: <20171115132527.GA13707@quack2.suse.cz> (raw)
In-Reply-To: <20171030152015.9444-1-jlayton@kernel.org>
On Mon 30-10-17 11:20:15, Jeff Layton wrote:
> From: Jeff Layton <jlayton@redhat.com>
>
> The i_version field in reiserfs is not initialized and is only ever
> updated here. Nothing ever views it, so just remove it.
>
> Signed-off-by: Jeff Layton <jlayton@redhat.com>
Thanks! I've added this patch to my tree.
Honza
> ---
> fs/reiserfs/super.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/fs/reiserfs/super.c b/fs/reiserfs/super.c
> index 5464ec517702..4885c7b6e44f 100644
> --- a/fs/reiserfs/super.c
> +++ b/fs/reiserfs/super.c
> @@ -2591,7 +2591,6 @@ static ssize_t reiserfs_quota_write(struct super_block *sb, int type,
> return err;
> if (inode->i_size < off + len - towrite)
> i_size_write(inode, off + len - towrite);
> - inode->i_version++;
> inode->i_mtime = inode->i_ctime = current_time(inode);
> mark_inode_dirty(inode);
> return len - towrite;
> --
> 2.13.6
>
--
Jan Kara <jack@suse.com>
SUSE Labs, CR
prev parent reply other threads:[~2017-11-15 13:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-30 15:20 [PATCH] reiserfs: remove unneeded i_version bump Jeff Layton
2017-11-15 13:25 ` Jan Kara [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171115132527.GA13707@quack2.suse.cz \
--to=jack@suse.cz \
--cc=jlayton@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=reiserfs-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).