* [PATCH] reiserfs: remove unneeded i_version bump
@ 2017-10-30 15:20 Jeff Layton
2017-11-15 13:25 ` Jan Kara
0 siblings, 1 reply; 2+ messages in thread
From: Jeff Layton @ 2017-10-30 15:20 UTC (permalink / raw)
To: reiserfs-devel; +Cc: linux-fsdevel, linux-kernel
From: Jeff Layton <jlayton@redhat.com>
The i_version field in reiserfs is not initialized and is only ever
updated here. Nothing ever views it, so just remove it.
Signed-off-by: Jeff Layton <jlayton@redhat.com>
---
fs/reiserfs/super.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/fs/reiserfs/super.c b/fs/reiserfs/super.c
index 5464ec517702..4885c7b6e44f 100644
--- a/fs/reiserfs/super.c
+++ b/fs/reiserfs/super.c
@@ -2591,7 +2591,6 @@ static ssize_t reiserfs_quota_write(struct super_block *sb, int type,
return err;
if (inode->i_size < off + len - towrite)
i_size_write(inode, off + len - towrite);
- inode->i_version++;
inode->i_mtime = inode->i_ctime = current_time(inode);
mark_inode_dirty(inode);
return len - towrite;
--
2.13.6
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] reiserfs: remove unneeded i_version bump
2017-10-30 15:20 [PATCH] reiserfs: remove unneeded i_version bump Jeff Layton
@ 2017-11-15 13:25 ` Jan Kara
0 siblings, 0 replies; 2+ messages in thread
From: Jan Kara @ 2017-11-15 13:25 UTC (permalink / raw)
To: Jeff Layton; +Cc: reiserfs-devel, linux-fsdevel, linux-kernel
On Mon 30-10-17 11:20:15, Jeff Layton wrote:
> From: Jeff Layton <jlayton@redhat.com>
>
> The i_version field in reiserfs is not initialized and is only ever
> updated here. Nothing ever views it, so just remove it.
>
> Signed-off-by: Jeff Layton <jlayton@redhat.com>
Thanks! I've added this patch to my tree.
Honza
> ---
> fs/reiserfs/super.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/fs/reiserfs/super.c b/fs/reiserfs/super.c
> index 5464ec517702..4885c7b6e44f 100644
> --- a/fs/reiserfs/super.c
> +++ b/fs/reiserfs/super.c
> @@ -2591,7 +2591,6 @@ static ssize_t reiserfs_quota_write(struct super_block *sb, int type,
> return err;
> if (inode->i_size < off + len - towrite)
> i_size_write(inode, off + len - towrite);
> - inode->i_version++;
> inode->i_mtime = inode->i_ctime = current_time(inode);
> mark_inode_dirty(inode);
> return len - towrite;
> --
> 2.13.6
>
--
Jan Kara <jack@suse.com>
SUSE Labs, CR
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-11-15 13:25 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-10-30 15:20 [PATCH] reiserfs: remove unneeded i_version bump Jeff Layton
2017-11-15 13:25 ` Jan Kara
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).