Re: [PATCH v5] Add flags option to get xattr method paired to __vfs_getxattr

From: kbuild test robot <lkp@intel.com>
To: Mark Salyzyn <salyzyn@android.com>
Cc: Latchesar Ionkov <lucho@ionkov.net>,
	Hugh Dickins <hughd@google.com>,
	Mike Marshall <hubcap@omnibond.com>,
	James Morris <jmorris@namei.org>,
	devel@lists.orangefs.org, Eric Van Hensbergen <ericvh@gmail.com>,
	Joel Becker <jlbec@evilplan.org>,
	Anna Schumaker <anna.schumaker@netapp.com>,
	Trond Myklebust <trond.myklebust@hammerspace.com>,
	Mathieu Malaterre <malat@debian.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-kernel@vger.kernel.org, kbuild-all@01.org,
	Jan Kara <jack@suse.com>,
	Casey Schaufler <casey@schaufler-ca.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Dave Kleikamp <shaggy@kernel.org>,
	linux-doc@vger.kernel.org, Jeff Layton <jlayton@kernel.org>,
	Chao Yu <yuchao0@huawei.com>, Mimi Zohar <zohar@linux.ibm.com>,
	linux-cifs@vger.kernel.org, Paul Moore <paul@paul-moore.com>,
	"Darrick J. Wong" <darrick.wong@oracle.com>,
	Eric Sandeen <sandeen@sandeen.ne>
Subject: Re: [PATCH v5] Add flags option to get xattr method paired to __vfs_getxattr
Date: Tue, 20 Aug 2019 23:12:03 +0800	[thread overview]
Message-ID: <201908202356.Jnt6ivbB%lkp@intel.com> (raw)
In-Reply-To: <20190819183305.153583-1-salyzyn@android.com>

[-- Attachment #1: Type: text/plain, Size: 2248 bytes --]

Hi Mark,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on linus/master]
[cannot apply to v5.3-rc5 next-20190820]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Mark-Salyzyn/Add-flags-option-to-get-xattr-method-paired-to-__vfs_getxattr/20190820-220307
config: um-x86_64_defconfig (attached as .config)
compiler: gcc-7 (Debian 7.4.0-10) 7.4.0
reproduce:
        # save the attached .config to linux build tree
        make ARCH=um SUBARCH=x86_64

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   fs//kernfs/inode.c: In function 'kernfs_vfs_xattr_set':
>> fs//kernfs/inode.c:322:27: error: 'inode' undeclared (first use in this function)
     struct kernfs_node *kn = inode->i_private;
                              ^~~~~
   fs//kernfs/inode.c:322:27: note: each undeclared identifier is reported only once for each function it appears in

vim +/inode +322 fs//kernfs/inode.c

b230d5aba2d1a7 Ondrej Mosnacek 2019-02-22  318  
1537ad15c9c59c Ondrej Mosnacek 2019-04-03  319  static int kernfs_vfs_xattr_set(const struct xattr_handler *handler,
7d823b0879d4e2 Mark Salyzyn    2019-08-19  320  				struct xattr_gs_args *args)
b230d5aba2d1a7 Ondrej Mosnacek 2019-02-22  321  {
b230d5aba2d1a7 Ondrej Mosnacek 2019-02-22 @322  	struct kernfs_node *kn = inode->i_private;
b230d5aba2d1a7 Ondrej Mosnacek 2019-02-22  323  
7d823b0879d4e2 Mark Salyzyn    2019-08-19  324  	return kernfs_xattr_set(kn, xattr_full_name(handler, args->name),
7d823b0879d4e2 Mark Salyzyn    2019-08-19  325  				args->value, args->size, args->flags);
b230d5aba2d1a7 Ondrej Mosnacek 2019-02-22  326  }
b230d5aba2d1a7 Ondrej Mosnacek 2019-02-22  327  

:::::: The code at line 322 was first introduced by commit
:::::: b230d5aba2d1a7b0636408889a75bf9eae6b8bc7 LSM: add new hook for kernfs node initialization

:::::: TO: Ondrej Mosnacek <omosnace@redhat.com>
:::::: CC: Paul Moore <paul@paul-moore.com>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 8296 bytes --]

[-- Attachment #3: Type: text/plain, Size: 144 bytes --]

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/