From: Liuwenyi <qingshenlwy@gmail.com>
To: viro@zeniv.linux.org.uk, jeffm@suse.com, joel.becker@oracle.com,
jmorris@namei.org, hch@lst.de, reiserfs-devel@vger.kernel.org,
linux-kernel@vger.kernel.org, onlyflyer@gmail.com, stro
Subject: [PATCHv2 11/12]posix_acl: Add the check items
Date: Mon, 21 Dec 2009 20:01:53 +0800 [thread overview]
Message-ID: <4B2F63B1.4080109@gmail.com> (raw)
move the ACL validation check in to fs/posix_acl.c.
Including nullpointer check and PTR_ERR check.
---
Signed-off-by: Liuwenyi <qingshenlwy@gmail.com>
Cc: Al Viro <viro@zeniv.linux.org.uk>
Cc: Jeff Mahoney <jeffm@suse.com>
Cc: Joel Becker <joel.becker@oracle.com>
Cc: James Morris <jmorris@namei.org>
Cc: Christoph Hellwig <hch@lst.de>
Cc: reiserfs-devel@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
---
diff --git a/fs/reiserfs/xattr_acl.c b/fs/reiserfs/xattr_acl.c
index cc32e6a..4cf1f18 100644
--- a/fs/reiserfs/xattr_acl.c
+++ b/fs/reiserfs/xattr_acl.c
@@ -30,13 +30,9 @@ posix_acl_set(struct dentry *dentry, const char
*name, const void *value,
if (value) {
acl = posix_acl_from_xattr(value, size);
- if (IS_ERR(acl)) {
- return PTR_ERR(acl);
- } else if (acl) {
- error = posix_acl_valid(acl);
- if (error)
- goto release_and_out;
- }
+ error = posix_acl_valid(acl);
+ if (error)
+ goto release_and_out;
} else
acl = NULL;
--
Best Regards,
Liuwenyi
reply other threads:[~2009-12-21 12:01 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B2F63B1.4080109@gmail.com \
--to=qingshenlwy@gmail.com \
--cc=hch@lst.de \
--cc=jeffm@suse.com \
--cc=jmorris@namei.org \
--cc=joel.becker@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=onlyflyer@gmail.com \
--cc=reiserfs-devel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).