* [PATCH 8/8 v2]tuners:tuner-simple Fix warning: variable 'tun' set but not used
@ 2010-06-15 5:48 Justin P. Mattock
2010-06-21 12:34 ` Mauro Carvalho Chehab
0 siblings, 1 reply; 3+ messages in thread
From: Justin P. Mattock @ 2010-06-15 5:48 UTC (permalink / raw)
To: reiserfs-devel; +Cc: mchehab, linux-kernel, Justin P. Mattock
Resend due to a whitespace issue I created by mistake.
The below patch fixes a warning message create by gcc 4.6.0
CC [M] drivers/media/common/tuners/tuner-simple.o
drivers/media/common/tuners/tuner-simple.c: In function 'simple_set_tv_freq':
drivers/media/common/tuners/tuner-simple.c:548:20: warning: variable 'tun' set but not used
Signed-off-by: Justin P. Mattock <justinmattock@gmail.com>
Reviewed-By: Mauro Carvalho Chehab <mchehab@redhat.com>
---
drivers/media/common/tuners/tuner-simple.c | 3 ---
1 files changed, 0 insertions(+), 3 deletions(-)
diff --git a/drivers/media/common/tuners/tuner-simple.c b/drivers/media/common/tuners/tuner-simple.c
index 8abbcc5..84900fa 100644
--- a/drivers/media/common/tuners/tuner-simple.c
+++ b/drivers/media/common/tuners/tuner-simple.c
@@ -545,14 +545,11 @@ static int simple_set_tv_freq(struct dvb_frontend *fe,
struct tuner_simple_priv *priv = fe->tuner_priv;
u8 config, cb;
u16 div;
- struct tunertype *tun;
u8 buffer[4];
int rc, IFPCoff, i;
enum param_type desired_type;
struct tuner_params *t_params;
- tun = priv->tun;
-
/* IFPCoff = Video Intermediate Frequency - Vif:
940 =16*58.75 NTSC/J (Japan)
732 =16*45.75 M/N STD
--
1.7.1.rc1.21.gf3bd6
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 8/8 v2]tuners:tuner-simple Fix warning: variable 'tun' set but not used
2010-06-15 5:48 [PATCH 8/8 v2]tuners:tuner-simple Fix warning: variable 'tun' set but not used Justin P. Mattock
@ 2010-06-21 12:34 ` Mauro Carvalho Chehab
2010-06-21 16:14 ` Justin P. Mattock
0 siblings, 1 reply; 3+ messages in thread
From: Mauro Carvalho Chehab @ 2010-06-21 12:34 UTC (permalink / raw)
To: Justin P. Mattock; +Cc: reiserfs-devel, linux-kernel, linux-media
Em Mon, 14 Jun 2010 22:48:34 -0700
"Justin P. Mattock" <justinmattock@gmail.com> escreveu:
> Resend due to a whitespace issue I created by mistake.
> The below patch fixes a warning message create by gcc 4.6.0
It seems OK for me, but you shouldn't be sending it to be applied at reiserfs-devel ML.
Instead, it should be sent to linux-media ML, and applied via my tree.
>
> CC [M] drivers/media/common/tuners/tuner-simple.o
> drivers/media/common/tuners/tuner-simple.c: In function 'simple_set_tv_freq':
> drivers/media/common/tuners/tuner-simple.c:548:20: warning: variable 'tun' set but not used
>
> Signed-off-by: Justin P. Mattock <justinmattock@gmail.com>
> Reviewed-By: Mauro Carvalho Chehab <mchehab@redhat.com>
>
> ---
> drivers/media/common/tuners/tuner-simple.c | 3 ---
> 1 files changed, 0 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/media/common/tuners/tuner-simple.c b/drivers/media/common/tuners/tuner-simple.c
> index 8abbcc5..84900fa 100644
> --- a/drivers/media/common/tuners/tuner-simple.c
> +++ b/drivers/media/common/tuners/tuner-simple.c
> @@ -545,14 +545,11 @@ static int simple_set_tv_freq(struct dvb_frontend *fe,
> struct tuner_simple_priv *priv = fe->tuner_priv;
> u8 config, cb;
> u16 div;
> - struct tunertype *tun;
> u8 buffer[4];
> int rc, IFPCoff, i;
> enum param_type desired_type;
> struct tuner_params *t_params;
>
> - tun = priv->tun;
> -
> /* IFPCoff = Video Intermediate Frequency - Vif:
> 940 =16*58.75 NTSC/J (Japan)
> 732 =16*45.75 M/N STD
--
Cheers,
Mauro
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 8/8 v2]tuners:tuner-simple Fix warning: variable 'tun' set but not used
2010-06-21 12:34 ` Mauro Carvalho Chehab
@ 2010-06-21 16:14 ` Justin P. Mattock
0 siblings, 0 replies; 3+ messages in thread
From: Justin P. Mattock @ 2010-06-21 16:14 UTC (permalink / raw)
To: Mauro Carvalho Chehab; +Cc: reiserfs-devel, linux-kernel, linux-media
On 06/21/2010 05:34 AM, Mauro Carvalho Chehab wrote:
> Em Mon, 14 Jun 2010 22:48:34 -0700
> "Justin P. Mattock"<justinmattock@gmail.com> escreveu:
>
>> Resend due to a whitespace issue I created by mistake.
>> The below patch fixes a warning message create by gcc 4.6.0
>
> It seems OK for me, but you shouldn't be sending it to be applied at reiserfs-devel ML.
> Instead, it should be sent to linux-media ML, and applied via my tree.
>
I should of used get_maintainer.pl to find the correct list to send this
too(instead I just looked into the MAINTAINERS file).
I'll resend.
>>
>> CC [M] drivers/media/common/tuners/tuner-simple.o
>> drivers/media/common/tuners/tuner-simple.c: In function 'simple_set_tv_freq':
>> drivers/media/common/tuners/tuner-simple.c:548:20: warning: variable 'tun' set but not used
>>
>> Signed-off-by: Justin P. Mattock<justinmattock@gmail.com>
>> Reviewed-By: Mauro Carvalho Chehab<mchehab@redhat.com>
>>
>> ---
>> drivers/media/common/tuners/tuner-simple.c | 3 ---
>> 1 files changed, 0 insertions(+), 3 deletions(-)
>>
>> diff --git a/drivers/media/common/tuners/tuner-simple.c b/drivers/media/common/tuners/tuner-simple.c
>> index 8abbcc5..84900fa 100644
>> --- a/drivers/media/common/tuners/tuner-simple.c
>> +++ b/drivers/media/common/tuners/tuner-simple.c
>> @@ -545,14 +545,11 @@ static int simple_set_tv_freq(struct dvb_frontend *fe,
>> struct tuner_simple_priv *priv = fe->tuner_priv;
>> u8 config, cb;
>> u16 div;
>> - struct tunertype *tun;
>> u8 buffer[4];
>> int rc, IFPCoff, i;
>> enum param_type desired_type;
>> struct tuner_params *t_params;
>>
>> - tun = priv->tun;
>> -
>> /* IFPCoff = Video Intermediate Frequency - Vif:
>> 940 =16*58.75 NTSC/J (Japan)
>> 732 =16*45.75 M/N STD
>
>
Justin P. Mattock
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-06-21 16:14 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-06-15 5:48 [PATCH 8/8 v2]tuners:tuner-simple Fix warning: variable 'tun' set but not used Justin P. Mattock
2010-06-21 12:34 ` Mauro Carvalho Chehab
2010-06-21 16:14 ` Justin P. Mattock
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).