From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tejun Heo Subject: Re: [PATCH 4/5] block: make blkdev_get/put() handle exclusive access Date: Tue, 09 Nov 2010 11:18:05 +0100 Message-ID: <4CD91FDD.3030603@kernel.org> References: <1288628129-12811-1-git-send-email-tj@kernel.org> <1288628129-12811-5-git-send-email-tj@kernel.org> <20101103150658.GA5627@quack.suse.cz> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20101103150658.GA5627@quack.suse.cz> Sender: reiserfs-devel-owner@vger.kernel.org List-ID: Content-Type: text/plain; charset="us-ascii" To: Jan Kara Cc: axboe@kernel.dk, hch@infradead.org, linux-kernel@vger.kernel.org, petero2@telia.com, schwidefsky@de.ibm.com, heiko.carstens@de.ibm.com, akpm@linux-foundation.org, adilger.kernel@dilger.ca, tytso@mit.edu, mfasheh@suse.com, joel.becker@oracle.com, aelder@sgi.com, dm-devel@redhat.com, drbd-dev@lists.linbit.com, neilb@suse.de, leochen@broadcom.com, sbranden@broadcom.com, chris.mason@oracle.com, swhiteho@redhat.com, shaggy@linux.vnet.ibm.com, joern@logfs.org, konishi.ryusuke@lab.ntt.co.jp, reiserfs-devel@vger.kernel.org, viro@zeniv.linux.org.uk Hello, On 11/03/2010 04:06 PM, Jan Kara wrote: > On Mon 01-11-10 17:15:28, Tejun Heo wrote: > The patch looks OK to me as far as ext3, ext4, and reiserfs are > concerned. One thing I wondered about when I looked at it - does someone > use the 'mode' argument of the blkdev_put() function (well, apart from the > exclusive flag)? Because I've looked at a few random disk ->release() > functions and none of them used it... Yeah, I thought about removing @mode and make blkdev_put() take @holder for exclusive releases. From what I can see, it doesn't seem like any implementation cares but it's customary to have access to @mode on ->release(), so I decided to keep it. It's rather flaky as there's no mechanism to check or enforce it tho. Thanks. -- tejun