fsck.reiser4 (libaal-1.0.5) segfault

fsck.reiser4 (libaal-1.0.5) segfault

[Gleb Baryshev]

Hello

I encountered segmentation fault when checking reiser4 partition. Here 
is fsck output:


*******************************************************************
This is an EXPERIMENTAL version of fsck.reiser4. Read README first.
*******************************************************************

Fscking the /dev/sda10 block device. 

Will check the consistency of the Reiser4 SuperBlock. 

Will check the consistency of the Reiser4 FileSystem. 

Continue? 

(Yes/No): Yes
***** fsck.reiser4 started at Thu Feb  3 07:39:51 2011
Reiser4 fs was detected on /dev/sda10. 

Master super block (16):
magic:		ReIsEr4
blksize:	4096
format:		0x0 (format40)
uuid:		eb887ad5-6151-4076-bbac-f413f7d7f0b2
label:		SRC

Format super block (17):
plugin:		format40
description:	Disk-format plugin.
version:	0
magic:		ReIsEr40FoRmAt
mkfs id:	0x549b325f
flushes:	0
blocks:		2622592
free blocks:	1900771
root block:	937012
tail policy:	0x2 (smart)
next oid:	0x45169
file count:	107030
tree height:	4
key policy:	LARGE


CHECKING THE STORAGE TREE 

FSCK: extent40_repair.c: 167: extent40_check_struct: Node (932329), item 
(0), unit (0),
[441b0:4(FB):737443434c5130:45168:0]: unallocated unit is found.
FSCK: extent40_repair.c: 167: extent40_check_struct: Node (932329), item 
(1), unit (0),
[441b0:4(FB):73746e38357566:45167:0]: unallocated unit is found.
         Read nodes 89014 

	Nodes left in the tree 89014
		Leaves of them 87446, Twigs of them 1540
	Time interval: Thu Feb  3 07:39:52 2011 - Thu Feb  3 07:40:34 2011
CHECKING EXTENT REGIONS. 

         Read twigs 1540 

	Time interval: Thu Feb  3 07:40:34 2011 - Thu Feb  3 07:40:36 2011
CHECKING THE SEMANTIC TREE 

[============\                                      ] 25%Segmentation fault


Backtrace from gdb:


#0  0xb7f59a9c in aal_block_move () from /usr/local/lib/libaal-1.0.so.5
#1  0xb7f88406 in reiser4_tree_alloc_extent () from 
/usr/local/lib/libreiser4-1.0.so.7
#2  0xb7f83af2 in reiser4_tree_walk_node () from 
/usr/local/lib/libreiser4-1.0.so.7
#3  0xb7f83b7a in reiser4_tree_walk_node () from 
/usr/local/lib/libreiser4-1.0.so.7
#4  0xb7f83b7a in reiser4_tree_walk_node () from 
/usr/local/lib/libreiser4-1.0.so.7
#5  0xb7f83d62 in reiser4_tree_adjust () from 
/usr/local/lib/libreiser4-1.0.so.7
#6  0xb7f83db9 in reiser4_tree_mpressure () from 
/usr/local/lib/libreiser4-1.0.so.7
#7  0xb7f84d99 in reiser4_tree_connect_node () from 
/usr/local/lib/libreiser4-1.0.so.7
#8  0xb7f84eb6 in reiser4_tree_load_node () from 
/usr/local/lib/libreiser4-1.0.so.7
#9  0xb7f853be in reiser4_tree_lookup () from 
/usr/local/lib/libreiser4-1.0.so.7
#10 0xb7f80248 in tree_lookup () from /usr/local/lib/libreiser4-1.0.so.7
#11 0xb7fa70ea in obj40_find_item () from /usr/local/lib/libreiser4-1.0.so.7
#12 0xb7fa7f5e in obj40_update_body () from 
/usr/local/lib/libreiser4-1.0.so.7
#13 0xb7fa587d in obj40_check_item () from 
/usr/local/lib/libreiser4-1.0.so.7
#14 0xb7fab249 in reg40_check_struct () from 
/usr/local/lib/libreiser4-1.0.so.7
#15 0xb7f67df0 in repair_object_check_struct () from 
/usr/local/lib/librepair-1.0.so.7
#16 0xb7f6b175 in repair_semantic_check_struct () from 
/usr/local/lib/librepair-1.0.so.7
#17 0xb7f6c966 in cb_object_traverse () from 
/usr/local/lib/librepair-1.0.so.7
#18 0xb7f89148 in reiser4_object_traverse () from 
/usr/local/lib/libreiser4-1.0.so.7
#19 0xb7f89165 in reiser4_object_traverse () from 
/usr/local/lib/libreiser4-1.0.so.7
#20 0xb7f89165 in reiser4_object_traverse () from 
/usr/local/lib/libreiser4-1.0.so.7
#21 0xb7f89165 in reiser4_object_traverse () from 
/usr/local/lib/libreiser4-1.0.so.7
#22 0xb7f89165 in reiser4_object_traverse () from 
/usr/local/lib/libreiser4-1.0.so.7
#23 0xb7f89165 in reiser4_object_traverse () from 
/usr/local/lib/libreiser4-1.0.so.7
#24 0xb7f6be3f in repair_semantic () from /usr/local/lib/librepair-1.0.so.7
#25 0xb7f6db4d in repair_check () from /usr/local/lib/librepair-1.0.so.7
#26 0x0804af6e in main ()


Let me know if additional details are needed or if I should apply any 
patches.

Regards,
Gleb

Re: fsck.reiser4 (libaal-1.0.5) segfault

[Edward Shishkin]

On 02/03/2011 09:20 AM, Gleb Baryshev wrote:
> Hello
>
> I encountered segmentation fault when checking reiser4 partition. Here
> is fsck output:
>
>
> *******************************************************************
> This is an EXPERIMENTAL version of fsck.reiser4. Read README first.
> *******************************************************************
>
> Fscking the /dev/sda10 block device.
> Will check the consistency of the Reiser4 SuperBlock.
> Will check the consistency of the Reiser4 FileSystem.
> Continue?
> (Yes/No): Yes
> ***** fsck.reiser4 started at Thu Feb 3 07:39:51 2011
> Reiser4 fs was detected on /dev/sda10.
> Master super block (16):
> magic: ReIsEr4
> blksize: 4096
> format: 0x0 (format40)
> uuid: eb887ad5-6151-4076-bbac-f413f7d7f0b2
> label: SRC
>
> Format super block (17):
> plugin: format40
> description: Disk-format plugin.
> version: 0
> magic: ReIsEr40FoRmAt
> mkfs id: 0x549b325f
> flushes: 0
> blocks: 2622592
> free blocks: 1900771
> root block: 937012
> tail policy: 0x2 (smart)
> next oid: 0x45169
> file count: 107030
> tree height: 4
> key policy: LARGE
>
>
> CHECKING THE STORAGE TREE
> FSCK: extent40_repair.c: 167: extent40_check_struct: Node (932329), item
> (0), unit (0),
> [441b0:4(FB):737443434c5130:45168:0]: unallocated unit is found.
> FSCK: extent40_repair.c: 167: extent40_check_struct: Node (932329), item
> (1), unit (0),
> [441b0:4(FB):73746e38357566:45167:0]: unallocated unit is found.

Hello.

Could you please pack the metadata by
debugfs.reiser4 -P /dev/xxx | gzip > meta.gz
and let me download the file meta.gz

This kind of corruption might indicate bugs
in reiser4 kernel stuff. In what circumstances
did it happen (was it power loss, etc), and
what kernel did you use?

Thanks,
Edward.

> Read nodes 89014
> Nodes left in the tree 89014
> Leaves of them 87446, Twigs of them 1540
> Time interval: Thu Feb 3 07:39:52 2011 - Thu Feb 3 07:40:34 2011
> CHECKING EXTENT REGIONS.
> Read twigs 1540
> Time interval: Thu Feb 3 07:40:34 2011 - Thu Feb 3 07:40:36 2011
> CHECKING THE SEMANTIC TREE
> [============\ ] 25%Segmentation fault
>
>
> Backtrace from gdb:
>
>
> #0 0xb7f59a9c in aal_block_move () from /usr/local/lib/libaal-1.0.so.5
> #1 0xb7f88406 in reiser4_tree_alloc_extent () from
> /usr/local/lib/libreiser4-1.0.so.7
> #2 0xb7f83af2 in reiser4_tree_walk_node () from
> /usr/local/lib/libreiser4-1.0.so.7
> #3 0xb7f83b7a in reiser4_tree_walk_node () from
> /usr/local/lib/libreiser4-1.0.so.7
> #4 0xb7f83b7a in reiser4_tree_walk_node () from
> /usr/local/lib/libreiser4-1.0.so.7
> #5 0xb7f83d62 in reiser4_tree_adjust () from
> /usr/local/lib/libreiser4-1.0.so.7
> #6 0xb7f83db9 in reiser4_tree_mpressure () from
> /usr/local/lib/libreiser4-1.0.so.7
> #7 0xb7f84d99 in reiser4_tree_connect_node () from
> /usr/local/lib/libreiser4-1.0.so.7
> #8 0xb7f84eb6 in reiser4_tree_load_node () from
> /usr/local/lib/libreiser4-1.0.so.7
> #9 0xb7f853be in reiser4_tree_lookup () from
> /usr/local/lib/libreiser4-1.0.so.7
> #10 0xb7f80248 in tree_lookup () from /usr/local/lib/libreiser4-1.0.so.7
> #11 0xb7fa70ea in obj40_find_item () from
> /usr/local/lib/libreiser4-1.0.so.7
> #12 0xb7fa7f5e in obj40_update_body () from
> /usr/local/lib/libreiser4-1.0.so.7
> #13 0xb7fa587d in obj40_check_item () from
> /usr/local/lib/libreiser4-1.0.so.7
> #14 0xb7fab249 in reg40_check_struct () from
> /usr/local/lib/libreiser4-1.0.so.7
> #15 0xb7f67df0 in repair_object_check_struct () from
> /usr/local/lib/librepair-1.0.so.7
> #16 0xb7f6b175 in repair_semantic_check_struct () from
> /usr/local/lib/librepair-1.0.so.7
> #17 0xb7f6c966 in cb_object_traverse () from
> /usr/local/lib/librepair-1.0.so.7
> #18 0xb7f89148 in reiser4_object_traverse () from
> /usr/local/lib/libreiser4-1.0.so.7
> #19 0xb7f89165 in reiser4_object_traverse () from
> /usr/local/lib/libreiser4-1.0.so.7
> #20 0xb7f89165 in reiser4_object_traverse () from
> /usr/local/lib/libreiser4-1.0.so.7
> #21 0xb7f89165 in reiser4_object_traverse () from
> /usr/local/lib/libreiser4-1.0.so.7
> #22 0xb7f89165 in reiser4_object_traverse () from
> /usr/local/lib/libreiser4-1.0.so.7
> #23 0xb7f89165 in reiser4_object_traverse () from
> /usr/local/lib/libreiser4-1.0.so.7
> #24 0xb7f6be3f in repair_semantic () from /usr/local/lib/librepair-1.0.so.7
> #25 0xb7f6db4d in repair_check () from /usr/local/lib/librepair-1.0.so.7
> #26 0x0804af6e in main ()
>
>
> Let me know if additional details are needed or if I should apply any
> patches.
>
> Regards,
> Gleb
> --
> To unsubscribe from this list: send the line "unsubscribe
> reiserfs-devel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: fsck.reiser4 (libaal-1.0.5) segfault

[Gleb Baryshev]

03.02.2011 14:33, Edward Shishkin writes:
> Hello.
>
> Could you please pack the metadata by
> debugfs.reiser4 -P /dev/xxx | gzip > meta.gz
> and let me download the file meta.gz

Here's link to bzipped metadata:
http://tootiny.net/zq09qj

> This kind of corruption might indicate bugs
> in reiser4 kernel stuff. In what circumstances
> did it happen (was it power loss, etc), and
> what kernel did you use?

There was a hard reset with reiser4 partition mounted, because kernel 
was hung due to oops:


Feb  3 06:04:13 main20b kernel: BUG: unable to handle kernel paging 
request at 4b1b5d0b
Feb  3 06:04:13 main20b kernel: IP: [<c11234e1>] 
jbd2_journal_start+0x2a/0xaf
Feb  3 06:04:13 main20b kernel: *pde = 00000000
Feb  3 06:04:13 main20b kernel: Oops: 0000 [#1]
Feb  3 06:04:13 main20b kernel: last sysfs file: 
/sys/devices/pci0000:00/0000:00:1f.5/host0/target0:0:0/0:0:0:0/block/sda/removable
Feb  3 06:04:13 main20b kernel: Modules linked in: reiser4 lzo_compress 
zlib_deflate nls_cp866 vfat fat vboxnetadp vboxnetflt vboxdrv ext2 xfs 
exportfs reiserfs floppy processor thermal button atl1


Kernel is 2.6.35 - vanilla, patched with corresponding release of 
Reiser4 (thus, reiser4 module isn't the latest).

Regards,
Gleb

Re: fsck.reiser4 (libaal-1.0.5) segfault

[Edward Shishkin]

Gleb Baryshev wrote:
> 03.02.2011 14:33, Edward Shishkin writes:
>> Hello.
>>
>> Could you please pack the metadata by
>> debugfs.reiser4 -P /dev/xxx | gzip > meta.gz
>> and let me download the file meta.gz
>
> Here's link to bzipped metadata:
> http://tootiny.net/zq09qj

Sorry, but this file looks corrupted.
Could you please try again?

Also make sure that packed meta-data are
extracted correctly by the following way:

#touch meta_tmp
#bzcat meta.bz2 | debugfs.reiser4 -U meta_tmp

>
>> This kind of corruption might indicate bugs
>> in reiser4 kernel stuff. In what circumstances
>> did it happen (was it power loss, etc), and
>> what kernel did you use?
>
> There was a hard reset with reiser4 partition mounted, because kernel 
> was hung due to oops:

reiser4-for-2.6.35 is buggy, please consider upgrading to .36 or later..

Edward.

>
>
> Feb  3 06:04:13 main20b kernel: BUG: unable to handle kernel paging 
> request at 4b1b5d0b
> Feb  3 06:04:13 main20b kernel: IP: [<c11234e1>] 
> jbd2_journal_start+0x2a/0xaf
> Feb  3 06:04:13 main20b kernel: *pde = 00000000
> Feb  3 06:04:13 main20b kernel: Oops: 0000 [#1]
> Feb  3 06:04:13 main20b kernel: last sysfs file: 
> /sys/devices/pci0000:00/0000:00:1f.5/host0/target0:0:0/0:0:0:0/block/sda/removable 
>
> Feb  3 06:04:13 main20b kernel: Modules linked in: reiser4 
> lzo_compress zlib_deflate nls_cp866 vfat fat vboxnetadp vboxnetflt 
> vboxdrv ext2 xfs exportfs reiserfs floppy processor thermal button atl1
>
>
> Kernel is 2.6.35 - vanilla, patched with corresponding release of 
> Reiser4 (thus, reiser4 module isn't the latest).
>
> Regards,
> Gleb
> -- 
> To unsubscribe from this list: send the line "unsubscribe 
> reiserfs-devel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>

Re: fsck.reiser4 (libaal-1.0.5) segfault

[Gleb Baryshev]

03.02.2011 22:09, Edward Shishkin writes:
> Sorry, but this file looks corrupted.
> Could you please try again?
>
> Also make sure that packed meta-data are
> extracted correctly by the following way:
>
> #touch meta_tmp
> #bzcat meta.bz2 | debugfs.reiser4 -U meta_tmp

For some reason, debugfs was adding junk every time - 8 bytes (1B 5B 3F
31 30 33 34 68) before 'VRSN'; in other respects the metadata file is
all right. Finally I ran debugfs from LiveCD and got correct dump:
http://tootiny.net/813h25

BTW, fsck from LiveCD segfaulted, too.

Gleb

Re: fsck.reiser4 (libaal-1.0.5) segfault

[Edward Shishkin]

Gleb Baryshev wrote:
> 03.02.2011 22:09, Edward Shishkin writes:
>> Sorry, but this file looks corrupted.
>> Could you please try again?
>>
>> Also make sure that packed meta-data are
>> extracted correctly by the following way:
>>
>> #touch meta_tmp
>> #bzcat meta.bz2 | debugfs.reiser4 -U meta_tmp
>
> For some reason, debugfs was adding junk every time - 8 bytes (1B 5B 3F
> 31 30 33 34 68) before 'VRSN'; in other respects the metadata file is
> all right. Finally I ran debugfs from LiveCD and got correct dump:
> http://tootiny.net/813h25

OK, thanks,
Eventually I have reproduced the segfault.
I'll try to figure out what is wrong with fsck, but it can take some time..

Edward.

>
> BTW, fsck from LiveCD segfaulted, too.
>
> Gleb
> -- 
> To unsubscribe from this list: send the line "unsubscribe 
> reiserfs-devel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>

Re: fsck.reiser4 (libaal-1.0.5) segfault

[Edward Shishkin]

[-- Attachment #1: Type: text/plain, Size: 1141 bytes --]

Hello.

I have taken a look at your problem on weekends.

Please, apply the attached patch to reiser4progs-1.0.7,
and check your partition again. The patched fsck after
check phase should report about minor corruption and
suggest to repair it with --fix option.

Please, report about results.

Thanks,
Edward.


On 02/03/2011 10:05 PM, Gleb Baryshev wrote:
> 03.02.2011 22:09, Edward Shishkin writes:
>> Sorry, but this file looks corrupted.
>> Could you please try again?
>>
>> Also make sure that packed meta-data are
>> extracted correctly by the following way:
>>
>> #touch meta_tmp
>> #bzcat meta.bz2 | debugfs.reiser4 -U meta_tmp
>
> For some reason, debugfs was adding junk every time - 8 bytes (1B 5B 3F
> 31 30 33 34 68) before 'VRSN'; in other respects the metadata file is
> all right. Finally I ran debugfs from LiveCD and got correct dump:
> http://tootiny.net/813h25
>
> BTW, fsck from LiveCD segfaulted, too.
>
> Gleb
> --
> To unsubscribe from this list: send the line "unsubscribe
> reiserfs-devel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html


[-- Attachment #2: fsck-dont-allocate-unalloc-extents.patch --]
[-- Type: text/plain, Size: 867 bytes --]

Don't try to allocate unallocated extents.

Signed-off-by: Edward Shishkin <edward.shishkin@gmail.com>
---
 libreiser4/tree.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

--- reiser4progs-1.0.7.orig/libreiser4/tree.c
+++ reiser4progs-1.0.7/libreiser4/tree.c
@@ -1346,7 +1346,7 @@ errno_t reiser4_tree_adjust(reiser4_tree
 #ifndef ENABLE_MINIMAL
 			res = reiser4_tree_walk_node(tree, tree->root, 
 						     cb_node_adjust,
-						     cb_nodeptr_adjust,
+						     NULL,
 						     cb_node_unload);
 #else
 			res = reiser4_tree_walk_node(tree, tree->root, 
@@ -1586,7 +1586,7 @@ errno_t reiser4_tree_sync(reiser4_tree_t
 	   everything. */
 	if ((res = reiser4_tree_walk_node(tree, tree->root, 
 					  cb_node_adjust,
-					  cb_nodeptr_adjust,
+					  NULL,
 					  cb_node_unload)))
 	{
 		aal_error("Can't save formatted nodes to device.");

Re: fsck.reiser4 (libaal-1.0.5) segfault

[Gleb Baryshev]

07.02.2011 01:28, Edward Shishkin writes:
> Hello.
>
> I have taken a look at your problem on weekends.
>
> Please, apply the attached patch to reiser4progs-1.0.7,
> and check your partition again. The patched fsck after
> check phase should report about minor corruption and
> suggest to repair it with --fix option.
>
> Please, report about results.
>
> Thanks,
> Edward.

It went as expected, FS is consistent now. Thanks!

Gleb

Re: fsck.reiser4 (libaal-1.0.5) segfault

[Edward Shishkin]

On 02/07/2011 10:21 AM, Gleb Baryshev wrote:
> 07.02.2011 01:28, Edward Shishkin writes:
>> Hello.
>>
>> I have taken a look at your problem on weekends.
>>
>> Please, apply the attached patch to reiser4progs-1.0.7,
>> and check your partition again. The patched fsck after
>> check phase should report about minor corruption and
>> suggest to repair it with --fix option.
>>
>> Please, report about results.
>>
>> Thanks,
>> Edward.
>
> It went as expected, FS is consistent now.


Data of 2 files with inode numbers 282983 and
282984 are lost. You might want to recreate them.

Edward.