* Re: Reiser4 panics on kernel 3.6.11 (balance_dirty_page_cluster, edward-1547) [not found] <5103A388.2080906@gmail.com> @ 2013-01-27 23:49 ` Edward Shishkin 2013-01-30 18:48 ` Gleb Baryshev 0 siblings, 1 reply; 3+ messages in thread From: Edward Shishkin @ 2013-01-27 23:49 UTC (permalink / raw) To: Gleb Baryshev; +Cc: reiserfs-devel [-- Attachment #1: Type: text/plain, Size: 530 bytes --] Hello Gleb, Thanks for the report! Please, find the fixup in the attachment. Edward. P.S. Reiser4 debug mode results in dramatic performance drop when tail packing / compression is on. Use it only when something goes wrong... On 01/26/2013 10:36 AM, Gleb Baryshev wrote: > Hello, > > I get a kernel panic when I start Opera browser on Linux 3.6.11 patched > with reiser4-for-3.6.4. The filesystem is ccreg and used for /. > > Here are a couple of screenshots attached with assertions and stack traces. > > Regards, > Gleb > [-- Attachment #2: reiser4-fix-balance_dirty-assert.patch --] [-- Type: text/plain, Size: 995 bytes --] Signed-off-by: Edward Shishkin <edward.shishkin@gmail.com> --- fs/reiser4/plugin/file/cryptcompress.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) --- linux-3.7.1.orig/fs/reiser4/plugin/file/cryptcompress.c +++ linux-3.7.1/fs/reiser4/plugin/file/cryptcompress.c @@ -2020,8 +2020,7 @@ static int balance_dirty_page_cluster(st assert("edward-724", inode != NULL); assert("edward-725", cryptcompress_inode_ok(inode)); - assert("edward-1547", - nr_dirtied != 0 && nr_dirtied <= cluster_nrpages(inode)); + assert("edward-1547", nr_dirtied <= cluster_nrpages(inode)); /* set next window params */ move_update_window(inode, clust, off, to_file); @@ -2032,6 +2031,8 @@ static int balance_dirty_page_cluster(st assert("edward-726", clust->hint->lh.owner == NULL); info = cryptcompress_inode_data(inode); + if (nr_dirtied == 0) + return 0; mutex_unlock(&info->checkin_mutex); reiser4_throttle_write(inode, nr_dirtied); mutex_lock(&info->checkin_mutex); ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Reiser4 panics on kernel 3.6.11 (balance_dirty_page_cluster, edward-1547) 2013-01-27 23:49 ` Reiser4 panics on kernel 3.6.11 (balance_dirty_page_cluster, edward-1547) Edward Shishkin @ 2013-01-30 18:48 ` Gleb Baryshev 2013-01-30 20:27 ` Edward Shishkin 0 siblings, 1 reply; 3+ messages in thread From: Gleb Baryshev @ 2013-01-30 18:48 UTC (permalink / raw) To: Edward Shishkin; +Cc: reiserfs-devel 28.01.2013 00:49, Edward Shishkin wrote: > Hello Gleb, > > Thanks for the report! > Please, find the fixup in the attachment. > > Edward. > P.S. Reiser4 debug mode results in dramatic performance drop > when tail packing / compression is on. Use it only when something > goes wrong... Now it works ok, thank you for the fix and for the hint! Regards, Gleb ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Reiser4 panics on kernel 3.6.11 (balance_dirty_page_cluster, edward-1547) 2013-01-30 18:48 ` Gleb Baryshev @ 2013-01-30 20:27 ` Edward Shishkin 0 siblings, 0 replies; 3+ messages in thread From: Edward Shishkin @ 2013-01-30 20:27 UTC (permalink / raw) To: Gleb Baryshev; +Cc: reiserfs-devel On 01/30/2013 07:48 PM, Gleb Baryshev wrote: > 28.01.2013 00:49, Edward Shishkin wrote: >> Hello Gleb, >> >> Thanks for the report! >> Please, find the fixup in the attachment. >> >> Edward. >> P.S. Reiser4 debug mode results in dramatic performance drop >> when tail packing / compression is on. Use it only when something >> goes wrong... > > Now it works ok, thank you for the fix and for the hint! > You are welcome. Also if you work with reiser4 on kernels < 3.7, please, make sure that the following options in .config are off: CONFIG_HUGEPAGES CONFIG_COMPACTION CONFIG_MIGRATION Thanks, Edward. ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-01-30 20:27 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <5103A388.2080906@gmail.com>
2013-01-27 23:49 ` Reiser4 panics on kernel 3.6.11 (balance_dirty_page_cluster, edward-1547) Edward Shishkin
2013-01-30 18:48 ` Gleb Baryshev
2013-01-30 20:27 ` Edward Shishkin
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).