Re: Reiser4 for 3.11

[Edward Shishkin <edward.shishkin@gmail.com>]

On 09/09/2013 12:44 PM, Edward Shishkin wrote:
> On 09/06/2013 07:36 AM, Ivan Shapovalov wrote:
>> Hi Edward!
>>
>> I'm sorry for the silence... The summer, as it usually happens, 
>> turned out to
>> be not-easier-than-studying-days (personal life and all), so 
>> unfortunately
>> there is not much progress with TRIM implementation for reiser4. 
>> There is some
>> code, but it's stability is zero.
>>
>> Anyway, here is my usual attempt to port reiser4 to next kernel. 3.11 
>> got a
>> significant API change (readdir() of file_operations changed to 
>> iterate()),
>> and I'm unsure if I done that correctly. But it works, unlike TRIM. :)
>
>
> Cool. Thanks!!!
>
>
>>
>> (FYI, iterate() differs from readdir() mostly in that it works with a 
>> copy of
>> f_pos instead of with f->f_pos directly.)
>
>
> AFAIK they fixed races in readdir() and friends.
> I'll take a look at this more carefully...


Vfs people have introduced a new field (.for_sync) of  struct 
wb_writeback_work,
it should be initialized as 1 in reiser4_sync_fs().

The next comment is that all PF_FOO flags should be "independent". In 
particular,
"compound" values like 0x80000002 are unacceptable for PF_FLUSHER (is it 
clear,
why so?). I would recommend 0x00000001, or 0x00000002.

In other bits the patch looks OK.

Thanks!
Edward.