From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Gentile Subject: Quick update Date: Tue, 17 Sep 2013 17:26:48 +0000 Message-ID: <523890D8.1080407@gmail.com> References: <3473565.3piOE8Lf58@intelfx-laptop> <522DA671.9040006@gmail.com> <52360C7B.6080908@gmail.com> <5377295.oFoUDLQBZJ@intelfx-laptop> <523614FD.6010708@gmail.com> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Return-path: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; bh=JyLGyxHiw+oQ+3dGDhM9Ow4TBfuvUa32P1sHVFKCMyY=; b=wloUe8zLGsHWyV3dXSIZFd3JgOA9ADucXrcP1SY7GLF+BmDm5q9/d2FMnXZhsvzJ/T l9ePz2XCSbYKGVgR+22iTRbuqBs1xj66n3zgAT7pXEcuQ4YEzJDPq1I6INY/y+trdqOB zGIXq03+2BMRjMIGrMCm30C2uhsbMx2GAdaws/4O0D08tMZdymqGC9QwX/xCZW+UW1A7 WsTK87gea2h28a1BSY7vz/8KAGcnPUnl+EwEg1oUz5osKKT4sxjCOT/dUbqnC0VtkhmW cDqNktewElkfBCLdqu+JvHSz9wXJD/kDjGopYQ4Hsgen4ZO18uVkr/gbxEO5ep/PGoNT 7Btw== In-Reply-To: <523614FD.6010708@gmail.com> Sender: reiserfs-devel-owner@vger.kernel.org List-ID: Content-Type: text/plain; charset="us-ascii" To: Ivan Shapovalov Cc: Edward Shishkin , reiserfs-devel Out of curiosity had to try it, attempted compile w/Reiser4 built in with the first patch I received from Ivan on the new 3.12-rc1. To nobody's surprise it failed. Ivan, had you released that new patch by chance with the changes Edward was mentioning? Thanks again, Chris On 09/15/2013 08:13 PM, Chris Gentile wrote: > On 09/15/13 19:51, Ivan Shapovalov wrote: >> On Sunday 15 September 2013 at 21:37:31, Edward wrote: >>> On 09/09/2013 12:44 PM, Edward Shishkin wrote: >>>> On 09/06/2013 07:36 AM, Ivan Shapovalov wrote: >>>>> Hi Edward! >>>>> >>>>> I'm sorry for the silence... The summer, as it usually happens, >>>>> turned out to >>>>> be not-easier-than-studying-days (personal life and all), so >>>>> unfortunately >>>>> there is not much progress with TRIM implementation for reiser4. >>>>> There is some >>>>> code, but it's stability is zero. >>>>> >>>>> Anyway, here is my usual attempt to port reiser4 to next kernel. 3.11 >>>>> got a >>>>> significant API change (readdir() of file_operations changed to >>>>> iterate()), >>>>> and I'm unsure if I done that correctly. But it works, unlike TRIM. :) >>>> Cool. Thanks!!! >>>> >>>> >>>>> (FYI, iterate() differs from readdir() mostly in that it works with a >>>>> copy of >>>>> f_pos instead of with f->f_pos directly.) >>>> AFAIK they fixed races in readdir() and friends. >>>> I'll take a look at this more carefully... >>> Vfs people have introduced a new field (.for_sync) of struct >>> wb_writeback_work, >>> it should be initialized as 1 in reiser4_sync_fs(). >> Ah, missed that. >> >>> The next comment is that all PF_FOO flags should be "independent". In >>> particular, >>> "compound" values like 0x80000002 are unacceptable for PF_FLUSHER (is it >>> clear, >>> why so?). I would recommend 0x00000001, or 0x00000002. >> That seems to be a typo... Of course, I know it's a bitmask :) >> >>> In other bits the patch looks OK. >>> >>> Thanks! >>> Edward. >> Thanks for the review! I'll fix the points and send an updated patch shortly. >> > Please forward to me as well if you don't mind? > Thanks! > Chris >