* [PATCH 20/21] fs: Move prototype declaration to header file reiserfs.h from super.c [not found] <b572932c3e016c55e596686283036316a1aacd2f.1391949868.git.rashika.kheria@gmail.com> @ 2014-02-09 13:29 ` Rashika Kheria 2014-02-09 18:08 ` Jeff Mahoney 0 siblings, 1 reply; 2+ messages in thread From: Rashika Kheria @ 2014-02-09 13:29 UTC (permalink / raw) To: linux-kernel Cc: Al Viro, Andrew Morton, Alex Elder, David S. Miller, Jeff Mahoney, Rashika Kheria, Eric W. Biederman, Ionut-Gabriel Radu, reiserfs-devel, josh Move prototype declaration to header file reiserfs/reiserfs.h from reiserfs/super.c because they are used by more than one file. This eliminates the following warning in reiserfs/bitmap.c: fs/reiserfs/bitmap.c:647:6: warning: no previous prototype for ‘show_alloc_options’ [-Wmissing-prototypes] Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com> Reviewed-by: Josh Triplett <josh@joshtriplett.org> --- fs/reiserfs/reiserfs.h | 1 + fs/reiserfs/super.c | 1 - 2 files changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/reiserfs/reiserfs.h b/fs/reiserfs/reiserfs.h index 8d06adf..83d4eac 100644 --- a/fs/reiserfs/reiserfs.h +++ b/fs/reiserfs/reiserfs.h @@ -2831,6 +2831,7 @@ void reiserfs_init_alloc_options(struct super_block *s); */ __le32 reiserfs_choose_packing(struct inode *dir); +void show_alloc_options(struct seq_file *seq, struct super_block *s); int reiserfs_init_bitmap_cache(struct super_block *sb); void reiserfs_free_bitmap_cache(struct super_block *sb); void reiserfs_cache_bitmap_metadata(struct super_block *sb, struct buffer_head *bh, struct reiserfs_bitmap_info *info); diff --git a/fs/reiserfs/super.c b/fs/reiserfs/super.c index 2c80335..16d5335 100644 --- a/fs/reiserfs/super.c +++ b/fs/reiserfs/super.c @@ -62,7 +62,6 @@ static int is_any_reiserfs_magic_string(struct reiserfs_super_block *rs) static int reiserfs_remount(struct super_block *s, int *flags, char *data); static int reiserfs_statfs(struct dentry *dentry, struct kstatfs *buf); -void show_alloc_options(struct seq_file *seq, struct super_block *s); static int reiserfs_sync_fs(struct super_block *s, int wait) { -- 1.7.9.5 -- To unsubscribe from this list: send the line "unsubscribe reiserfs-devel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 20/21] fs: Move prototype declaration to header file reiserfs.h from super.c 2014-02-09 13:29 ` [PATCH 20/21] fs: Move prototype declaration to header file reiserfs.h from super.c Rashika Kheria @ 2014-02-09 18:08 ` Jeff Mahoney 0 siblings, 0 replies; 2+ messages in thread From: Jeff Mahoney @ 2014-02-09 18:08 UTC (permalink / raw) To: Rashika Kheria, linux-kernel Cc: Al Viro, Andrew Morton, Alex Elder, David S. Miller, Eric W. Biederman, Ionut-Gabriel Radu, reiserfs-devel, josh On 02/09/2014 08:29 AM, Rashika Kheria wrote: > Move prototype declaration to header file reiserfs/reiserfs.h from > reiserfs/super.c because they are used by more than one file. > > This eliminates the following warning in reiserfs/bitmap.c: > fs/reiserfs/bitmap.c:647:6: warning: no previous prototype for ‘show_alloc_options’ [-Wmissing-prototypes] > > Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com> > Reviewed-by: Josh Triplett <josh@joshtriplett.org> Acked-by: Jeff Mahoney <jeffm@suse.com> > --- > fs/reiserfs/reiserfs.h | 1 + > fs/reiserfs/super.c | 1 - > 2 files changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/reiserfs/reiserfs.h b/fs/reiserfs/reiserfs.h > index 8d06adf..83d4eac 100644 > --- a/fs/reiserfs/reiserfs.h > +++ b/fs/reiserfs/reiserfs.h > @@ -2831,6 +2831,7 @@ void reiserfs_init_alloc_options(struct super_block *s); > */ > __le32 reiserfs_choose_packing(struct inode *dir); > > +void show_alloc_options(struct seq_file *seq, struct super_block *s); > int reiserfs_init_bitmap_cache(struct super_block *sb); > void reiserfs_free_bitmap_cache(struct super_block *sb); > void reiserfs_cache_bitmap_metadata(struct super_block *sb, struct buffer_head *bh, struct reiserfs_bitmap_info *info); > diff --git a/fs/reiserfs/super.c b/fs/reiserfs/super.c > index 2c80335..16d5335 100644 > --- a/fs/reiserfs/super.c > +++ b/fs/reiserfs/super.c > @@ -62,7 +62,6 @@ static int is_any_reiserfs_magic_string(struct reiserfs_super_block *rs) > > static int reiserfs_remount(struct super_block *s, int *flags, char *data); > static int reiserfs_statfs(struct dentry *dentry, struct kstatfs *buf); > -void show_alloc_options(struct seq_file *seq, struct super_block *s); > > static int reiserfs_sync_fs(struct super_block *s, int wait) > { > -- Jeff Mahoney SUSE Labs -- To unsubscribe from this list: send the line "unsubscribe reiserfs-devel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-02-09 18:08 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <b572932c3e016c55e596686283036316a1aacd2f.1391949868.git.rashika.kheria@gmail.com>
2014-02-09 13:29 ` [PATCH 20/21] fs: Move prototype declaration to header file reiserfs.h from super.c Rashika Kheria
2014-02-09 18:08 ` Jeff Mahoney
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).