From: Edward Shishkin <edward.shishkin@gmail.com>
To: ReiserFS development mailing list <reiserfs-devel@vger.kernel.org>
Subject: [patch 1/1] reiser4: Fixups
Date: Sat, 09 Aug 2014 19:43:55 +0200 [thread overview]
Message-ID: <53E65DDB.2090306@gmail.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 1 bytes --]
[-- Attachment #2: reiser4-fixups-for-3.15.patch --]
[-- Type: text/x-patch, Size: 1667 bytes --]
. Fix up incorrect calculation of REISER4_SUPER_MAGIC_STRING size;
. Fix up incorrect initialization of dataonstack, dotdot_entry,
dotdot_name variables in reiser4_rename_common().
Signed-off-by: Edward Shishkin <edward.shishkin@gmail.com>
---
fs/reiser4/plugin/inode_ops_rename.c | 6 +++---
fs/reiser4/reiser4.h | 2 +-
fs/reiser4/vfs_ops.c | 1 -
3 files changed, 4 insertions(+), 5 deletions(-)
--- a/fs/reiser4/plugin/inode_ops_rename.c
+++ b/fs/reiser4/plugin/inode_ops_rename.c
@@ -572,10 +572,10 @@ int reiser4_rename_common(struct inode *
dotdot entry. */
coord_t *dotdot_coord;
- memset(dataonstack, 0, sizeof dataonstack);
- memset(dotdot_entry, 0, sizeof dotdot_entry);
+ memset(dataonstack, 0, sizeof(*dataonstack));
+ memset(dotdot_entry, 0, sizeof(*dotdot_entry));
dotdot_entry->obj = old_dir;
- memset(dotdot_name, 0, sizeof dotdot_name);
+ memset(dotdot_name, 0, sizeof(*dotdot_name));
dotdot_name->d_name.name = "..";
dotdot_name->d_name.len = 2;
/*
--- a/fs/reiser4/reiser4.h
+++ b/fs/reiser4/reiser4.h
@@ -54,7 +54,7 @@
* option
*/
-extern const char *REISER4_SUPER_MAGIC_STRING;
+#define REISER4_SUPER_MAGIC_STRING "ReIsEr4"
extern const int REISER4_MAGIC_OFFSET; /* offset to magic string from the
* beginning of device */
--- a/fs/reiser4/vfs_ops.c
+++ b/fs/reiser4/vfs_ops.c
@@ -213,7 +213,6 @@ void reiser4_throttle_write(struct inode
current->journal_info = ctx;
}
-const char *REISER4_SUPER_MAGIC_STRING = "ReIsEr4";
const int REISER4_MAGIC_OFFSET = 16 * 4096; /* offset to magic string from the
* beginning of device */
reply other threads:[~2014-08-09 17:43 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53E65DDB.2090306@gmail.com \
--to=edward.shishkin@gmail.com \
--cc=reiserfs-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).