From: Edward Shishkin <edward.shishkin@gmail.com>
To: ReiserFS development mailing list <reiserfs-devel@vger.kernel.org>
Subject: [patch 2/3] reiser4: don't panic in do_readpage_ctail
Date: Sun, 30 Nov 2014 22:42:28 +0100 [thread overview]
Message-ID: <547B8F44.3080408@gmail.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 59 bytes --]
Signed-off-by: Edward Shishkin <edward.shishkin@gmail.com>
[-- Attachment #2: reiser4-fix-do_readpage_ctail.patch --]
[-- Type: text/x-patch, Size: 786 bytes --]
Don't panic when unprepped ctail cluster is found.
Instead, return error and suggest to fsck.
Signed-off-by: Edward Shishkin <edward.shishkin@gmail.com>
---
fs/reiser4/plugin/item/ctail.c | 10 +++++++++-
1 file changed, 9 insertions(+), 1 deletion(-)
--- a/fs/reiser4/plugin/item/ctail.c
+++ b/fs/reiser4/plugin/item/ctail.c
@@ -666,7 +666,15 @@ int do_readpage_ctail(struct inode * ino
switch (clust->dstat) {
case UNPR_DISK_CLUSTER:
- BUG_ON(1);
+ /*
+ * Page is not uptodate and item cluster is unprepped:
+ * this must not ever happen.
+ */
+ warning("edward-1632",
+ "Bad item cluster %lu (Inode %llu). Fsck?",
+ clust->index,
+ (unsigned long long)get_inode_oid(inode));
+ return RETERR(-EIO);
case TRNC_DISK_CLUSTER:
/*
* Race with truncate!
reply other threads:[~2014-11-30 21:42 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=547B8F44.3080408@gmail.com \
--to=edward.shishkin@gmail.com \
--cc=reiserfs-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).