From mboxrd@z Thu Jan  1 00:00:00 1970
From: Edward Shishkin <edward.shishkin@gmail.com>
Subject: Re: [PATCHv2 0/3] reiser4: space grabbing fixes.
Date: Wed, 10 Dec 2014 13:52:08 +0100
Message-ID: <548841F8.4010409@gmail.com>
References: <1414048685-4224-1-git-send-email-intelfx100@gmail.com> <5497656.EllimmOa76@intelfx-laptop>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Return-path: <reiserfs-devel-owner@vger.kernel.org>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20120113;
        h=message-id:date:from:user-agent:mime-version:to:subject:references
         :in-reply-to:content-type:content-transfer-encoding;
        bh=LiCvNlzuBieUwqgWtzl7Ql1crPUhyQfMucUlu7Sw7hI=;
        b=pdP61HL/mxG+txbMG2IiXci3XjrBZIn06qZqMz8wQI21a5+xU60D1QlJrkGNufYzxH
         SYmbBPrPkfrsSQcVGcxe4UYuil31RFujdyaE0bxGRTywFlKyrVGmH5ffh6hlGWGt5hKP
         VHGqmrA0Jvv5Yan8yJXim2DiOozmRw+MzE0F2wO0wZ+6oVNePeOvpzv+t50+bPGcGnlb
         kIYzYQc18GpW4CgCnioMiWSu4ZWStePNao7mwKWZT5ZU8heRqdKelYi0+ONOP4pyGYY1
         cfIfOZ8/m7TXT8yuczVQlv1Eb1Yxz3/VWZjMl7x0ypCgWCOJczsPWsJhyg9+FzCmJuHD
         Q0Eg==
In-Reply-To: <5497656.EllimmOa76@intelfx-laptop>
Sender: reiserfs-devel-owner@vger.kernel.org
List-ID: <reiserfs-devel.vger.kernel.org>
Content-Type: text/plain; charset="us-ascii"; format="flowed"
To: Ivan Shapovalov <intelfx100@gmail.com>, reiserfs-devel@vger.kernel.org


On 12/10/2014 01:27 PM, Ivan Shapovalov wrote:
> On Thursday 23 October 2014 at 11:18:02, Ivan Shapovalov wrote:	
>> These are mostly equivalent transformations (aside from the first patch)
>> I've done when I was experimenting with rwsems at zero-th iteration of
>> batch discard support.
>>
>> v2: - disable grab in current context unconditionally, not only if !BA_FORCE
>>
>> Ivan Shapovalov (3):
>>    reiser4: block_alloc: improve error handling in reiser4_grab_reserved().
>>    reiser4: block_alloc: sanitize grab_enabled modifications.
>>    reiser4: do not mess with grab_enabled; instead, use BA_FORCE.
>>
>>   fs/reiser4/block_alloc.c                 | 57 +++++++++++++++++---------------
>>   fs/reiser4/plugin/file/file.c            | 12 +++----
>>   fs/reiser4/plugin/file/file_conversion.c |  3 +-
>>   fs/reiser4/plugin/file/tail_conversion.c | 11 +++---
>>   fs/reiser4/plugin/item/extent_file_ops.c |  3 +-
>>   fs/reiser4/plugin/item/tail.c            |  3 +-
>>   fs/reiser4/safe_link.c                   |  4 +--
>>   7 files changed, 44 insertions(+), 49 deletions(-)
> ping, what's the status?


This is in "upstream" already.


>
> /*
> I'll send another round of discard patches shortly... That is, once I figure
> out how to explain in comments the sheer amount of happily coinciding subtle
> details, whose coincidence makes everything actually work. :/


Note, that basic discard stuff is also in "upstream".
So, please, make sure that your patches are "re-based"


>
> BTW, could you please check that I've rebased your "precise discard" patch
> correctly?
> https://github.com/intelfx/linux/commit/47f27446d5ae7b796a842735811c48cc07615dd6
> */
>


I suggest to start with implementing the bitmap primitives that
I talked about. Just to avoid extra-work..

Thanks,
Edward.