From: Edward Shishkin <edward.shishkin@gmail.com>
To: Ivan Shapovalov <intelfx100@gmail.com>
Cc: reiserfs-devel@vger.kernel.org
Subject: Re: [PATCHv2 0/3] reiser4: space grabbing fixes.
Date: Sun, 14 Dec 2014 00:41:36 +0100 [thread overview]
Message-ID: <548CCEB0.2000602@gmail.com> (raw)
In-Reply-To: <2158963.qP6uLQDbWK@intelfx-laptop>
On 12/12/2014 11:19 PM, Ivan Shapovalov wrote:
> On Wednesday 10 December 2014 at 22:51:41, Edward Shishkin wrote:
>> On 12/10/2014 02:30 PM, Ivan Shapovalov wrote:
>>> On Wednesday 10 December 2014 at 13:52:08, Edward Shishkin wrote:
>>>> On 12/10/2014 01:27 PM, Ivan Shapovalov wrote:
>>>>> [...]
>>>>> ping, what's the status?
>>>> This is in "upstream" already.
>>> Hm.. I didn't see it..
>>>
>>> Well, then a follow-up fix should be applied, as described in one of previous
>>> messages, or this should be reverted.
>>
>> With that patch things looked better and you promised
>> "equivalent transform". OK, I'll roll it back then.
> Yes, that was a mistake. It's actually not an equivalent transformation.
> And I need to think what to do with this, because current code looks messy,
> but things are apparently so fragile...
>
> Are there any documentation on the "space grabbing" subsystem?
Nop.
I think that you grasped the basic idea of the reservation
subsystem perfectly.
> For example,
> there's some flush code which grabs reserved space _without_ taking the mutex..
Most likely it is not needed for some subtle reasons,
which nobody remembers.
Edward.
prev parent reply other threads:[~2014-12-13 23:41 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-23 7:18 [PATCHv2 0/3] reiser4: space grabbing fixes Ivan Shapovalov
2014-10-23 7:18 ` [PATCHv2 1/3] reiser4: block_alloc: improve error handling in reiser4_grab_reserved() Ivan Shapovalov
2014-10-23 7:18 ` [PATCHv2 2/3] reiser4: block_alloc: sanitize grab_enabled modifications Ivan Shapovalov
2014-11-16 5:38 ` Ivan Shapovalov
2014-11-16 9:53 ` Edward Shishkin
2014-11-16 10:45 ` Edward Shishkin
2014-11-16 11:49 ` Edward Shishkin
2014-11-16 10:45 ` Edward Shishkin
2014-11-19 1:39 ` Ivan Shapovalov
2014-10-23 7:18 ` [PATCHv2 3/3] reiser4: do not mess with grab_enabled; instead, use BA_FORCE Ivan Shapovalov
2014-10-23 7:20 ` [PATCHv2 0/3] reiser4: space grabbing fixes Ivan Shapovalov
2014-12-10 12:27 ` Ivan Shapovalov
2014-12-10 12:52 ` Edward Shishkin
2014-12-10 13:30 ` Ivan Shapovalov
2014-12-10 21:51 ` Edward Shishkin
2014-12-12 22:19 ` Ivan Shapovalov
2014-12-13 23:41 ` Edward Shishkin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=548CCEB0.2000602@gmail.com \
--to=edward.shishkin@gmail.com \
--cc=intelfx100@gmail.com \
--cc=reiserfs-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).