From: Edward Shishkin <edward.shishkin@gmail.com>
To: Ivan Shapovalov <intelfx100@gmail.com>,
Reiserfs development mailing list
<reiserfs-devel@vger.kernel.org>
Subject: Re: [patch] reiser4: port for Linux-4.1
Date: Tue, 30 Jun 2015 09:30:59 +0200 [thread overview]
Message-ID: <559245B3.1020804@gmail.com> (raw)
In-Reply-To: <1435648387.15634.3.camel@gmail.com>
On 06/30/2015 09:13 AM, Ivan Shapovalov wrote:
> On 2015-06-30 at 01:54 +0800, Edward Shishkin wrote:
>> Oh, bad
>> generic_write_checks() doesn't change offset now,
>> please, ignore this patch..
> Hi,
Hello.
>
> it does change it, but in struct kiocb instance, but we keep using
> initial "off".
>
> i'm trying to port file_operations' ->write() to ->write_iter() right
Hmm. You'll need to modify ->write() of both file plugins -
it's not simple, esp. for cryptcompress, which performs writes by
chunks (4, 8, ... 64K)
> now, FTR. The obvious fix (assign back ki_pos to off) is too ugly :)
may be just create a static inline function
reiser4_write_check() ?
{
...
generic_write_check();
*off = iocb.ki_pos;
}
Thanks,
Edward.
next prev parent reply other threads:[~2015-06-30 7:30 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-26 14:06 [patch] reiser4: port for Linux-4.1 Edward Shishkin
2015-06-29 17:54 ` Edward Shishkin
2015-06-30 7:13 ` Ivan Shapovalov
2015-06-30 7:30 ` Edward Shishkin [this message]
2015-06-30 8:06 ` Ivan Shapovalov
2015-06-30 8:58 ` Edward Shishkin
2015-07-01 23:35 ` Ivan Shapovalov
2015-07-04 7:53 ` Edward Shishkin
2015-07-04 17:53 ` Ivan Shapovalov
2015-07-04 18:33 ` Edward Shishkin
2015-07-05 13:08 ` Ivan Shapovalov
2015-07-05 13:46 ` Edward Shishkin
2015-07-05 15:11 ` Ivan Shapovalov
2015-07-05 15:43 ` Edward Shishkin
[not found] ` <CADW=+3=J7Rt1yxtTfW=ZCLC40-D1FPCFR7KGSyp_YLgcRcH3FQ@mail.gmail.com>
2015-07-05 15:13 ` Ivan Shapovalov
2015-07-06 8:56 ` Edward Shishkin
2016-02-09 17:53 ` Edward Shishkin
2016-02-10 4:04 ` Ivan Shapovalov
2016-02-10 9:01 ` Edward Shishkin
2016-04-06 16:54 ` Ivan Shapovalov
2016-04-06 18:03 ` Edward Shishkin
2015-07-04 18:06 ` Ivan Shapovalov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=559245B3.1020804@gmail.com \
--to=edward.shishkin@gmail.com \
--cc=intelfx100@gmail.com \
--cc=reiserfs-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).