* [PATCH] reiser4: fix supported flags check in reiser4_rename2_common().
@ 2015-09-14 2:21 Ivan Shapovalov
2015-09-14 7:55 ` Edward Shishkin
0 siblings, 1 reply; 2+ messages in thread
From: Ivan Shapovalov @ 2015-09-14 2:21 UTC (permalink / raw)
To: reiserfs-devel; +Cc: Edward Shishkin, Ivan Shapovalov
---
This was left behind some time ago. I've just spotted a relevant warning.
fs/reiser4/plugin/inode_ops_rename.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/reiser4/plugin/inode_ops_rename.c b/fs/reiser4/plugin/inode_ops_rename.c
index 6744e14..ddb7bf5 100644
--- a/fs/reiser4/plugin/inode_ops_rename.c
+++ b/fs/reiser4/plugin/inode_ops_rename.c
@@ -435,7 +435,7 @@ int reiser4_rename2_common(struct inode *old_dir /* directory where @old
* We support:
* - RENAME_NOREPLACE (no-op)
*/
- if (flags & supported_flags != flags)
+ if ((flags & supported_flags) != flags)
return RETERR(-EINVAL);
old_entry = kzalloc(3 * sizeof(*old_entry) + 2 * sizeof(*new_lh) +
--
2.5.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] reiser4: fix supported flags check in reiser4_rename2_common().
2015-09-14 2:21 [PATCH] reiser4: fix supported flags check in reiser4_rename2_common() Ivan Shapovalov
@ 2015-09-14 7:55 ` Edward Shishkin
0 siblings, 0 replies; 2+ messages in thread
From: Edward Shishkin @ 2015-09-14 7:55 UTC (permalink / raw)
To: Ivan Shapovalov, reiserfs-devel
OK
On 09/14/2015 04:21 AM, Ivan Shapovalov wrote:
> ---
>
> This was left behind some time ago. I've just spotted a relevant warning.
>
> fs/reiser4/plugin/inode_ops_rename.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/reiser4/plugin/inode_ops_rename.c b/fs/reiser4/plugin/inode_ops_rename.c
> index 6744e14..ddb7bf5 100644
> --- a/fs/reiser4/plugin/inode_ops_rename.c
> +++ b/fs/reiser4/plugin/inode_ops_rename.c
> @@ -435,7 +435,7 @@ int reiser4_rename2_common(struct inode *old_dir /* directory where @old
> * We support:
> * - RENAME_NOREPLACE (no-op)
> */
> - if (flags & supported_flags != flags)
> + if ((flags & supported_flags) != flags)
> return RETERR(-EINVAL);
>
> old_entry = kzalloc(3 * sizeof(*old_entry) + 2 * sizeof(*new_lh) +
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-09-14 7:55 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-09-14 2:21 [PATCH] reiser4: fix supported flags check in reiser4_rename2_common() Ivan Shapovalov
2015-09-14 7:55 ` Edward Shishkin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).