From: Mike Marshall <hubcap@omnibond.com>
To: Mark Salyzyn <salyzyn@android.com>
Cc: Latchesar Ionkov <lucho@ionkov.net>,
Hugh Dickins <hughd@google.com>, James Morris <jmorris@namei.org>,
Christoph Hellwig <hch@infradead.org>,
devel@lists.orangefs.org, Eric Van Hensbergen <ericvh@gmail.com>,
Joel Becker <jlbec@evilplan.org>,
Anna Schumaker <anna.schumaker@netapp.com>,
Trond Myklebust <trond.myklebust@hammerspace.com>,
Mathieu Malaterre <malat@debian.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
LKML <linux-kernel@vger.kernel.org>, Jan Kara <jack@suse.com>,
Casey Schaufler <casey@schaufler-ca.com>,
Andrew Morton <akpm@linux-foundation.org>,
Dave Kleikamp <shaggy@kernel.org>,
linux-doc@vger.kernel.org, Jeff Layton <jlayton@kernel.org>,
Chao Yu <yuchao0@huawei.com>, Mimi Zohar <zohar@linux.ibm.com>,
linux-cifs@vger.kernel.org, Paul Moore <paul@paul-moore.com>,
"Darrick J. Wong" <darrick.wong@oracle.com>,
Eric Sandeen <sandeen@sandeen.net>,
kernel
Subject: Re: [PATCH v8] Add flags option to get xattr method paired to __vfs_getxattr
Date: Thu, 29 Aug 2019 21:24:38 -0400 [thread overview]
Message-ID: <CAOg9mSTCC4Z3RpEyppC50B+pnSBbV0sr-F7hbsM-B+z3c-AZVA@mail.gmail.com> (raw)
In-Reply-To: <5dd09a38-fffb-36f2-505b-be2ddf6bb750@android.com>
I added this patch series on top of Linux 5.3-rc6 and ran xfstests
on orangefs with no regressions.
Acked-by: Mike Marshall <hubcap@omnibond.com>
-Mike
On Wed, Aug 28, 2019 at 10:40 AM Mark Salyzyn <salyzyn@android.com> wrote:
>
> On 8/28/19 7:24 AM, Christoph Hellwig wrote:
> > On Tue, Aug 27, 2019 at 08:05:15AM -0700, Mark Salyzyn wrote:
> >> Replace arguments for get and set xattr methods, and __vfs_getxattr
> >> and __vfs_setaxtr functions with a reference to the following now
> >> common argument structure:
> > Yikes. That looks like a mess. Why can't we pass a kernel-only
> > flag in the existing flags field for â‚‹>set and add a flags field
> > to ->get? Passing methods by structure always tends to be a mess.
>
> This was a response to GregKH@ criticism, an earlier patch set just
> added a flag as you stated to get method, until complaints of an
> excessively long argument list and fragility to add or change more
> arguments.
>
> So many ways have been tried to skin this cat ... the risk was taken to
> please some, and we now have hundreds of stakeholders, when the first
> patch set was less than a dozen. A recipe for failure?
>
> -- Mark
>
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
prev parent reply other threads:[~2019-08-30 1:24 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-27 15:05 [PATCH v8] Add flags option to get xattr method paired to __vfs_getxattr Mark Salyzyn via Linux-f2fs-devel
2019-08-27 15:49 ` Jeff Layton
2019-08-27 17:07 ` David Sterba
2019-08-27 21:35 ` Darrick J. Wong
2019-08-28 14:24 ` Christoph Hellwig
2019-08-28 14:40 ` Mark Salyzyn via Linux-f2fs-devel
2019-08-30 1:24 ` Mike Marshall [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAOg9mSTCC4Z3RpEyppC50B+pnSBbV0sr-F7hbsM-B+z3c-AZVA@mail.gmail.com \
--to=hubcap@omnibond.com \
--cc=akpm@linux-foundation.org \
--cc=anna.schumaker@netapp.com \
--cc=casey@schaufler-ca.com \
--cc=darrick.wong@oracle.com \
--cc=devel@lists.orangefs.org \
--cc=ericvh@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=hch@infradead.org \
--cc=hughd@google.com \
--cc=jack@suse.com \
--cc=jlayton@kernel.org \
--cc=jlbec@evilplan.org \
--cc=jmorris@namei.org \
--cc=linux-cifs@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lucho@ionkov.net \
--cc=malat@debian.org \
--cc=paul@paul-moore.com \
--cc=salyzyn@android.com \
--cc=sandeen@sandeen.net \
--cc=shaggy@kernel.org \
--cc=trond.myklebust@hammerspace.com \
--cc=yuchao0@huawei.com \
--cc=zohar@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).