From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexander Beregalov Subject: Re: [PATCH 0/4] kill-the-bkl/reiserfs: fix some lock dependency inversions Date: Tue, 15 Sep 2009 01:33:42 +0400 Message-ID: References: <1251167570-5233-1-git-send-email-fweisbec@gmail.com> <20090826201330.GA18761@orion> <20090914203749.GF6045@nowhere> Mime-Version: 1.0 Return-path: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :date:message-id:subject:from:to:cc:content-type; bh=rzy2wUg5RAAFliTzn9tSaKj+iWYtkoJ+7YZjujU9Hqg=; b=S6aykHS7b89uW8G2wUzAyjEDZ2GsDZqhsw+QWZWWQpveqDBG0eUC6ZDfTecUOlc9sp xBa0fMPBxXYdP7RtEMmW7Ntjn4wevHcTAVNhPKMB8ARg2aFIzQmFsvCugL3e/qTRA5Mz I4P86NVgLnXuRzIhEg1sPjEHmTbX9kcwzkRpU= In-Reply-To: <20090914203749.GF6045@nowhere> Sender: reiserfs-devel-owner@vger.kernel.org List-ID: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Frederic Weisbecker Cc: LKML , Reiserfs > Hi Alexander, > > It should be fixed now, still in the following tree: Hi! Another one, similar: It is v2.6.31-3123-g99bc470 plus your 805031859(kill-the-bkl/reiserfs: panic in case of lock imbalance), UP. ======================================================= [ INFO: possible circular locking dependency detected ] 2.6.31-03149-gdcc030a #1 ------------------------------------------------------- udevadm/716 is trying to acquire lock: (&mm->mmap_sem){++++++}, at: [] might_fault+0x4a/0xa0 but task is already holding lock: (sysfs_mutex){+.+.+.}, at: [] sysfs_readdir+0x5a/0x200 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #3 (sysfs_mutex){+.+.+.}: [] __lock_acquire+0xd0e/0x15c0 [] lock_acquire+0x7a/0xa0 [] __mutex_lock_common+0x46/0x310 [] mutex_lock_nested+0x3a/0x50 [] sysfs_addrm_start+0x2c/0xa0 [] create_dir+0x40/0x90 [] sysfs_create_dir+0x2b/0x40 [] kobject_add_internal+0x9b/0x250 [] kobject_add_varg+0x2d/0x50 [] kobject_add+0x2c/0x60 [] device_add+0xf4/0x4a0 [] add_partition+0x13f/0x230 [] rescan_partitions+0x24b/0x3c0 [] __blkdev_get+0x140/0x320 [] blkdev_get+0xa/0x10 [] register_disk+0x127/0x140 [] add_disk+0x80/0x140 [] sd_probe_async+0xf8/0x1b0 [] async_thread+0xd1/0x220 [] kthread+0x6c/0x80 [] kernel_thread_helper+0x7/0x18 -> #2 (&bdev->bd_mutex){+.+.+.}: [] __lock_acquire+0xd0e/0x15c0 [] lock_acquire+0x7a/0xa0 [] __mutex_lock_common+0x46/0x310 [] mutex_lock_nested+0x3a/0x50 [] __blkdev_get+0x2a/0x320 [] blkdev_get+0xa/0x10 [] open_by_devnum+0x21/0x50 [] journal_init+0x1d7/0xa10 [] reiserfs_fill_super+0x313/0xdb0 [] get_sb_bdev+0x108/0x150 [] get_super_block+0x21/0x30 [] vfs_kern_mount+0x40/0xa0 [] do_kern_mount+0x39/0xd0 [] do_mount+0x309/0x700 [] sys_mount+0x66/0xa0 [] mount_block_root+0xc4/0x245 [] mount_root+0x59/0x5f [] prepare_namespace+0x111/0x14b [] kernel_init+0xca/0xd6 [] kernel_thread_helper+0x7/0x18 -> #1 (&REISERFS_SB(s)->lock){+.+.+.}: [] __lock_acquire+0xd0e/0x15c0 [] lock_acquire+0x7a/0xa0 [] __mutex_lock_common+0x46/0x310 [] mutex_lock_nested+0x3a/0x50 [] reiserfs_write_lock_once+0x28/0x50 [] reiserfs_get_block+0x5c/0x1440 [] do_mpage_readpage+0x120/0x4b0 [] mpage_readpages+0x9f/0xe0 [] reiserfs_readpages+0x19/0x20 [] __do_page_cache_readahead+0x195/0x210 [] ra_submit+0x21/0x30 [] filemap_fault+0x2e9/0x380 [] __do_fault+0x38/0x3b0 [] handle_mm_fault+0xcd/0x550 [] do_page_fault+0xf5/0x240 [] error_code+0x63/0x68 [] padzero+0x24/0x40 [] load_elf_binary+0x61a/0x1450 [] search_binary_handler+0x90/0x270 [] do_execve+0x1d2/0x240 [] sys_execve+0x28/0x60 [] syscall_call+0x7/0xb -> #0 (&mm->mmap_sem){++++++}: [] __lock_acquire+0x1125/0x15c0 [] lock_acquire+0x7a/0xa0 [] might_fault+0x7b/0xa0 [] copy_to_user+0x36/0x130 [] filldir64+0xa9/0xf0 [] sysfs_readdir+0xfe/0x200 [] vfs_readdir+0x85/0xa0 [] sys_getdents64+0x64/0xb0 [] sysenter_do_call+0x12/0x36 other info that might help us debug this: 2 locks held by udevadm/716: #0: (&type->i_mutex_dir_key){+.+.+.}, at: [] vfs_readdir+0x52/0xa0 #1: (sysfs_mutex){+.+.+.}, at: [] sysfs_readdir+0x5a/0x200 stack backtrace: Pid: 716, comm: udevadm Tainted: G W 2.6.31-03149-gdcc030a #1 Call Trace: [] ? printk+0x18/0x1e [] print_circular_bug+0xc0/0xd0 [] __lock_acquire+0x1125/0x15c0 [] lock_acquire+0x7a/0xa0 [] ? might_fault+0x4a/0xa0 [] might_fault+0x7b/0xa0 [] ? might_fault+0x4a/0xa0 [] copy_to_user+0x36/0x130 [] filldir64+0xa9/0xf0 [] ? filldir64+0x0/0xf0 [] sysfs_readdir+0xfe/0x200 [] ? filldir64+0x0/0xf0 [] ? filldir64+0x0/0xf0 [] vfs_readdir+0x85/0xa0 [] sys_getdents64+0x64/0xb0 [] sysenter_do_call+0x12/0x36