* Re: [PATCHv2 00/12]posix_acl: Add the check items [not found] <4B2F6153.8010609@gmail.com> @ 2009-12-21 12:36 ` Christoph Hellwig 2009-12-21 12:36 ` Christoph Hellwig [not found] ` <20091221123654.GA9201@lst.de> 2 siblings, 0 replies; 3+ messages in thread From: Christoph Hellwig @ 2009-12-21 12:36 UTC (permalink / raw) To: Liuwenyi Cc: adilger, jack, neilb, jeffm, bfields, linux-mtd, onlyflyer, hch, tiger.yang, strongzgy, ffilzlnx, sandeen, jmorris, cluster-devel, aelder, cjb, bharrosh, reiserfs-devel, xfs, xfs-masters, viro, chris.mason, linux-nfs, linux-ext4, tytso, akpm, linux-kernel, linux-btrfs, linux-fsdevel, serue, dwmw2, ocfs2-devel I like taking these checks into posix_acl_valid, but I think the patch submission needs a bit more work. All the patches are extremly whitespace mangled. And I don't think splitting them up makes a whole lot of sense, when we do API changes like this we usually fix up all callers. So please try to fix your mailer, merged them all into one, and maybe also chose a more descriptive subject line, e.g. Subject: take checks for NULL and error pointers into posix_acl_valid() And btw, at least the XFS change seems incorrect - previously we returned NULL acl pointer and this patch changes it to -EINVAL. ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCHv2 00/12]posix_acl: Add the check items [not found] <4B2F6153.8010609@gmail.com> 2009-12-21 12:36 ` [PATCHv2 00/12]posix_acl: Add the check items Christoph Hellwig @ 2009-12-21 12:36 ` Christoph Hellwig [not found] ` <20091221123654.GA9201@lst.de> 2 siblings, 0 replies; 3+ messages in thread From: Christoph Hellwig @ 2009-12-21 12:36 UTC (permalink / raw) To: Liuwenyi Cc: adilger, jack, neilb, jeffm, joel.becker, bfields, linux-mtd, onlyflyer, hch, tiger.yang, strongzgy, ffilzlnx, sandeen, jmorris, cluster-devel, aelder, cjb, mfasheh, bharrosh, reiserfs-devel, xfs, xfs-masters, viro, swhiteho, chris.mason, linux-nfs, linux-ext4, tytso, akpm, linux-kernel, linux-btrfs, linux-fsdevel, serue, dwmw2, ocfs2-devel I like taking these checks into posix_acl_valid, but I think the patch submission needs a bit more work. All the patches are extremly whitespace mangled. And I don't think splitting them up makes a whole lot of sense, when we do API changes like this we usually fix up all callers. So please try to fix your mailer, merged them all into one, and maybe also chose a more descriptive subject line, e.g. Subject: take checks for NULL and error pointers into posix_acl_valid() And btw, at least the XFS change seems incorrect - previously we returned NULL acl pointer and this patch changes it to -EINVAL. _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs ^ permalink raw reply [flat|nested] 3+ messages in thread
[parent not found: <20091221123654.GA9201@lst.de>]
* Re: [PATCHv2 00/12]posix_acl: Add the check items [not found] ` <20091221123654.GA9201@lst.de> @ 2009-12-21 14:15 ` liu weni 0 siblings, 0 replies; 3+ messages in thread From: liu weni @ 2009-12-21 14:15 UTC (permalink / raw) To: Christoph Hellwig Cc: chris.mason, viro, joel.becker, cjb, jmorris, serue, akpm, adilger, jack, tytso, dwmw2, swhiteho, bfields, neilb, ffilzlnx, bharrosh, mfasheh, tiger.yang, jeffm, aelder, sandeen, xfs-masters, xfs, reiserfs-devel, ocfs2-devel, linux-nfs, linux-ext4, linux-btrfs, linux-fsdevel, linux-kernel, cluster-devel, linux-mtd, strongzgy, onlyflyer Thanks for your suggestion. In my opinion the null point is a incorrect state for the acl, then I return -EINVAL. I will check this state transition in XFS. 2009/12/21 Christoph Hellwig <hch@lst.de>: > I like taking these checks into posix_acl_valid, but I think the patch > submission needs a bit more work. > > All the patches are extremly whitespace mangled. And I don't think > splitting them up makes a whole lot of sense, when we do API changes > like this we usually fix up all callers. So please try to fix your > mailer, merged them all into one, and maybe also chose a more > descriptive subject line, e.g. > > Subject: take checks for NULL and error pointers into posix_acl_valid() > > > And btw, at least the XFS change seems incorrect - previously we > returned NULL acl pointer and this patch changes it to -EINVAL. > > -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2009-12-21 14:15 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <4B2F6153.8010609@gmail.com>
2009-12-21 12:36 ` [PATCHv2 00/12]posix_acl: Add the check items Christoph Hellwig
2009-12-21 12:36 ` Christoph Hellwig
[not found] ` <20091221123654.GA9201@lst.de>
2009-12-21 14:15 ` liu weni
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).