From: Igor Korotin <igor.korotin.linux@gmail.com>
To: Danilo Krummrich <dakr@kernel.org>
Cc: "Miguel Ojeda" <ojeda@kernel.org>,
"Alex Gaynor" <alex.gaynor@gmail.com>,
"Boqun Feng" <boqun.feng@gmail.com>,
"Gary Guo" <gary@garyguo.net>,
"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
"Benno Lossin" <lossin@kernel.org>,
"Andreas Hindborg" <a.hindborg@kernel.org>,
"Alice Ryhl" <aliceryhl@google.com>,
"Trevor Gross" <tmgross@umich.edu>,
rust-for-linux@vger.kernel.org,
"Wolfram Sang" <wsa+renesas@sang-engineering.com>
Subject: Re: [PATCH v3 1/3] rust: i2c: add basic I2C device and driver abstractions
Date: Mon, 4 Aug 2025 15:58:36 +0100 [thread overview]
Message-ID: <08e89f95-6c95-4998-988c-e25f3cbfb389@gmail.com> (raw)
In-Reply-To: <DBRI0B7BXRS4.3RUOC5ARVETE1@kernel.org>
Hello Danilo
On 8/2/25 01:00, Danilo Krummrich wrote:
> (Cc: Wolfram)
>
> On Fri Aug 1, 2025 at 5:40 PM CEST, Igor Korotin wrote:
>> Implement the core abstractions needed for I2C drivers, including:
>>
>> * `i2c::Driver` — the trait drivers must implement, including `probe`
>>
>> * `i2c::Device` — a safe wrapper around `struct i2c_client`
>>
>> * `i2c::Adapter` — implements `driver::RegistrationOps` to hook into the
>> generic `driver::Registration` machinery
>>
>> * `i2c::DeviceId` — a `RawDeviceIdIndex` implementation for I2C device IDs
>>
>> Signed-off-by: Igor Korotin <igor.korotin.linux@gmail.com>
>> ---
>> MAINTAINERS | 7 +
>> rust/bindings/bindings_helper.h | 1 +
>> rust/kernel/i2c.rs | 391 ++++++++++++++++++++++++++++++++
>> rust/kernel/lib.rs | 2 +
>> 4 files changed, 401 insertions(+)
>> create mode 100644 rust/kernel/i2c.rs
>>
>> diff --git a/MAINTAINERS b/MAINTAINERS
>> index 4f03e230f3c5..767beaa0f7c2 100644
>> --- a/MAINTAINERS
>> +++ b/MAINTAINERS
>> @@ -11514,6 +11514,13 @@ F: include/linux/i2c.h
>> F: include/uapi/linux/i2c-*.h
>> F: include/uapi/linux/i2c.h
>>
>> +I2C SUBSYSTEM [RUST]
>
> Has this been agreed with Wolfram off-list? (I'm asking since I haven't seen a
> reply from him in v2.)
>
> In case you just did not receive an answer yet, it's fine to proceed with a
> proposal as you do here. However, please make sure to keep Wolfram in the loop.
> :)
>
> In either case, which tree should patches flow through?
>
>> +M: Igor Korotin <igor.korotin.linux@gmail.com>
>> +R: Danilo Krummrich <dakr@kernel.org>
>
> If you'd like me to keep an eye on this as well, this is fine with me.
>
Yeah. I really need your help if you don't mind. Thanks.
Could you also briefly tell me finally which tree for patches should I
use, how do I do it and if I need to represent it in the MAINTAINERS
file somehow?
Thanks a lot for your help and review.
Best Regards
Igor
next prev parent reply other threads:[~2025-08-04 14:58 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-01 15:37 [PATCH v3 0/3] rust: i2c: Add basic I2C driver abstractions Igor Korotin
2025-08-01 15:40 ` [PATCH v3 1/3] rust: i2c: add basic I2C device and " Igor Korotin
2025-08-01 17:14 ` Daniel Almeida
2025-08-02 0:22 ` Danilo Krummrich
2025-08-04 14:16 ` Igor Korotin
2025-08-02 0:00 ` Danilo Krummrich
2025-08-02 9:07 ` Wolfram Sang
2025-08-02 10:51 ` Danilo Krummrich
2025-08-02 12:14 ` Wolfram Sang
2025-08-02 12:41 ` Danilo Krummrich
2025-08-04 14:58 ` Igor Korotin [this message]
2025-08-04 15:17 ` Danilo Krummrich
2025-08-04 15:24 ` Miguel Ojeda
2025-08-04 15:40 ` Igor Korotin
2025-08-04 16:11 ` Wolfram Sang
2025-08-04 17:15 ` Danilo Krummrich
2025-08-04 22:01 ` Wolfram Sang
2025-08-05 8:37 ` Igor Korotin
2025-08-05 9:28 ` Wolfram Sang
2025-08-05 12:40 ` Daniel Almeida
2025-08-04 17:26 ` Igor Korotin
2025-08-04 17:46 ` Miguel Ojeda
2025-08-04 21:57 ` Wolfram Sang
2025-08-15 15:40 ` Igor Korotin
2025-08-15 16:03 ` Danilo Krummrich
2025-08-15 17:04 ` Greg KH
2025-08-15 17:16 ` Danilo Krummrich
2025-08-01 15:44 ` [PATCH v3 2/3] rust: i2c: add manual I2C device creation abstractions Igor Korotin
2025-08-01 17:59 ` Daniel Almeida
2025-08-02 0:26 ` Danilo Krummrich
2025-08-04 14:38 ` Igor Korotin
2025-08-02 0:12 ` Danilo Krummrich
2025-08-01 15:45 ` [PATCH v3 3/3] samples: rust: add Rust I2C sample driver Igor Korotin
2025-08-01 18:09 ` Daniel Almeida
2025-08-04 14:43 ` Igor Korotin
2025-08-04 14:58 ` Daniel Almeida
2025-08-02 0:18 ` Danilo Krummrich
2025-08-07 8:42 ` kernel test robot
2025-08-04 15:07 ` [PATCH v3 0/3] rust: i2c: Add basic I2C driver abstractions Daniel Almeida
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=08e89f95-6c95-4998-988c-e25f3cbfb389@gmail.com \
--to=igor.korotin.linux@gmail.com \
--cc=a.hindborg@kernel.org \
--cc=alex.gaynor@gmail.com \
--cc=aliceryhl@google.com \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=dakr@kernel.org \
--cc=gary@garyguo.net \
--cc=lossin@kernel.org \
--cc=ojeda@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=tmgross@umich.edu \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).