From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on2047.outbound.protection.outlook.com [40.107.92.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 678B82918CD; Tue, 22 Apr 2025 16:23:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.92.47 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745339015; cv=fail; b=O81LP3Fj2NDqJsevy8P99+jIxp8yp7JgQ3rierhOulS7tRMlRFX00LTP3WC5/9w1avvvCPwFy1+6GnZ6feCv8NjAZPpapkE7DdYGxQGNO3Fogv56GsbgiXEPZCp8wUECouw/bkWVXZeDBjYDTaQay2CBWIVYugt/lGw+K8ne87c= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745339015; c=relaxed/simple; bh=40TVBh2sJKjcHMG7kgkRfk2MCs6zsULOTMMzqXzfGcQ=; h=Message-ID:Date:Subject:To:Cc:References:From:In-Reply-To: Content-Type:MIME-Version; b=u/vlK6QiSPD88n/5Rf2kwDeZq0/NRok+P9VXGKuREHTBrmWcf+SKmxC+a2V+NzJO/0XThh0smpO7dRnQpyto0oLuBwVHVBd3G/Ualo4pkBvByA+7Reirsy396pZiWlnoMxe0mq8ghSPI+ZMkB/3wNS3rouDeecdgii8ZTY4coGo= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=kZhlkwbU; arc=fail smtp.client-ip=40.107.92.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="kZhlkwbU" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=N6A5AMslAraCq8LVOrBeeUrrzc9D6/Y1fKlhwL82OtSgQrPpMFPFbf4/hhqfKSLmvStZKj1Ls2lgbca51vNUwI6ICWgR7yjSHMSH3f+CPnWQVD7og17qYOW3qddRghpPq0oyf3QfAua15h1WAukO79mfRr8WYzfaiypTQjARaqvoMuyYXsWo/eV1gVbFtjXfa3CFs62BRKNlIrDLKaSSqNB/micn8xl9Rew5g6QuxM8QMVruIC1Y71Pvc6IDwNBRahEgyvkoAtw1y7yuhmtT2XAEO4xWU3NjWTYjspfP8wxWyNytC+ak2m6qIrWx9b/FzifXwaFaEz9AzGNNzj8PqQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=A9eVgf9fKPOdIc3ibdPT9ro1rTFDaulxOaHnSny9x6c=; b=MriWVjoRoNuo721tUeuSyRm14Z+NMS8tKFOXqHrKWGhUV2gSEjxUMjby0Q7eCm3y1GkMez/nrgdFjMggBVp/7KcOSrms0DCPJY8IfkdytfvgFWGgmnnv0ad9xa4z67YNB/ejPNS+kNeTAfYfadFacH5XMis5p9pzzope6qNu2t1wDUCh5iNrQ0zTq3vfPwTgFVf3mHRGxSTeKJTNSEfsg6qGxD2HZmFIi+7x7eu0XSsUdVDjWf9hqvEWpCGepfuRegnmVhgfhvGtEL48hcYosMOULwBnBLdg7RkTar1uhbSUD7WOlzR68p0eyiL7l7C/lDpRCuMZUX5Em59iiLKbnw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=A9eVgf9fKPOdIc3ibdPT9ro1rTFDaulxOaHnSny9x6c=; b=kZhlkwbU9iRpLvMwsRP7Suv9VGdyseeBQ4bIhab+7ZW3+ls8FiG1DCWv0DCDCfZN7xpHzxw7NZi3b7JTeChHgc3c56XhchALUK8cTh/in4uaywk/p5/gVm+2CBbSGzCMsK6GBbqJWYEeYF63i6xA1VNf9yEjRMjpvs2T51Qr0ZIQMUb4x6H1fchG5+PvEiEvRC/fdK+Sx959bFIZzd3l5IqXmggy9Wf6/mi9NsvsTI8+VG+j/MnAkNZJInhySWRjwnWCwHlUzkQO3GHJp4hH/remMfS1QRk4z10Bg7qRYRvXxuR08gZAVjn1wh49Uu/6YX03JIvVlqRL3ThohfvhIg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from SN7PR12MB8059.namprd12.prod.outlook.com (2603:10b6:806:32b::7) by DS7PR12MB8371.namprd12.prod.outlook.com (2603:10b6:8:e9::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8655.36; Tue, 22 Apr 2025 16:23:28 +0000 Received: from SN7PR12MB8059.namprd12.prod.outlook.com ([fe80::4ee2:654e:1fe8:4b91]) by SN7PR12MB8059.namprd12.prod.outlook.com ([fe80::4ee2:654e:1fe8:4b91%6]) with mapi id 15.20.8655.033; Tue, 22 Apr 2025 16:23:28 +0000 Message-ID: <0d5e7a8a-c272-4652-ad03-229384bbbc95@nvidia.com> Date: Tue, 22 Apr 2025 12:23:26 -0400 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 03/16] gpu: nova-core: derive useful traits for Chipset To: Alexandre Courbot , Miguel Ojeda , Alex Gaynor , Boqun Feng , Gary Guo , =?UTF-8?Q?Bj=C3=B6rn_Roy_Baron?= , Benno Lossin , Andreas Hindborg , Alice Ryhl , Trevor Gross , Danilo Krummrich , David Airlie , Simona Vetter , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Jonathan Corbet Cc: John Hubbard , Ben Skeggs , Timur Tabi , Alistair Popple , linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org, nouveau@lists.freedesktop.org, dri-devel@lists.freedesktop.org References: <20250420-nova-frts-v1-0-ecd1cca23963@nvidia.com> <20250420-nova-frts-v1-3-ecd1cca23963@nvidia.com> Content-Language: en-US From: Joel Fernandes In-Reply-To: <20250420-nova-frts-v1-3-ecd1cca23963@nvidia.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: BN1PR12CA0014.namprd12.prod.outlook.com (2603:10b6:408:e1::19) To SN7PR12MB8059.namprd12.prod.outlook.com (2603:10b6:806:32b::7) Precedence: bulk X-Mailing-List: rust-for-linux@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SN7PR12MB8059:EE_|DS7PR12MB8371:EE_ X-MS-Office365-Filtering-Correlation-Id: aafb7433-3662-4973-2ad6-08dd81ba03cb X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|7416014|376014|1800799024|366016|921020; X-Microsoft-Antispam-Message-Info: =?utf-8?B?cDgwMXYwcGJRU0taNWw5eGgzdHpjYS9kTDliV21sV09ORTNCek1MZ0wrVXZy?= =?utf-8?B?WlJwbkZZbWdaazBIY2NXNnpyTjBIeEFOdHFEOFNacThybXNDbi94Ylg2UVZ2?= =?utf-8?B?Skh1SDlZc3M2UEZ4Nmg2cFgrYVhreGxaV2gxSGtvMFRJU1N2N0JlL2l2N0xu?= =?utf-8?B?cEJjQ05HQUh1aFByekdaYXRjRWpINFBML0h0RVNtbW9lVTFPby9DbUFNWjhY?= =?utf-8?B?bDdxdjBSNm1ObUx4OEJpUFV1WWZlMUxpcUcvaDNzazcyTDdXWmdVVGl6bUxV?= =?utf-8?B?ejRCQTlkMVNOUmlEQXJpUzFYQllVYTkyYVQwZjBodlJRT3d2bThLRGU0WFpa?= =?utf-8?B?OHZGNE9kZmRSK2pnWHhGM0phNlkvcCsxeUlTQTlkbi9sV0JTQUx3Tkh1MzVi?= =?utf-8?B?Zis4NnRiVkFFRVJDSGgzM2RkVnpCRFFPc1B0OEd4WkF3TkNPN21BZ3BlcTZx?= =?utf-8?B?c3VXNFhlckVWQnFhTDZTK1hPazRxQTRYTU52RzBURmFQa0hvcFR3THZNRHVB?= =?utf-8?B?dEhnNEFNbm1LblhmK29MemtnWHVRaUcraFYwWmxwYXdJL0R0ckM3WVBvV0FB?= =?utf-8?B?ejUrbzVuZlNNN3NmbHhiMjl1UldxNTVtaGhFZDZGZ1pMWW5OM3pLVXBkUU5a?= =?utf-8?B?SWl2eXU1VUswbHdJRS9WWXY3NlkzbTUvYTVwRnFHNWZSa2x0ZjZBYTB5M2xH?= =?utf-8?B?b0trd0RkVzJTZllXTW9DK3JUQVlDWkFseThlSGM1STdZMi8wbzFaUWEwRXQ0?= =?utf-8?B?OHhBc2hBUkxqT1Brbk1UOEMzRTROM1JyclJ4MGZwbFQ1Wmo2SHlSZ3NzYWVL?= =?utf-8?B?WDMwclJHVHhod1l2eHNuZEJkUWRSdVV5MGkrQThQaTAvQ2VSWE1DY0V4QjZ5?= =?utf-8?B?UURGSjRmNTZES29FcGJDWDdvaFRkdVZkaHljN2hZQTlYcVZGV0dsZENQMldP?= =?utf-8?B?NysyNUxUYlo1b3I2YmVFYXNhcnhJcUxxbHE4OEVGVmlPWjN1N2J1Smx1MURo?= =?utf-8?B?Z1d1QXJwZXducFA2OXNIaWVRQzdOMndmdnJoSWNCUmFSc1pBbnZ3Ny9tSmlN?= =?utf-8?B?a2t4QlQreVVoN2JEUXdWVjZFTnZlMk15ZlY3dlB3Z21WTDNkTmw5ZGFib3dO?= =?utf-8?B?N1IxK25YdXhPRU95ZW9VTHBRWCtqOTd0ODNXd0IxWFlYRUNnTUpwREwwcHcv?= =?utf-8?B?WE1kWkFtRHNqdHhVVnA4dDdicFI1ZHZvNDkzdXZDQ2hoVGliNWdVYmNkM2xU?= =?utf-8?B?RnRsZEhwZ3ZpS0tGYU5oTHpBbHAwWGtIb1NzZStuZnJ6MFZMV0VMTHpod3d5?= =?utf-8?B?cnlHUFl1QjBXZEt3UXlyTFRpN2pMTXUrdFNHbGF6dXJSV2hWMkpSVDlxaS9E?= =?utf-8?B?VkY4SEZQS3RXVW5pNGlrZHBJWDNhbFhMc09aZXNaUURaS0orV2pjZlVlaWpj?= =?utf-8?B?NWk5MzNwdEpKN28zMGZGRVVDYVNTd0lGd2ovcCtjcmhkcC91dFVya3NrdVJ2?= =?utf-8?B?SkVMa3REM2xJOW51bUVwSHp0aWdCT2wxeUsxRWhsODE5am9VK1NSdFVCczNi?= =?utf-8?B?V2pIN1RTblNJRnlCZFl1aDVEUUhXRmFZRzdvc2ZybnY2cWZMUDhvN05yWWNs?= =?utf-8?B?NWlMOW5scGxiS1p6VENFaklkNUpaRGhDOUh4bmtiV0ZhSld4NWh3Mkt3aGRn?= =?utf-8?B?RWhMZUxDM0dCMkFydmNnenJsVjBSZlRGZW8vbEhBaGhmT0R4cmRUSVFYOFkz?= =?utf-8?B?WlRSQU5IdU5DaEdiazZmcjFsdmJjNkJ1dk5seGVXSU5RMGhqbkxmSWNLcyth?= =?utf-8?B?dDlieWdqc3I0T2N6emZjRDhzUEwwaHFuQXcvcTR6OXR3WFdRMDE0MUY1WnNt?= =?utf-8?B?MVpIejhQMFpzSWZyZVk1czFpdDVTaUVpNzhRcU53QVJHMElIbUFXcXRCR05x?= =?utf-8?B?cVFrZFdHN3FUMFVNQjZIK21uZUl4K3ZkWU1vcVFGeG1VemQ4THA0SE56cG0w?= =?utf-8?B?RTJOZkRPVEJRPT0=?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SN7PR12MB8059.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(7416014)(376014)(1800799024)(366016)(921020);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YVJzTko5OTNDdFFvRG5aeHJwUnNMckQ4ZE5oUEg2WlVrMGhrTFNPeDArQkpn?= =?utf-8?B?WDBwcVV4MmFsQ0hnU2ZBd0hSV3JsS01lVUZEMUNJemhQWjNkOElWZDhFck95?= =?utf-8?B?MTRma1BhMjRTb3BhNEpUU1dJWUpVT0IvYUFWQ0hyMzhQaDVBZnplZFRzM1cw?= =?utf-8?B?NjRkY1k3Rkp1TllRLzdQNEJoUHFYK0g1ZWtaZ2tiK1FWS0RIS0hrWEsvWWJq?= =?utf-8?B?cDVmRS9LLzRvRjUzUnFKWFN3cWkyNTkyTUZ0dngySXNZN3FCK1o5T3lhM2NX?= =?utf-8?B?cXNUNVFFZnVQRnlIcGVxRzZYV296Z2FFcGM0TjMwUkVSOXN6NzUxZ2huQ0Fj?= =?utf-8?B?dlFkck9BaVZhVWlwWjZZU3M5dGVXVFdGSXFQUEdES0VsTDViMzBkY3M4QnVs?= =?utf-8?B?TGtKWTV1OXJTTHFDbjR0Y1FiVlVjbXBrWEg0U1B5VDczTHF0MS9vajNGT0NY?= =?utf-8?B?ekJGUjBDQjVsa0lrNEtNenQxYmp0ZVh2eThTLzFLdXFnYmVjM1JuVzJZZ3hk?= =?utf-8?B?NGtVYVdJWE1pNExFT3lUK1NEeFU3NFI5MjlZR0RKVE0wWUl3SkdOM3N2Z0VD?= =?utf-8?B?aFdtV1ZSU2xoblNtajVCSUs0bWZ6VUxhdTExZmxSUE9EUHJBV0lWbjAzYmUz?= =?utf-8?B?ZmRwM0djR2UvTVplcG9qdmJvVGVlNEJlZEFKWmpmMVNqUHhlK3BWY0dnQnlJ?= =?utf-8?B?ay9LZTI1MUtnSG9FZnhNeWtIZTFYdml3cXBOUldsSThWMzRZSDF2UE1ac1pk?= =?utf-8?B?b2FpbXlHbzdCTVIvYUhMSlh5bzZRZnliVTBWK3dYNW92WnFSRU54OEViVUFx?= =?utf-8?B?cTZmMTlnMUxDd1EzUGFlbjcxc0g5c1N2ek05MnpxQmRPY3hsV2c4TXRNdUpa?= =?utf-8?B?U0hmRVJlbjY1ZGxuVVVUbDdadVMxYzNGK1BFODJOZ1lacmw1RFBWYVlYUDJV?= =?utf-8?B?eGtaYjQzMjNPZXBIWkZZV0NIQnFCWi9OeWd2RnlKVzZFTWZ3R0pxUzBBZDBh?= =?utf-8?B?ZnBRM1k4UGZTcldMVklSdTdSU0dPMnFwYlF5VkRmQktDeUJiaDFkbzZsaEpH?= =?utf-8?B?M3Y4Q2NEVEVBYllNNDlCYzBpck9rNDNXdU5XK1N6L3NwUEtTK2tzV2ZCa0ps?= =?utf-8?B?SjA1dUdkcGlsWlJqeVV3UmxOQTlBZnlYWmZ3YmE4WUxTbFpYRzZVQmFQTE4r?= =?utf-8?B?eTNyRi8rcGU1ZzA5K2s2c3FCUFgwUUNwb0M5aDE4WkF6Y2NISGVCL2FoeGt2?= =?utf-8?B?UHRpSElpLzZ4cjZVOHE3RWtCSkZIU3o1T2s2SHVibzgxb1dFZ1BpUlA1QVlH?= =?utf-8?B?eVgza2lIdWtYVjAzNUw0YXk5RkYxM0QvUzI5YXBGT2x2SkxxWWsrblZuWXJa?= =?utf-8?B?VnBZQzFpWVBKM1VrQVhYUFNLN09tdjIrWGYzeUhmVjNxRy91QUdrMUl5VEox?= =?utf-8?B?RytENWxoYXJhQTNWYWQ1VHM3Z2lzRHpkSzlIYjhsZTNPaUk1T21HV3JDSGZB?= =?utf-8?B?M2VEMWxvS2huVXBtS1JwbjR5Tm93MmV6TGJiTUhReXE5cGJCb0x3dDBxL2JR?= =?utf-8?B?aGRMc0x0dWovMm5USWxWbjVXcytTM1BZVGRUbGxnMDlUT3VPamxiekNWdC9o?= =?utf-8?B?QzNseDh5a1NjMitHVTRyYUZ0NUNtZTNlQjFWS0VUSTNwV0hHdmpVQm5aV0VO?= =?utf-8?B?RWpwTUFSajNrK3I0MjFSWThwVkNIV2R3d3pMeDlOQnZQRlhmZ2RIckpSZ21T?= =?utf-8?B?cG9sbnNFVUdiNSttREpOQWFHK2VYZi9VbVQzSTVybXNaN2M1SmhnNXYyNmFz?= =?utf-8?B?VEU5VmNmR2puUUdEVm9MRzFnbUdmWjZqRm1ZclVHaTd1NWRrWDJCTTkxY3hx?= =?utf-8?B?TG5vOGNxSGtpRkFuY2VPYWoreksyelNhVnRMbjdWUTRuS0dXaUpkQVhpVDN2?= =?utf-8?B?UUJud2ZwMUFmN0NsQjA0dGsweVhpbjFpYjRJWDdUZEVRd1NMVFZlZ1o2RHdq?= =?utf-8?B?cllNbVQ0TUhTYlZQWnVpWmJEQWhvYUJDR0I5K2tvWHR1M2o1c05HTjF1am1q?= =?utf-8?B?MFhIVGJRUVpqeVpaVHRWd0hmbEREV20rWCs1RWVZQXd4VUk4TEoxYmptcWRE?= =?utf-8?Q?Xxgf8TGbtXgjXmFgBLR4gmXSh?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: aafb7433-3662-4973-2ad6-08dd81ba03cb X-MS-Exchange-CrossTenant-AuthSource: SN7PR12MB8059.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Apr 2025 16:23:28.5961 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: rh/BKvv4h3SWvecGEjVa687O+fQUPQJ7AVzdbU7Eq4U2yL88pRPGbPUD7WQnGKRxS9vnXlJyqvqXxpL7FCLELA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR12MB8371 On 4/20/2025 8:19 AM, Alexandre Courbot wrote: > We will commonly need to compare chipset versions, so derive the > ordering traits to make that possible. Also derive Copy and Clone since > passing Chipset by value will be more efficient than by reference. > > Signed-off-by: Alexandre Courbot > --- > drivers/gpu/nova-core/gpu.rs | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/nova-core/gpu.rs b/drivers/gpu/nova-core/gpu.rs > index 17c9660da45034762edaa78e372d8821144cdeb7..4de67a2dc16302c00530026156d7264cbc7e5b32 100644 > --- a/drivers/gpu/nova-core/gpu.rs > +++ b/drivers/gpu/nova-core/gpu.rs > @@ -13,7 +13,7 @@ macro_rules! define_chipset { > ({ $($variant:ident = $value:expr),* $(,)* }) => > { > /// Enum representation of the GPU chipset. > - #[derive(fmt::Debug)] > + #[derive(fmt::Debug, Copy, Clone, PartialOrd, Ord, PartialEq, Eq)] Since Ord implies PartialOrd, do you need both? Same for Eq. Also under which scenario does Chipset require PartialOrd? thanks, - Joel > pub(crate) enum Chipset { > $($variant = $value),*, > } >