From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com [209.85.128.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 280161FFC59 for ; Sun, 26 Oct 2025 15:50:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761493807; cv=none; b=igiGqD8CJbAzn1U+5tLVIt9/OvsB6X+3Ik48mnsNrJmFWpc8g50yN+l7iAXmRyrvWuqW2qrvJQNSFzAwRRojRdtY7HXjWp7a6NNBJmYsPy7EdVxws7+uVvAxDfblIsG97Hl67J5Kzrpd/KhtZeh+bl+97ZPZUv8BM6sYG4VVoU0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761493807; c=relaxed/simple; bh=BxE4AMPL/vcJ70cwNaercB49PFvdWpZrZz54n4I+Tss=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=DZ2ZfPOu9eOCrjeJSK09s6L2CTnYIaKbc8k+7BbXsrHWopV6Sxx5NFVBxX6mO5Vyo/Y9RPPrdfHpDRebHS+52vLcKjtmm9+K78v4HqGZAisuJ2HroZAJ+CNaxTlNw/Li41C4tgvqudJR/EzorBJYejGtcmxxU2jWejq6rZQ+REo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=WbhP5d2d; arc=none smtp.client-ip=209.85.128.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="WbhP5d2d" Received: by mail-wm1-f48.google.com with SMTP id 5b1f17b1804b1-4710022571cso39401355e9.3 for ; Sun, 26 Oct 2025 08:50:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1761493804; x=1762098604; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=AwoH7I232gTPCmP7qEpxtY2g6Hfq6kq4uW779mwS/Vc=; b=WbhP5d2duYs8xkDO7p8JdxampWS/y2CiGTizWyXKgdMfPqLCpnvV+VAsqSVeGVtH0g I3BTSqmbj9OonrEdMZhfVw5PGlQj5MnmAKq3tr1jE8aAjP1NOkUx67f5uXWlN/cuxVGa q3NmxRlFFW7woW6V86EkXkKC2dIK4LrxVADwtn6lzxIP+42J+TC8MDcFJ59ERCqMWHZ2 AAu1Xu0VU2NaHsq0hoR6Juc/cfw8EYjxPvcIJYDuxdVHKr1uXH1jX9Gi1p7PaY88V/l9 Bx6A+NDJ0sFMO2aoloiN8NGY2P+MEMIvh77xiebDeRXFWmfo3LrPj4Ccrg+TbWzUc4ck 44iQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761493804; x=1762098604; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=AwoH7I232gTPCmP7qEpxtY2g6Hfq6kq4uW779mwS/Vc=; b=mCt7QTJ8v2XIQB59/zGdVmRHRHv29cyuoXF/LQVVMPS9WVHtQ/yFMc4WM9Q+FBBv4p I8LQY3uKXCTycVHO7KpUPh8nhVhArBrRGk4p6FRhc9iLUQCDOtppVC60QFokzQ1r8IJS Njtypp684ul2fJPr0SVfVgmS0iO1a6xuM3KqncUkihv3oGt0qeDptQKejf36o1LezHg+ 9YLjS8L4Ygu9g9wMfyprYvbSoqotdEJhrVeYT2/rflK6vvw7Mr/lakg9xeVysk2NbeV1 aVRk9ESJ85MqjHpkwGUFi9I4Gy0q7riaH65Ofinn5LFSXkLgXLlwIwl+l7sRgNqQqkTD NqtQ== X-Forwarded-Encrypted: i=1; AJvYcCW9s9trN4s+yxhbungc4LVf+DZ7Fca+NN0XLyybhnEi+sfkrhYaF1rpAcEeANnJeKBqf8xT7ywyksp4sfUHLA==@vger.kernel.org X-Gm-Message-State: AOJu0Yyc8wqHMa434av903E/8HNZuQhWgHkQp3Jb2Quomt6Yk3x4/BXo Y6uQch9HfsaeAiwCqKH47OLQxh5VoO9fVT7cm8PIiIXw6JmE41dOHWKH X-Gm-Gg: ASbGncsAVumlwfKFcgiAgSO4UH7xFKOiakshgknOut8tap78lcr7Zl7JWCvkbiqRjMm cIN2cqMreySWwMDTz7uLBIEHzgshMd1kI2HX3o8+iQVnIhX7OQLo9T/msD7HvdM+H6sTPODi3vH p4Gx+P89pDUXO8OTDFwJjgVBD62PDAbJInHzDX34f5MlhGtTo4NifXwL4DAt6faQW03Nyp3Zsmo QdtYgp02JyEGMvLlDlKmxW5RYsCqQzEuuesaoltiCoB6JlPxMDWCKqp1+wAGmDv04ZXiJ+nn1BB VJt4xLkuZvWVwHbMVapKdiTxdCdhDIpwbq+zhsOdctEbFKvb8ftuFgtOWzK1TAMR8meTBvxvvBm IBDQDMhT08CMzw8zpxTNmP+eJjnIIGT27pN1CCSdfevQeI5y24znTQ88s0PDajFVban6Sn3QFkG rlJlVZqJ3iogZSEXcF7uXr4Dg+bJljiMh0nNPE0qN35GUMAmRjwClPXIvvbb3o4Q== X-Google-Smtp-Source: AGHT+IHkA2M3SX4HhxxTJ6SEKSHdbNns6ue18wHnx7W7S0nv87PUUK8aoI/2+ta3S9khmo30OxGG8Q== X-Received: by 2002:a05:600c:3e07:b0:46e:4783:1a7a with SMTP id 5b1f17b1804b1-471178705bbmr270697435e9.3.1761493804087; Sun, 26 Oct 2025 08:50:04 -0700 (PDT) Received: from ?IPV6:2a02:c7c:8b21:7400:c9e:bafa:eeb1:89f7? ([2a02:c7c:8b21:7400:c9e:bafa:eeb1:89f7]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-475de57b156sm77916985e9.13.2025.10.26.08.50.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 26 Oct 2025 08:50:03 -0700 (PDT) Message-ID: <0d8cd0ef-01bd-4996-a146-404a677ad935@gmail.com> Date: Sun, 26 Oct 2025 15:50:00 +0000 Precedence: bulk X-Mailing-List: rust-for-linux@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v6 3/3] samples: rust: add Rust I2C sample driver To: Danilo Krummrich Cc: Miguel Ojeda , Alex Gaynor , Wolfram Sang , Boqun Feng , Gary Guo , =?UTF-8?Q?Bj=C3=B6rn_Roy_Baron?= , Benno Lossin , Andreas Hindborg , Alice Ryhl , Trevor Gross , Greg Kroah-Hartman , Viresh Kumar , Asahi Lina , Wedson Almeida Filho , Alex Hung , Tamir Duberstein , Xiangfei Ding , linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org, linux-i2c@vger.kernel.org References: <20251005102226.41876-1-igor.korotin.linux@gmail.com> <20251005102348.41935-1-igor.korotin.linux@gmail.com> <72e286cb-7517-494d-a8ed-769b5fb8baee@gmail.com> <2d9a8196-8d66-4238-a807-b1ff9fd84519@kernel.org> Content-Language: en-US From: Igor Korotin In-Reply-To: <2d9a8196-8d66-4238-a807-b1ff9fd84519@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 10/26/2025 3:43 PM, Danilo Krummrich wrote: > On 10/26/25 3:06 PM, Igor Korotin wrote: >> Hello Danilo >> >> On 10/26/2025 10:48 AM, Danilo Krummrich wrote: >>> On 10/5/25 12:23 PM, Igor Korotin wrote: >>>> +impl Drop for SampleDriver { >>>> +    fn drop(&mut self) { >>>> +        dev_info!(self.idev.as_ref(), "Remove Rust I2C driver sample.\n"); >>>> +    } >>>> +} >>> >>> NIT: Please use the i2c::Driver::unbind() callback instead. >> >> Thanks for the feedback. >> I’ll move this into the i2c::Driver::unbind() callback. >> >> Should I send v7? > > For such a minor thing I can usually do it when applying the patch, but given > that for the other patch the change is a bit more significant, I'd say please > send a v7. Just for the clarification: by "the change for the other patch" you mean rebase and update this patch series based on [1], right? Thanks Igor [1] https://lore.kernel.org/all/20251016125544.15559-1-dakr@kernel.org/