Re: [PATCH v2 0/3] rust: Add irq abstraction, SpinLockIrq

[Benno Lossin <benno.lossin@proton.me>]

On 01.08.24 00:35, Lyude Paul wrote:
> This adds a simple interface for disabling and enabling CPUs, along with
> the ability to mark a function as expecting interrupts be disabled -
> along with adding bindings for spin_lock_irqsave/spin_lock_irqrestore().
> 
> Current example usecase (very much WIP driver) in rvkms:
> 
> https://gitlab.freedesktop.org/lyudess/linux/-/commits/rvkms-example-07312024
> 
> specifically drivers/gpu/drm/rvkms/crtc.rs
> 
> (The kunit tests also compile)
> 
> Lyude Paul (3):
>   rust: Introduce irq module
>   rust: sync: Introduce lock::Backend::Context
>   rust: sync: Add SpinLockIrq
> 
>  rust/helpers.c                    |  22 +++++++
>  rust/kernel/irq.rs                |  87 ++++++++++++++++++++++++
>  rust/kernel/lib.rs                |   1 +
>  rust/kernel/sync.rs               |   2 +-
>  rust/kernel/sync/lock.rs          |  17 ++++-
>  rust/kernel/sync/lock/mutex.rs    |   3 +
>  rust/kernel/sync/lock/spinlock.rs | 106 ++++++++++++++++++++++++++++++
>  7 files changed, 235 insertions(+), 3 deletions(-)
>  create mode 100644 rust/kernel/irq.rs
> 
> --
> 2.45.2
> 

Hi Lyude,

it would be nice if you could run `git format-patch` with `--base`. That
way I immediately have the commit that your series applies to. (Since this
series doesn't apply to `rust-next` for me, but it does apply to
v6.11-rc1, so it's fine)

Thanks.

---
Cheers,
Benno