From: John Hubbard <jhubbard@nvidia.com>
To: Danilo Krummrich <dakr@kernel.org>,
aliceryhl@google.com, acourbot@nvidia.com
Cc: nouveau@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
rust-for-linux@vger.kernel.org
Subject: Re: [PATCH 2/2] drm: nova: select NOVA_CORE
Date: Tue, 28 Oct 2025 12:33:57 -0700 [thread overview]
Message-ID: <10e2a077-dfcc-4bc8-85ef-64dc29bd1465@nvidia.com> (raw)
In-Reply-To: <20251028110058.340320-2-dakr@kernel.org>
On 10/28/25 4:00 AM, Danilo Krummrich wrote:
> The nova-drm driver does not provide any value without nova-core being
> selected as well, hence select NOVA_CORE.
>
> Fixes: cdeaeb9dd762 ("drm: nova-drm: add initial driver skeleton")
> Signed-off-by: Danilo Krummrich <dakr@kernel.org>
> ---
> drivers/gpu/drm/nova/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
Reviewed-by: John Hubbard <jhubbard@nvidia.com>
thanks,
John Hubbard
>
> diff --git a/drivers/gpu/drm/nova/Kconfig b/drivers/gpu/drm/nova/Kconfig
> index 2a70aac64d7e..3e637ad7b5ba 100644
> --- a/drivers/gpu/drm/nova/Kconfig
> +++ b/drivers/gpu/drm/nova/Kconfig
> @@ -5,6 +5,7 @@ config DRM_NOVA
> depends on PCI
> depends on RUST
> select AUXILIARY_BUS
> + select NOVA_CORE
> default n
> help
> Choose this if you want to build the Nova DRM driver for Nvidia
next prev parent reply other threads:[~2025-10-28 19:34 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-28 11:00 [PATCH 1/2] drm: nova: depend on CONFIG_64BIT Danilo Krummrich
2025-10-28 11:00 ` [PATCH 2/2] drm: nova: select NOVA_CORE Danilo Krummrich
2025-10-28 11:42 ` Alexandre Courbot
2025-10-28 19:33 ` John Hubbard [this message]
2025-10-30 22:21 ` Timur Tabi
2025-10-30 22:24 ` John Hubbard
2025-10-28 11:42 ` [PATCH 1/2] drm: nova: depend on CONFIG_64BIT Alexandre Courbot
2025-10-28 19:37 ` John Hubbard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=10e2a077-dfcc-4bc8-85ef-64dc29bd1465@nvidia.com \
--to=jhubbard@nvidia.com \
--cc=acourbot@nvidia.com \
--cc=aliceryhl@google.com \
--cc=dakr@kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=nouveau@lists.freedesktop.org \
--cc=rust-for-linux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).