rust-for-linux.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 1/2] drm: nova: depend on CONFIG_64BIT
@ 2025-10-28 11:00 Danilo Krummrich
  2025-10-28 11:00 ` [PATCH 2/2] drm: nova: select NOVA_CORE Danilo Krummrich
                   ` (2 more replies)
  0 siblings, 3 replies; 8+ messages in thread
From: Danilo Krummrich @ 2025-10-28 11:00 UTC (permalink / raw)
  To: aliceryhl, acourbot, jhubbard
  Cc: nouveau, dri-devel, rust-for-linux, Danilo Krummrich

nova-core already depends on CONFIG_64BIT, hence also depend on
CONFIG_64BIT for nova-drm.

Signed-off-by: Danilo Krummrich <dakr@kernel.org>
---
 drivers/gpu/drm/nova/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/nova/Kconfig b/drivers/gpu/drm/nova/Kconfig
index cca6a3fea879..2a70aac64d7e 100644
--- a/drivers/gpu/drm/nova/Kconfig
+++ b/drivers/gpu/drm/nova/Kconfig
@@ -1,5 +1,6 @@
 config DRM_NOVA
 	tristate "Nova DRM driver"
+	depends on 64BIT
 	depends on DRM=y
 	depends on PCI
 	depends on RUST
-- 
2.51.0


^ permalink raw reply related	[flat|nested] 8+ messages in thread

* [PATCH 2/2] drm: nova: select NOVA_CORE
  2025-10-28 11:00 [PATCH 1/2] drm: nova: depend on CONFIG_64BIT Danilo Krummrich
@ 2025-10-28 11:00 ` Danilo Krummrich
  2025-10-28 11:42   ` Alexandre Courbot
                     ` (2 more replies)
  2025-10-28 11:42 ` [PATCH 1/2] drm: nova: depend on CONFIG_64BIT Alexandre Courbot
  2025-10-28 19:37 ` John Hubbard
  2 siblings, 3 replies; 8+ messages in thread
From: Danilo Krummrich @ 2025-10-28 11:00 UTC (permalink / raw)
  To: aliceryhl, acourbot, jhubbard
  Cc: nouveau, dri-devel, rust-for-linux, Danilo Krummrich

The nova-drm driver does not provide any value without nova-core being
selected as well, hence select NOVA_CORE.

Fixes: cdeaeb9dd762 ("drm: nova-drm: add initial driver skeleton")
Signed-off-by: Danilo Krummrich <dakr@kernel.org>
---
 drivers/gpu/drm/nova/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/nova/Kconfig b/drivers/gpu/drm/nova/Kconfig
index 2a70aac64d7e..3e637ad7b5ba 100644
--- a/drivers/gpu/drm/nova/Kconfig
+++ b/drivers/gpu/drm/nova/Kconfig
@@ -5,6 +5,7 @@ config DRM_NOVA
 	depends on PCI
 	depends on RUST
 	select AUXILIARY_BUS
+	select NOVA_CORE
 	default n
 	help
 	  Choose this if you want to build the Nova DRM driver for Nvidia
-- 
2.51.0


^ permalink raw reply related	[flat|nested] 8+ messages in thread

* Re: [PATCH 1/2] drm: nova: depend on CONFIG_64BIT
  2025-10-28 11:00 [PATCH 1/2] drm: nova: depend on CONFIG_64BIT Danilo Krummrich
  2025-10-28 11:00 ` [PATCH 2/2] drm: nova: select NOVA_CORE Danilo Krummrich
@ 2025-10-28 11:42 ` Alexandre Courbot
  2025-10-28 19:37 ` John Hubbard
  2 siblings, 0 replies; 8+ messages in thread
From: Alexandre Courbot @ 2025-10-28 11:42 UTC (permalink / raw)
  To: Danilo Krummrich, aliceryhl, acourbot, jhubbard
  Cc: nouveau, dri-devel, rust-for-linux, Nouveau

On Tue Oct 28, 2025 at 8:00 PM JST, Danilo Krummrich wrote:
> nova-core already depends on CONFIG_64BIT, hence also depend on
> CONFIG_64BIT for nova-drm.
>
> Signed-off-by: Danilo Krummrich <dakr@kernel.org>

Reviewed-by: Alexandre Courbot <acourbot@nvidia.com>

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH 2/2] drm: nova: select NOVA_CORE
  2025-10-28 11:00 ` [PATCH 2/2] drm: nova: select NOVA_CORE Danilo Krummrich
@ 2025-10-28 11:42   ` Alexandre Courbot
  2025-10-28 19:33   ` John Hubbard
  2025-10-30 22:21   ` Timur Tabi
  2 siblings, 0 replies; 8+ messages in thread
From: Alexandre Courbot @ 2025-10-28 11:42 UTC (permalink / raw)
  To: Danilo Krummrich, aliceryhl, acourbot, jhubbard
  Cc: nouveau, dri-devel, rust-for-linux, Nouveau

On Tue Oct 28, 2025 at 8:00 PM JST, Danilo Krummrich wrote:
> The nova-drm driver does not provide any value without nova-core being
> selected as well, hence select NOVA_CORE.
>
> Fixes: cdeaeb9dd762 ("drm: nova-drm: add initial driver skeleton")
> Signed-off-by: Danilo Krummrich <dakr@kernel.org>

Reviewed-by: Alexandre Courbot <acourbot@nvidia.com>

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH 2/2] drm: nova: select NOVA_CORE
  2025-10-28 11:00 ` [PATCH 2/2] drm: nova: select NOVA_CORE Danilo Krummrich
  2025-10-28 11:42   ` Alexandre Courbot
@ 2025-10-28 19:33   ` John Hubbard
  2025-10-30 22:21   ` Timur Tabi
  2 siblings, 0 replies; 8+ messages in thread
From: John Hubbard @ 2025-10-28 19:33 UTC (permalink / raw)
  To: Danilo Krummrich, aliceryhl, acourbot; +Cc: nouveau, dri-devel, rust-for-linux

On 10/28/25 4:00 AM, Danilo Krummrich wrote:
> The nova-drm driver does not provide any value without nova-core being
> selected as well, hence select NOVA_CORE.
> 
> Fixes: cdeaeb9dd762 ("drm: nova-drm: add initial driver skeleton")
> Signed-off-by: Danilo Krummrich <dakr@kernel.org>
> ---
>   drivers/gpu/drm/nova/Kconfig | 1 +
>   1 file changed, 1 insertion(+)

Reviewed-by: John Hubbard <jhubbard@nvidia.com>

thanks,
John Hubbard

> 
> diff --git a/drivers/gpu/drm/nova/Kconfig b/drivers/gpu/drm/nova/Kconfig
> index 2a70aac64d7e..3e637ad7b5ba 100644
> --- a/drivers/gpu/drm/nova/Kconfig
> +++ b/drivers/gpu/drm/nova/Kconfig
> @@ -5,6 +5,7 @@ config DRM_NOVA
>   	depends on PCI
>   	depends on RUST
>   	select AUXILIARY_BUS
> +	select NOVA_CORE
>   	default n
>   	help
>   	  Choose this if you want to build the Nova DRM driver for Nvidia


^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH 1/2] drm: nova: depend on CONFIG_64BIT
  2025-10-28 11:00 [PATCH 1/2] drm: nova: depend on CONFIG_64BIT Danilo Krummrich
  2025-10-28 11:00 ` [PATCH 2/2] drm: nova: select NOVA_CORE Danilo Krummrich
  2025-10-28 11:42 ` [PATCH 1/2] drm: nova: depend on CONFIG_64BIT Alexandre Courbot
@ 2025-10-28 19:37 ` John Hubbard
  2 siblings, 0 replies; 8+ messages in thread
From: John Hubbard @ 2025-10-28 19:37 UTC (permalink / raw)
  To: Danilo Krummrich, aliceryhl, acourbot; +Cc: nouveau, dri-devel, rust-for-linux

On 10/28/25 4:00 AM, Danilo Krummrich wrote:
> nova-core already depends on CONFIG_64BIT, hence also depend on
> CONFIG_64BIT for nova-drm.
> 
> Signed-off-by: Danilo Krummrich <dakr@kernel.org>
> ---
>  drivers/gpu/drm/nova/Kconfig | 1 +
>  1 file changed, 1 insertion(+)

Reviewed-by: John Hubbard <jhubbard@nvidia.com>

thanks,
John Hubbard

> 
> diff --git a/drivers/gpu/drm/nova/Kconfig b/drivers/gpu/drm/nova/Kconfig
> index cca6a3fea879..2a70aac64d7e 100644
> --- a/drivers/gpu/drm/nova/Kconfig
> +++ b/drivers/gpu/drm/nova/Kconfig
> @@ -1,5 +1,6 @@
>  config DRM_NOVA
>  	tristate "Nova DRM driver"
> +	depends on 64BIT
>  	depends on DRM=y
>  	depends on PCI
>  	depends on RUST


^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH 2/2] drm: nova: select NOVA_CORE
  2025-10-28 11:00 ` [PATCH 2/2] drm: nova: select NOVA_CORE Danilo Krummrich
  2025-10-28 11:42   ` Alexandre Courbot
  2025-10-28 19:33   ` John Hubbard
@ 2025-10-30 22:21   ` Timur Tabi
  2025-10-30 22:24     ` John Hubbard
  2 siblings, 1 reply; 8+ messages in thread
From: Timur Tabi @ 2025-10-30 22:21 UTC (permalink / raw)
  To: Alexandre Courbot, dakr@kernel.org, aliceryhl@google.com,
	John Hubbard
  Cc: dri-devel@lists.freedesktop.org, nouveau@lists.freedesktop.org,
	rust-for-linux@vger.kernel.org

On Tue, 2025-10-28 at 12:00 +0100, Danilo Krummrich wrote:
> The nova-drm driver does not provide any value without nova-core being
> selected as well, hence select NOVA_CORE.

Isn't the converse also true?  nova-core doesn't do anything of value without a DRM driver.

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH 2/2] drm: nova: select NOVA_CORE
  2025-10-30 22:21   ` Timur Tabi
@ 2025-10-30 22:24     ` John Hubbard
  0 siblings, 0 replies; 8+ messages in thread
From: John Hubbard @ 2025-10-30 22:24 UTC (permalink / raw)
  To: Timur Tabi, Alexandre Courbot, dakr@kernel.org,
	aliceryhl@google.com
  Cc: dri-devel@lists.freedesktop.org, nouveau@lists.freedesktop.org,
	rust-for-linux@vger.kernel.org

On 10/30/25 3:21 PM, Timur Tabi wrote:
> On Tue, 2025-10-28 at 12:00 +0100, Danilo Krummrich wrote:
>> The nova-drm driver does not provide any value without nova-core being
>> selected as well, hence select NOVA_CORE.
> 
> Isn't the converse also true?  nova-core doesn't do anything of value without a DRM driver.

Absolutely not true. See: vGPU on Nova. :)


thanks,
-- 
John Hubbard


^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2025-10-30 22:25 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-10-28 11:00 [PATCH 1/2] drm: nova: depend on CONFIG_64BIT Danilo Krummrich
2025-10-28 11:00 ` [PATCH 2/2] drm: nova: select NOVA_CORE Danilo Krummrich
2025-10-28 11:42   ` Alexandre Courbot
2025-10-28 19:33   ` John Hubbard
2025-10-30 22:21   ` Timur Tabi
2025-10-30 22:24     ` John Hubbard
2025-10-28 11:42 ` [PATCH 1/2] drm: nova: depend on CONFIG_64BIT Alexandre Courbot
2025-10-28 19:37 ` John Hubbard

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).