Re: [PATCH v4 1/2] gpu: nova-core: gsp: inline methods providing queue range invariants

Gary Guo
2026-04-01T15:29:00Z

On Wed Apr 1, 2026 at 3:29 PM BST, Alexandre Courbot wrote:
> These methods hold a range invariant for the read/write pointers
> (namely, that the pointers are always in the `0..MSGQ_NUM_PAGES` range).
>
> The calling code depends on these invariants to build properly, so make
> them `#[inline(always)]` to ensure that they are propagated where they
> need to be.
>
> Signed-off-by: Alexandre Courbot <acourbot@nvidia.com>

Reviewed-by: Gary Guo <gary@garyguo.net>

> ---
> drivers/gpu/nova-core/gsp/cmdq.rs | 4 ++++
> drivers/gpu/nova-core/gsp/fw.rs | 4 ++++
> 2 files changed, 8 insertions(+)