From: Danilo Krummrich <dakr@kernel.org>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: "Oliver Neukum" <oneukum@suse.com>,
"Daniel Almeida" <daniel.almeida@collabora.com>,
"Miguel Ojeda" <ojeda@kernel.org>,
"Alex Gaynor" <alex.gaynor@gmail.com>,
"Boqun Feng" <boqun.feng@gmail.com>,
"Gary Guo" <gary@garyguo.net>,
"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
"Benno Lossin" <lossin@kernel.org>,
"Andreas Hindborg" <a.hindborg@kernel.org>,
"Alice Ryhl" <aliceryhl@google.com>,
"Trevor Gross" <tmgross@umich.edu>,
linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org,
linux-usb@vger.kernel.org
Subject: Re: [PATCH 1/2] rust: usb: add basic USB abstractions
Date: Tue, 23 Sep 2025 16:25:46 +0200 [thread overview]
Message-ID: <13ce0ad0-f0d5-4579-9a48-db727baa177f@kernel.org> (raw)
In-Reply-To: <2025092307-scoop-challenge-4054@gregkh>
On 9/23/25 4:22 PM, Greg Kroah-Hartman wrote:
> On Tue, Sep 23, 2025 at 04:16:36PM +0200, Oliver Neukum wrote:
>> On 23.09.25 16:13, Greg Kroah-Hartman wrote:
>>
>>> Functions like usb_fill_bulk_urb() takes a pointer to a usb_device, not
>>> an interface. Yes, we should fix that, but that "mistake" dates way way
>>> way back to the original USB api decades ago. So much so that I didn't
>>> even remember that we used that pointer there :)
>>
>> How would we do that? We need to be able to send at least control
>> request to devices before we have established which configurations
>> or interfaces the device has.
>
> Oops, I thought that usb_dev in struct usb_interface was a pointer to
> struct usb_device, but no, it's something else... So no, we need to
> keep that as-is for now.
You can still get it via interface_to_usbdev(), no?
next prev parent reply other threads:[~2025-09-23 14:25 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-25 18:18 [PATCH 0/2] rust: usb: add initial USB abstractions Daniel Almeida
2025-08-25 18:18 ` [PATCH 1/2] rust: usb: add basic " Daniel Almeida
2025-08-25 20:49 ` Benno Lossin
2025-08-25 21:03 ` Daniel Almeida
2025-09-23 13:21 ` Danilo Krummrich
2025-09-23 13:31 ` Daniel Almeida
2025-09-23 14:03 ` Danilo Krummrich
2025-09-23 14:30 ` Greg Kroah-Hartman
2025-09-23 14:38 ` Danilo Krummrich
2025-09-23 14:52 ` Greg Kroah-Hartman
2025-09-23 15:06 ` Danilo Krummrich
2025-09-23 14:58 ` Alan Stern
2025-09-23 14:13 ` Greg Kroah-Hartman
2025-09-23 14:16 ` Oliver Neukum
2025-09-23 14:22 ` Greg Kroah-Hartman
2025-09-23 14:25 ` Danilo Krummrich [this message]
2025-09-23 14:37 ` Greg Kroah-Hartman
2025-09-23 14:42 ` Danilo Krummrich
2025-09-23 14:49 ` Greg Kroah-Hartman
2025-09-23 15:46 ` Danilo Krummrich
2025-09-23 14:18 ` Danilo Krummrich
2025-08-25 18:18 ` [PATCH 2/2] samples: rust: add a USB driver sample Daniel Almeida
2025-09-06 11:14 ` Greg Kroah-Hartman
2025-09-06 12:04 ` Daniel Almeida
2025-09-06 12:10 ` Greg Kroah-Hartman
2025-09-06 12:41 ` Daniel Almeida
2025-09-06 13:07 ` Greg Kroah-Hartman
2025-09-06 14:49 ` Alan Stern
2025-09-06 14:56 ` Daniel Almeida
2025-09-06 13:22 ` Danilo Krummrich
2025-09-06 14:50 ` Daniel Almeida
2025-09-06 15:22 ` Danilo Krummrich
2025-09-06 15:46 ` Daniel Almeida
2025-09-06 15:48 ` Danilo Krummrich
2025-09-09 11:19 ` Simon Neuenhausen
2025-09-09 12:12 ` Daniel Almeida
2025-09-09 13:25 ` Greg Kroah-Hartman
2025-09-09 12:14 ` Greg Kroah-Hartman
2025-09-09 13:05 ` Simon Neuenhausen
2025-08-25 20:32 ` [PATCH 0/2] rust: usb: add initial USB abstractions Greg Kroah-Hartman
2025-09-23 12:05 ` Greg Kroah-Hartman
2025-09-23 12:29 ` Alice Ryhl
2025-09-23 12:31 ` Greg Kroah-Hartman
2025-09-23 12:34 ` Daniel Almeida
2025-09-23 12:41 ` Greg Kroah-Hartman
2025-09-23 12:55 ` Miguel Ojeda
2025-09-23 12:56 ` Miguel Ojeda
2025-09-23 13:24 ` Daniel Almeida
2025-09-23 21:29 ` Miguel Ojeda
2025-09-25 12:52 ` Greg Kroah-Hartman
2025-09-25 12:58 ` Daniel Almeida
2025-09-25 13:29 ` Danilo Krummrich
2025-09-25 17:38 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=13ce0ad0-f0d5-4579-9a48-db727baa177f@kernel.org \
--to=dakr@kernel.org \
--cc=a.hindborg@kernel.org \
--cc=alex.gaynor@gmail.com \
--cc=aliceryhl@google.com \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=daniel.almeida@collabora.com \
--cc=gary@garyguo.net \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=lossin@kernel.org \
--cc=ojeda@kernel.org \
--cc=oneukum@suse.com \
--cc=rust-for-linux@vger.kernel.org \
--cc=tmgross@umich.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).