Re: [RFC PATCH v2 1/3] rust: core abstractions for network PHY drivers

[Andrew Lunn <andrew@lunn.ch>]

> > +    /// Updates the link status.
> > +    pub fn genphy_update_link(&mut self) -> Result // ...
> > +
> > +    /// Reads Link partner ability.
> > +    pub fn genphy_read_lpa(&mut self) -> Result // ...
> > +
> > +    /// Reads PHY abilities.
> > +    pub fn genphy_read_abilities(&mut self) -> Result // ...
> 
> Do these functions need to be public? It seems like they are just used
> to update internal state, which is wrapped up into more user-facing
> API
 
There are C drivers which need these.

Any function starting with genphy_ is based on the 802.3 standard. But
PHY vendors get stuff wrong, and workarounds are needed. That often
means calling one of these helpers, and then doing additional steps to
fix up whatever is broken.

So these probably don't need exporting for the first Rust driver, but
a later driver might need them.

	Andrew