From: Krzysztof Kozlowski <krzk@kernel.org>
To: "Markus Probst" <markus.probst@posteo.de>,
"Lee Jones" <lee@kernel.org>, "Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Miguel Ojeda" <ojeda@kernel.org>,
"Boqun Feng" <boqun@kernel.org>, "Gary Guo" <gary@garyguo.net>,
"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
"Benno Lossin" <lossin@kernel.org>,
"Andreas Hindborg" <a.hindborg@kernel.org>,
"Alice Ryhl" <aliceryhl@google.com>,
"Trevor Gross" <tmgross@umich.edu>,
"Danilo Krummrich" <dakr@kernel.org>
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-staging@lists.linux.dev, rust-for-linux@vger.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: mfd: Add binding for synology,microp devices
Date: Sat, 7 Mar 2026 15:25:18 +0100 [thread overview]
Message-ID: <1b603382-273e-48c7-841e-aaf505187ece@kernel.org> (raw)
In-Reply-To: <be179573-edc3-4b6c-8c91-ae7b0c61c1b1@kernel.org>
On 07/03/2026 11:20, Krzysztof Kozlowski wrote:
>> + power-led:
>> + $ref: /schemas/leds/common.yaml
>> + unevaluatedProperties: false
>> + status-led:
>> + $ref: /schemas/leds/common.yaml
>> + unevaluatedProperties: false
>> + alert-led:
>> + $ref: /schemas/leds/common.yaml
>> + unevaluatedProperties: false
>> + usb-led:
>> + $ref: /schemas/leds/common.yaml
>> + unevaluatedProperties: false
>
> That's pretty unreadable code.
... and could be simpler with patternProperties and regex
>
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-03-07 14:25 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-06 19:38 [PATCH 0/2] Introduce Synology Microp driver Markus Probst
2026-03-06 19:38 ` [PATCH 1/2] dt-bindings: mfd: Add binding for synology,microp devices Markus Probst
2026-03-07 10:20 ` Krzysztof Kozlowski
2026-03-07 14:25 ` Krzysztof Kozlowski [this message]
2026-03-07 14:43 ` Markus Probst
2026-03-07 15:10 ` Krzysztof Kozlowski
2026-03-07 15:03 ` Markus Probst
2026-03-07 15:12 ` Krzysztof Kozlowski
2026-03-07 15:42 ` Krzysztof Kozlowski
2026-03-06 19:38 ` [PATCH 2/2] staging: Add initial synology microp driver Markus Probst
2026-03-07 7:15 ` Greg Kroah-Hartman
2026-03-07 12:58 ` Markus Probst
2026-03-08 7:08 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1b603382-273e-48c7-841e-aaf505187ece@kernel.org \
--to=krzk@kernel.org \
--cc=a.hindborg@kernel.org \
--cc=aliceryhl@google.com \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun@kernel.org \
--cc=conor+dt@kernel.org \
--cc=dakr@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gary@garyguo.net \
--cc=gregkh@linuxfoundation.org \
--cc=krzk+dt@kernel.org \
--cc=lee@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=lossin@kernel.org \
--cc=markus.probst@posteo.de \
--cc=ojeda@kernel.org \
--cc=robh@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=tmgross@umich.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox